Hi Hans N/Anders Bj,
Thanks for your review.
>>> A log record can be written before the "goto try_again".
I would like to get logs record for BAD_HANDLE and other types of errors also.
That's why the log record is on top common for all the errors.
>>> An alternative to try_again c
Ack, code review only/Thanks HansN
-Original Message-
From: nagendr...@oracle.com [mailto:nagendr...@oracle.com]
Sent: den 21 maj 2015 09:21
To: Hans Nordebäck; praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd: ignore invalid modification of
Ack (for both patches on this ticket), with some comments:
* Boiler plates (licence & copyright) are missing in the new files
* The README assumes the developer uses Ubuntu and has sudo rights (root
access). Instead, I think it would be better to describe how to download
the Google test framewo
ack, code review only. Some comments below discussed with AndersBj.
A log record can be written before the "goto try_again". An alternative
to try_again can be to change IMMA_SYNCR_TIMEOUT
from the default 10 seconds to a higher value.
/Thanks HansN
On 05/12/2015 10:44 AM, nagendr...@oracle.com
Summary: IMM: Detour of accessorGet into ImmModel::searchInitialize removed
[#674]
Review request for Trac Ticket(s): 674
Peer Reviewer(s): Neel; Zoran
Pull request to:
Affected branch(es): default(4.7)
Development branch: default(4.7)
Impacted area Impact
osaf/services/saf/immsv/immnd/ImmModel.cc | 30 +++---
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +-
2 files changed, 16 insertions(+), 16 deletions(-)
The detour seemed mostly to deal with handling of the SaImmScopeT type.
The scope of SA_IMM_ONE is only relevant
On 2015-05-26 07:23, praveen malviya wrote:
>
>
>
> On 08-May-15 1:41 PM, Hans Nordeback wrote:
>>00-README.unittest | 32
>>configure.ac| 1 +
>>osaf/services/saf/amf/amfd/Makefile.am | 2 +-
