To be clear, that was a +1 for Mark's suggestion:
> In cases like that, I'd be of a mind to go "+2 Awesome! Thanks for
> catching this! It would be great to have a unit test for this, but it's
> clear the current code is broken so I'm fine with merging the fix
> without a test". You could say it's
+1 also.
I spent less than half the time on my first fix (so far) understanding the
problem, reproducing it, coding it and learning about the code review
system.
Much more than half the time was spent on reverse engineering existing
tests to be able to add new ones (which had to use features not u
On Nov 11, 2013, at 6:42 PM, Vishvananda Ishaya wrote:
> It also gives the submitter a specific example of a well-written test, which
> can be a faster way to learn than forcing them to get there via trial and
> error.
+1. Implementing a policy that has as the end effect more knowledgeable
con
On Oct 31, 2013, at 6:56 AM, Clint Byrum wrote:
> Excerpts from Mark McLoughlin's message of 2013-10-31 06:30:32 -0700:
>> On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote:
>>> This is a bit of a social norms thread
>>>
>>> I've been consistently asking for tests in reviews for a whi
Hey thanks a lot!
- Original Message -
From: "Clint Byrum"
To: "openstack-dev"
Sent: Thursday, October 31, 2013 7:49:55 PM
Subject: Re: [openstack-dev] When is it okay for submitters to say 'I don't
want to add tests' ?
Excerpts from Khanh-Toan
>-Original Message-
>From: Chris Friesen [mailto:chris.frie...@windriver.com]
>Sent: 31 October 2013 17:07
>To: openstack-dev@lists.openstack.org
>Subject: Re: [openstack-dev] When is it okay for submitters to say 'I don't
>want to add tests' ?
>
>O
On 10/31/2013 03:24 PM, Jeremy Stanley wrote:
On 2013-10-31 13:30:32 + (+), Mark McLoughlin wrote:
[...]
In cases like that, I'd be of a mind to go "+2 Awesome! Thanks for
catching this! It would be great to have a unit test for this, but
it's clear the current code is broken so I'm fine
On 2013-10-31 13:30:32 + (+), Mark McLoughlin wrote:
[...]
> In cases like that, I'd be of a mind to go "+2 Awesome! Thanks for
> catching this! It would be great to have a unit test for this, but
> it's clear the current code is broken so I'm fine with merging the
> fix without a test". Yo
On 10/30/2013 11:37 PM, Robert Collins wrote:
> This is a bit of a social norms thread
>
> I've been consistently asking for tests in reviews for a while now,
> and I get the occasional push-back. I think this falls into a few
> broad camps:
>
> A - there is no test suite at all, adding one
I like Steve's suggestion:
> The approach the Heat team have sometimes taken in this situation is to
> merge the patch, but raise a bug (targetted at the next milestone)
> identifying the missing coverage.
I'm (almost!) a first time contributor and I've put a fix on the backburner
as I find the t
On 13-10-30 10:37 PM, Robert Collins wrote:
This is a bit of a social norms thread
I've been consistently asking for tests in reviews for a while now,
and I get the occasional push-back. I think this falls into a few
broad camps:
A - there is no test suite at all, adding one in unreasonable
On Thu, Oct 31, 2013 at 01:30:32PM +, Mark McLoughlin wrote:
> On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote:
> > This is a bit of a social norms thread
> >
> > I've been consistently asking for tests in reviews for a while now,
> > and I get the occasional push-back. I think thi
Excerpts from Khanh-Toan Tran's message of 2013-10-31 07:22:06 -0700:
> Hi all,
>
> As a newbie of the community, I'm not familiar with unittest and how to use
> it here. I've learned that Jenkins runs tests
> everytime we submit some code. But how to write the test and what is a 'good
> test' a
On 2013-10-31 09:05, Kyle Mestery (kmestery) wrote:
On Oct 31, 2013, at 8:56 AM, Clint Byrum wrote:
Excerpts from Mark McLoughlin's message of 2013-10-31 06:30:32 -0700:
On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote:
This is a bit of a social norms thread
I've been consistently
On 10/31/2013 06:04 AM, Rosa, Andrea (HP Cloud Services) wrote:
A - there is no test suite at all, adding one in unreasonable B - this thing
cannot
be tested in this context (e.g. functional tests are defined in a different
tree)
C - this particular thing is very hard to test
>> D - testing t
Mestery (kmestery)"
To: "OpenStack Development Mailing List (not for usage questions)"
Sent: Thursday, October 31, 2013 3:05:27 PM
Subject: Re: [openstack-dev] When is it okay for submitters to say 'I don't
want to add tests' ?
On Oct 31, 2013, at 8:56 AM, Clint Byrum
On Oct 31, 2013, at 8:56 AM, Clint Byrum wrote:
> Excerpts from Mark McLoughlin's message of 2013-10-31 06:30:32 -0700:
>> On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote:
>>> This is a bit of a social norms thread
>>>
>>> I've been consistently asking for tests in reviews for a while
Excerpts from Mark McLoughlin's message of 2013-10-31 06:30:32 -0700:
> On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote:
> > This is a bit of a social norms thread
> >
> > I've been consistently asking for tests in reviews for a while now,
> > and I get the occasional push-back. I thin
On Thu, 2013-10-31 at 15:37 +1300, Robert Collins wrote:
> This is a bit of a social norms thread
>
> I've been consistently asking for tests in reviews for a while now,
> and I get the occasional push-back. I think this falls into a few
> broad camps:
>
> A - there is no test suite at all, a
On 10/30/2013 10:37 PM, Robert Collins wrote:
This is a bit of a social norms thread
I've been consistently asking for tests in reviews for a while now,
and I get the occasional push-back. I think this falls into a few
broad camps:
A - there is no test suite at all, adding one in unreasonab
Hi all,
>This is a bit of a social norms thread
>
>I've been consistently asking for tests in reviews for a while now, and I get
>the
>occasional push-back. I think this falls into a few broad camps:
>
>A - there is no test suite at all, adding one in unreasonable B - this thing
>cannot
>be
+1 I think C always means something is not architected/designed correctly
or invokes the 'code smell'[1] to me.
If its to hard to test, then it will be to hard to change, which will in
the long term be a liability.
Better to avoid the liability upfront by just fixing the cause of the
'smell' in t
> When is it okay for submitters to say 'I don't want to add tests' ?
When they don't want their patch merged :-) But more seriously
On Thu, Oct 31, 2013 at 1:07 PM, Robert Collins
wrote:
> This is a bit of a social norms thread
>
> I've been consistently asking for tests in reviews for
On Wed, Oct 30, 2013 at 7:37 PM, Robert Collins
wrote:
> This is a bit of a social norms thread
>
> I've been consistently asking for tests in reviews for a while now,
> and I get the occasional push-back. I think this falls into a few
> broad camps:
>
> A - there is no test suite at all, addi
This is a bit of a social norms thread
I've been consistently asking for tests in reviews for a while now,
and I get the occasional push-back. I think this falls into a few
broad camps:
A - there is no test suite at all, adding one in unreasonable
B - this thing cannot be tested in this conte
25 matches
Mail list logo
