Re: [Openvpn-devel] [PATCH] show extra info for OpenSSL errors

2023-07-12 Thread Selva Nair
Hi, This looks good except that the format of the log could be kept closer to the current one: On Fri, Jul 7, 2023 at 2:59 PM Arne Schwabe wrote: > This also shows the extra data from the OpenSSL error function that > can contain extra information. For example, the command > > openvpn --pro

Re: [Openvpn-devel] [PATCH v3 3/4] Check if the -wrap argument is actually supported by the platform's ld

2023-07-12 Thread Frank Lichtenheld
On Wed, Jul 12, 2023 at 01:10:53PM +0200, Frank Lichtenheld wrote: > On Wed, Jul 12, 2023 at 11:55:29AM +0200, Arne Schwabe wrote: > > This avoids build errors on macOS. Also the test_tls_crypt command works > > just fine on FreeBSD with its linkers, so do not make that test Linux only. > > > > Pa

Re: [Openvpn-devel] [PATCH v2] Mock openvpn_exece on win32 also for test_tls_crypt

2023-07-12 Thread Frank Lichtenheld
On Wed, Jul 12, 2023 at 11:54:12AM +0200, Arne Schwabe wrote: > This function is needed to commpile on win32 as run_command.c defines it > on Unix Linux but on windows it is defined in win32.c which pulls in too > many other unresolvable symbols. > > Patch v2: Also add mock_win32_execve.c to autom

Re: [Openvpn-devel] [PATCH v3 3/4] Check if the -wrap argument is actually supported by the platform's ld

2023-07-12 Thread Frank Lichtenheld
On Wed, Jul 12, 2023 at 11:55:29AM +0200, Arne Schwabe wrote: > This avoids build errors on macOS. Also the test_tls_crypt command works > just fine on FreeBSD with its linkers, so do not make that test Linux only. > > Patch v2: allow running with old cmake version (cmake 3 on RHEL7 with EPEL >

[Openvpn-devel] [PATCH v3 3/4] Check if the -wrap argument is actually supported by the platform's ld

2023-07-12 Thread Arne Schwabe
This avoids build errors on macOS. Also the test_tls_crypt command works just fine on FreeBSD with its linkers, so do not make that test Linux only. Patch v2: allow running with old cmake version (cmake 3 on RHEL7 with EPEL is only 3.17) Patch v3: add OPTIONAL keyword to Incldue required

[Openvpn-devel] [PATCH v2] Mock openvpn_exece on win32 also for test_tls_crypt

2023-07-12 Thread Arne Schwabe
This function is needed to commpile on win32 as run_command.c defines it on Unix Linux but on windows it is defined in win32.c which pulls in too many other unresolvable symbols. Patch v2: Also add mock_win32_execve.c to automake files Change-Id: I8c8fe298eb30e211279f3fc010584b9d3bc14b4a Signed-o

[Openvpn-devel] [PATCH] Ignore Ipv6 route delete request on Android and set ipv4 verbosity to 7

2023-07-12 Thread Arne Schwabe
Android has no facility nor need one to delete routes as routes are automatically cleaned up when the tun interface is closed. Also adjust the IPv4 message to be only shown and verb 7 and rephrase the message. Change-Id: If8f920d378c31e9ea773ce1f56f3df50f1ec36cd Signed-off-by: Arne Schwabe --- s