RE: [EXT] config_default vs subtargets having their own config_?

2023-03-05 Thread Andy Tang
Hi Tim, Thanks for doing this. I suggest to have config_ for each subtargs in the subtarget dirs.. I have sent the patches for adding the imx8 platform. But it can't be accepted due to the firmware issue. Basically the DDR firmware for im8x was released by a self-extracted binary. When

[sdwalker/sdwalker.github.io] d7a764: This week's update

2023-03-05 Thread Stephen Walker via openwrt-devel
The sender domain has a DMARC Reject/Quarantine policy which disallows sending mailing list messages using the original "From" header. To mitigate this problem, the original message has been wrapped automatically by the mailing list software.--- Begin Message --- Branch: refs/heads/master

Re: [PATCH v2] mvebu: add support for Fortinet FortiGate 50E

2023-03-05 Thread INAGAKI Hiroshi
Hi Hauke, thank you for your review. On 2023/03/06 1:42, Hauke Mehrtens wrote: On 3/1/23 17:01, INAGAKI Hiroshi wrote: Fortinet FortiGate 50E (FG-50E) is a UTM, based on Armada 385 (88F6820). Notes: - All "SPEED" LEDs(Green/Amber) of LAN and 1000M "SPEED" LEDs(Green) of    WAN1/2 are

[PATCH uqmi v1] uqmi: avoid gcc false error reporting (storing the address of local variable 'complete' in '*req.complete')

2023-03-05 Thread Peter Seiderer
Avoid gcc false error reporting (req->complete is later reset to NULL in case of use of local complete): dev.c:217:23: error: storing the address of local variable 'complete' in '*req.complete' [-Werror=dangling-pointer=] 217 | req->complete = |

Re: [PATCH uqmi] fix uloop initialization

2023-03-05 Thread Hauke Mehrtens
Hi Leon, Please add a prefix for which application with patch is next time. git format-patch origin/master --subject-prefix="PATCH uqmi" On 11/27/22 09:38, Leon M. Busch-George wrote: uloop_init is already called in main. uloop_done is just missing. Signed-off-by: Leon M. Busch-George ---

Re: [ubus PATCH] libubus: remove global variables

2023-03-05 Thread Hauke Mehrtens
Hi Simon, On 1/5/23 15:30, Simon Tate wrote: Remove the use of global blob_buf and blob_attr variables to allow for better thread safety with a ctx per thread on client invoke and sends. Add the same variables to within each calling function's scope, encapsulating the memory usage there.

Re: [PATCH v2] mvebu: add support for Fortinet FortiGate 50E

2023-03-05 Thread Hauke Mehrtens
On 3/1/23 17:01, INAGAKI Hiroshi wrote: Fortinet FortiGate 50E (FG-50E) is a UTM, based on Armada 385 (88F6820). Notes: - All "SPEED" LEDs(Green/Amber) of LAN and 1000M "SPEED" LEDs(Green) of WAN1/2 are connected to GPIO expander. There is no way to indicate link speed of