[OpenWrt-Devel] [PATCH 3/3] netifd: Read current link state when processing netlink event

2014-10-22 Thread Hans Dedecker
Netifd commit b2dcb02570939d98b92c7c55db1c328693a5d52a introduces a race condition resulting into infinite toggling interfaces (eg static interfaces with linksensing enabled, vlan interfaces with proto none (#18106)) when linksensing is enabled resulting into a crash. As netlink event messages

Re: [OpenWrt-Devel] [PATCH 3/3] netifd: Read current link state when processing netlink event

2014-10-22 Thread Felix Fietkau
On 2014-10-22 14:14, Hans Dedecker wrote: Netifd commit b2dcb02570939d98b92c7c55db1c328693a5d52a introduces a race condition resulting into infinite toggling interfaces (eg static interfaces with linksensing enabled, vlan interfaces with proto none (#18106)) when linksensing is enabled

Re: [OpenWrt-Devel] [PATCH 3/3] netifd: Read current link state when processing netlink event

2014-10-22 Thread Hans Dedecker
Hi Felix, Thx for the feedback. Regarding the remaining race condition I assume you refer to the vlan device link status which can be set as enabled due to reading directly the carrier state in cb_rtnl_event while the parent interface is still link status disabled? I will rework my patch based