Re: [ovs-dev] [ovs-dev, V6, 1/2] Makefiles: Generate datapath ovs key fields macros

2019-03-09 Thread 0-day Robot
Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 100 characters long (recommended limit is 79) #59 FILE: build-aux/extract-odp

[ovs-dev] [PATCH V6 2/2] odp-util: Do not rewrite fields with the same values as matched

2019-03-09 Thread Eli Britstein
To improve performance and avoid wasting resources for HW offloaded flows, do not rewrite fields that are matched with the same value. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- lib/odp-util.c| 93 +-- tests/mpls-xlate.at | 2 +- t

[ovs-dev] [PATCH V6 0/2] Do not rewrite fields with the same values as matched

2019-03-09 Thread Eli Britstein
This patch set avoids unnecessary rewrite actions to fields with the same values as matched on. Patch 1 is a pre-step of generating ovs key fields macros Patch 2 avoids the unnecessary rewrites and adapts the tests accordingly Differences from V5: Generating directly offsetof/sizeof arrays instea

[ovs-dev] [PATCH V6 1/2] Makefiles: Generate datapath ovs key fields macros

2019-03-09 Thread Eli Britstein
Generate datapath ovs key fields offset and size array macros as a pre-step for bit-wise comparing fields, with no functional change. Signed-off-by: Eli Britstein Reviewed-by: Roi Dayan --- .gitignore | 1 + build-aux/extract-odp-netlink-macros-h | 55 ++