Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Wentao Jia
Hi,TongHao and Ilya this patch was reported at https://mail.openvswitch.org/pipermail/ovs-discuss/2020-August/050489.html and it was fixed by patch 1f3a090("net: openvswitch: introduce common code for flushing flows") Best regards, Wentao Jia Hi,TongHao and Ilya I guess this bug was fixed

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Wentao Jia
Hi,TongHao and Ilya I guess this bug was fixed by patch 1f3a090("net: openvswitch: introduce common code for flushing flows"),but this patch is not for fix bug use-after-free flow mask Best regards, Wentao Jia >> On 3/24/22 05:17, Wentao Jia wrote: >> > >> > >> > on destroy flow table instan

Re: [ovs-dev] [PATCH ovn v6] Add a northbound interface to program MAC_Binding table

2022-03-24 Thread 0-day Robot
References: <20220324214158.137613-1-svc.eng.git-m...@nutanix.com> Bleep bloop. Greetings svc.eng.git-mail, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks

Re: [ovs-dev] [PATCH ovn v5] Add a northbound interface to program MAC_Binding table

2022-03-24 Thread svc . eng . git-mail
Hi, I’ve updated the patch and sent out v6. There was a memory leak in ovn-nbctl.c which is fixed now. Hopefully the build should pass now. Thank you, Karthik C On 3/24/22, 9:27 AM, "Lorenzo Bianconi" wrote: > From: Karthik Chandrashekar > mailto:karthi...@nutanix.com>> > > Add a new NB and S

[ovs-dev] [PATCH ovn v6] Add a northbound interface to program MAC_Binding table

2022-03-24 Thread svc . eng . git-mail
From: Karthik Chandrashekar Add a new NB and SB table for managing Static MAC_Binding entries. This table is currently supported for logical routers. OVN northd is responsible for propagating the values from NB to SB. OVN controller is responsible for installation MAC lookup flows. The priority o

Re: [ovs-dev] [PATCH ovn] rhel: fix logrotate user config option

2022-03-24 Thread Vladislav Odintsov
Thanks Numan. Regards, Vladislav Odintsov > On 24 Mar 2022, at 17:54, Numan Siddique wrote: > > On Tue, Mar 22, 2022 at 2:33 PM Mark Michelson wrote: >> >> Acked-by: Mark Michelson >> > > Thanks. > > I applied this patch to the main branch and backported upto branch-21.03. > > Numan >> O

Re: [ovs-dev] [PATCH ovn] northd: Use separate SNAT for already-DNATted traffic.

2022-03-24 Thread Numan Siddique
On Thu, Mar 24, 2022 at 4:47 PM Mark Michelson wrote: > > Hi Numan, > > This message got buried in my inbox, so sorry about only replying now. I > have some replies in-line below > > On 3/18/22 16:34, Numan Siddique wrote: > > On Wed, Mar 9, 2022 at 2:38 PM Mark Michelson wrote: > >> > >> Commit

Re: [ovs-dev] [PATCH ovn] northd: Use separate SNAT for already-DNATted traffic.

2022-03-24 Thread Mark Michelson
Hi Numan, This message got buried in my inbox, so sorry about only replying now. I have some replies in-line below On 3/18/22 16:34, Numan Siddique wrote: On Wed, Mar 9, 2022 at 2:38 PM Mark Michelson wrote: Commit 4deac4509abbedd6ffaecf27eed01ddefccea40a introduced functionality in ovn-no

Re: [ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.0.

2022-03-24 Thread Mark Michelson
On 3/24/22 12:32, Ilya Maximets wrote: On 3/10/22 21:49, Mark Michelson wrote: Signed-off-by: Mark Michelson --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 9f3ce3cf3..0f8e068b1 100644 --- a/NEWS +++ b/NE

Re: [ovs-dev] [PATCH branch-2.17 0/2] Release patches for v2.17.0.

2022-03-24 Thread Ilya Maximets
On 2/17/22 23:13, Ilya Maximets wrote: > On 2/17/22 19:45, Ilya Maximets wrote: >> >> Ilya Maximets (2): >> Set release date for 2.17.0. >> Prepare for 2.17.1. >> >> NEWS | 7 ++- >> configure.ac | 2 +- >> debian/changelog | 8 +++- >> 3 files changed, 14 insertions(+)

Re: [ovs-dev] [PATCH] system-traffic.at: Fix flaky DNAT load balancing test.

2022-03-24 Thread Paolo Valerio
Hello Ilya, Ilya Maximets writes: > 'conntrack - DNAT load balancing' test fails from time to time > because not all the group buckets are getting hit. > > In short, the test creates a group with 3 buckets with the same > weight. It creates 12 TCP sessions and expects that each bucket > will be

Re: [ovs-dev] [PATCH] system-traffic.at: Fix flaky DNAT load balancing test.

2022-03-24 Thread Phelan, Michael
> -Original Message- > From: Ilya Maximets > Sent: Thursday 24 March 2022 11:20 > To: ovs-dev@openvswitch.org > Cc: Aaron Conole ; Phelan, Michael > ; Ilya Maximets > Subject: [PATCH] system-traffic.at: Fix flaky DNAT load balancing test. > > 'conntrack - DNAT load balancing' test fail

Re: [ovs-dev] [PATCH v2] dpif-netdev: Allow cross-NUMA polling on selected ports

2022-03-24 Thread Kevin Traynor
On 24/03/2022 16:35, Jan Scheurich wrote: Hi Kevin, This was a bit of a misunderstanding. We didn't check your RFC patch carefully enough to realize that you had meant to encompass our cross-numa-polling function in that RFC patch. Sorry for the confusion. I wouldn't say we are particularly k

Re: [ovs-dev] [PATCH v2] dpif-netdev: Allow cross-NUMA polling on selected ports

2022-03-24 Thread Jan Scheurich via dev
Hi Kevin, This was a bit of a misunderstanding. We didn't check your RFC patch carefully enough to realize that you had meant to encompass our cross-numa-polling function in that RFC patch. Sorry for the confusion. I wouldn't say we are particularly keen on upstreaming exactly our implementati

Re: [ovs-dev] [PATCH ovn branch-22.03 1/2] Set release date for 22.03.0.

2022-03-24 Thread Ilya Maximets
On 3/10/22 21:49, Mark Michelson wrote: > Signed-off-by: Mark Michelson > --- > NEWS | 2 +- > debian/changelog | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/NEWS b/NEWS > index 9f3ce3cf3..0f8e068b1 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,4 +1,4 @@ > -O

Re: [ovs-dev] [PATCH ovn v4] northd: Add support for NAT with multiple DGP

2022-03-24 Thread 0-day Robot
References: <20220324161239.61857-1-sangana.abhi...@nutanix.com> Bleep bloop. Greetings Abhiram Sangana, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 275 ch

[ovs-dev] [PATCH ovn v4] northd: Add support for NAT with multiple DGP

2022-03-24 Thread Abhiram Sangana
Currently, if multiple distributed gateway ports (DGP) are configured on a logical router, NAT is disabled as part of commit 15348b7 (northd: Multiple distributed gateway port support.) This patch adds a new column called "gateway_port" in NAT table that references a distributed gateway port in th

[ovs-dev] OVS DPDK DMA-Dev library/Design Discussion

2022-03-24 Thread Stokes, Ian
Hi All, This meeting is a follow up to the call earlier this week. This week Sunil presented 3 different approaches to integrating DMA-Dev with OVS along with the performance impacts. https://github.com/Sunil-Pai-G/OVS-DPDK-presentation-share/blob/main/OVS%20vhost%20async%20datapath%20design%20

Re: [ovs-dev] [PATCH] system-traffic.at: Fix flaky DNAT load balancing test.

2022-03-24 Thread Eelco Chaudron
On 24 Mar 2022, at 12:20, Ilya Maximets wrote: > 'conntrack - DNAT load balancing' test fails from time to time > because not all the group buckets are getting hit. > > In short, the test creates a group with 3 buckets with the same > weight. It creates 12 TCP sessions and expects that each bu

Re: [ovs-dev] [External] Re: [PATCH] dpif-netdev: add an option to assign pmd rxq to all numas

2022-03-24 Thread Kevin Traynor
Hi Anurag, On 16/03/2022 12:29, Anurag Agarwal wrote: Hello Kevin, Thanks for your inputs. In this scenario we have one VM each on NUMA0 and NUMA1 (VM1 is on NUMA0, VM2 is on NUMA1), dpdk port is on NUMA1. Without cross-numa-polling, VM/VHU queue traffic is evenly distributed based on

Re: [ovs-dev] [PATCH v2] dpif-netdev: Allow cross-NUMA polling on selected ports

2022-03-24 Thread Kevin Traynor
Hi Anurag/Jan, On 21/03/2022 09:42, Anurag Agarwal wrote: From: Jan Scheurich Today dpif-netdev considers PMD threads on a non-local NUMA node for automatic assignment of the rxqs of a port only if there are no local, non-isolated PMDs. On typical servers with both physical ports on o

Re: [ovs-dev] [PATCH ovn] rhel: fix logrotate user config option

2022-03-24 Thread Numan Siddique
On Tue, Mar 22, 2022 at 2:33 PM Mark Michelson wrote: > > Acked-by: Mark Michelson > Thanks. I applied this patch to the main branch and backported upto branch-21.03. Numan > On 3/22/22 13:37, Vladislav Odintsov wrote: > > If rpm is built with libcapng (default), /etc/logrotate.d/ovn > > confi

Re: [ovs-dev] Possible backport candidate

2022-03-24 Thread Numan Siddique
On Tue, Mar 22, 2022 at 12:31 PM Mark Michelson wrote: > > Hi everyone, > > Last month, commit d7514abe1 (acl-log: Log the direction (logical > pipeline) of the matching ACL.) was added to the main branch of OVN. > This commit was made because of the issue report at > https://bugzilla.redhat.com/s

Re: [ovs-dev] [PATCH v5 3/5] pmd.at: Add tests for multi non-local numa pmds.

2022-03-24 Thread David Marchand
On Wed, Mar 23, 2022 at 3:09 PM Kevin Traynor wrote: > > Ensure that if there are no local numa PMD thread > cores available that pmd cores from all other non-local > numas will be used. > > Signed-off-by: Kevin Traynor Acked-by: David Marchand -- David Marchand _

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Tonghao Zhang
On Thu, Mar 24, 2022 at 6:32 PM Ilya Maximets wrote: > > On 3/24/22 05:17, Wentao Jia wrote: > > > > > > on destroy flow table instance, referenced flow mask may be released > > too. fuction ovs_flow_tbl_destroy(), release flow mask first and then > > destroy flow table instance. this will trigger

[ovs-dev] [PATCH] system-traffic.at: Fix flaky DNAT load balancing test.

2022-03-24 Thread Ilya Maximets
'conntrack - DNAT load balancing' test fails from time to time because not all the group buckets are getting hit. In short, the test creates a group with 3 buckets with the same weight. It creates 12 TCP sessions and expects that each bucket will be used at least once. However, there is a solid

Re: [ovs-dev] [PATCH] datapath: use after free flow mask on destroy flow table

2022-03-24 Thread Ilya Maximets
On 3/24/22 05:17, Wentao Jia wrote: > > > on destroy flow table instance, referenced flow mask may be released > too. fuction ovs_flow_tbl_destroy(), release flow mask first and then > destroy flow table instance. this will trigger kernel panic on detroy > datapath > > > [ 377.647756] kernel B

Re: [ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-24 Thread Dumitru Ceara
On 3/23/22 17:24, Ilya Maximets wrote: > On 3/23/22 17:11, Adrian Moreno wrote: >> >> >> On 3/23/22 14:25, Eelco Chaudron wrote: >>> One small nit in patch 4, the rest of the changes from v4 to v5 look good. >>> >> >> Sorry about that. Dumitru said he might take a look at the latest version. >> I'

Re: [ovs-dev] [PATCH v5 12/15] rculist: use multi-variable helpers for loop macros

2022-03-24 Thread Dumitru Ceara
On 3/23/22 12:56, Adrian Moreno wrote: > Use multi-variable iteration helpers to rewrite rculist loops macros. > > There is an important behavior change compared with the previous > implementation: When the loop ends normally (i.e: not via "break;"), > the object pointer provided by the user is NU

Re: [ovs-dev] [PATCH v5 10/15] hindex: use multi-variable iterators

2022-03-24 Thread Dumitru Ceara
On 3/23/22 12:56, Adrian Moreno wrote: > Re-write hindex's loops using multi-variable helpers. > > For safe loops, use the LONG version to maintain backwards > compatibility. > > Acked-by: Eelco Chaudron > Signed-off-by: Adrian Moreno > --- Acked-by: Dumitru Ceara ___

Re: [ovs-dev] [PATCH v5 09/15] cmap: use multi-variable iterators

2022-03-24 Thread Dumitru Ceara
On 3/23/22 12:56, Adrian Moreno wrote: > Re-write cmap's loops using multi-variable helpers. > > For iterators based on cmap_cursor, we just need to make sure the NODE > variable is not used after the loop, so we set it to NULL. > > Acked-by: Eelco Chaudron > Signed-off-by: Adrian Moreno > ---

Re: [ovs-dev] [PATCH v5 06/15] hmap: use multi-variable helpers for hmap loops

2022-03-24 Thread Dumitru Ceara
On 3/23/22 12:56, Adrian Moreno wrote: > Rewrite hmap's loops using multi-variable helpers. > > For SAFE loops, use the LONG version of the multi-variable macros to > keep backwards compatibility. > > Acked-by: Eelco Chaudron > Signed-off-by: Adrian Moreno > --- Acked-by: Dumitru Ceara _

Re: [ovs-dev] [PATCH v5 04/15] list: use multi-variable helpers for list loops

2022-03-24 Thread Dumitru Ceara
On 3/23/22 12:56, Adrian Moreno wrote: > Use multi-variable iteration helpers to rewrite non-safe loops. > > There is an important behavior change compared with the previous > implementation: When the loop ends normally (i.e: not via "break;"), the > object pointer provided by the user is NULL. Th

Re: [ovs-dev] [PATCH v5 02/15] util: add safe multi-variable iterators

2022-03-24 Thread Dumitru Ceara
On 3/23/22 12:56, Adrian Moreno wrote: > Safe version of multi-variable iterator helpers declare an internal > variable to store the next value of the iterator temporarily. > > Two versions of the macro are provided, one that still uses the NEXT > variable for backwards compatibility and a shorter

Re: [ovs-dev] [PATCH v5 01/15] util: add multi-variable loop iterator macros

2022-03-24 Thread Dumitru Ceara
On 3/23/22 12:56, Adrian Moreno wrote: > Multi-variable loop iterators avoid potential undefined behavior by > using an internal iterator variable to perform the iteration and only > referencing the containing object (via OBJECT_CONTAINING) if the > iterator has been validated via the second expres

Re: [ovs-dev] [PATCH] ofproto/bond: Add knob "all_slaves_active"

2022-03-24 Thread Christophe Fontaine
On Wed, Mar 23, 2022 at 10:12 PM Mike Pattrick wrote: > > On Thu, Mar 17, 2022 at 11:54 AM Christophe Fontaine > wrote: > > > > This config param allows the delivery of broadcast and multicast packets > > to the secondary interface of non-lacp bonds, identical to the same option > > for kernel bo