Hi Numan
Sure, I have sent out a v3 with the updated commit message.
Thanks
Mary
From: Numan Siddique
Date: Wednesday, May 18, 2022 at 7:37 AM
To: Mark Michelson
Cc: Mary Manohar , Xavier Simonart
, ovs-dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH ovn v2] Do not set 'up' attribute in
On Tue, May 17, 2022 at 9:55 AM Mark Michelson wrote:
> OK thanks for the explanations, Xavier and Mary. This is pretty
> important since we expect that ovn-controller should be upgraded before
> ovn-northd.
>
> I'm acking the patch because the content is correct. I suggest that when
> this is
OK thanks for the explanations, Xavier and Mary. This is pretty
important since we expect that ovn-controller should be upgraded before
ovn-northd.
I'm acking the patch because the content is correct. I suggest that when
this is merged, the person that merges should expand on the commit
Thanks Xavier for clarifying.
Hi Mark,
Xavier’s explanation is bang on. The ‘up’ field is introduced in the Port
Binding table post 20.09.
So, when the southbound is at 20.09 version, the set operation fails in
ovn-controller.
Thanks
Mary
From: Xavier Simonart
Date: Wednesday, May 11, 2022
Hi Mark
This is fixing a backward compatibility issue when using an older
ovn-northd.
ovn-controller should only set Port_Binding.up field if the Southbound DB
is aware of this field (or transaction would fail).
We already do this when setting pb up through notification (if-status
module).
More
Hi Mary,
I'm confused by this change. The summary mentions ovn-northd being at an
older version, but there's no version check being performed in the
patch. Also, what constitutes an "older" version of ovn-northd? Why
shouldn't we set the port up in this case? What problem is being solved?
From: Mary Manohar
Signed-off-by: Mary Manohar
---
controller/binding.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/controller/binding.c b/controller/binding.c
index e284704..e7dc537 100644
--- a/controller/binding.c
+++ b/controller/binding.c
@@ -908,7 +908,9 @@
