[ovs-dev] [PATCH] Remove build-time generated files when "make clean" is run.

ot; was run. This commit only leaves configuration files after "make clean" is run, and removes all other generated files. Signed-off-by: Justin Pettit --- debian/automake.mk | 2 +- ovn/automake.mk | 10 +- ovn/controller-vtep/automake.mk | 2

Re: [ovs-dev] [PATCH] Remove build-time generated files when "make clean" is run.

> On Feb 13, 2017, at 7:49 PM, Ben Pfaff wrote: > > On Mon, Feb 13, 2017 at 05:31:49PM -0800, Justin Pettit wrote: >> "make clean" should remove all files generated by building a program, while >> "make distclean" should also remove files generated b

[ovs-dev] [PATCH] ovsdb: Print enum elements for man pages in alphabetical order.

The previous behavior printed them in a pseudorandom order, which made them look odd in man pages. Signed-off-by: Justin Pettit --- python/ovs/db/types.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/ovs/db/types.py b/python/ovs/db/types.py index 78d5fcd..50eb505 100644 --- a

Re: [ovs-dev] [PATCH] ovsdb: Print enum elements for man pages in alphabetical order.

> On Feb 14, 2017, at 8:50 PM, Ben Pfaff wrote: > > On Tue, Feb 14, 2017 at 04:55:11PM -0800, Justin Pettit wrote: >> The previous behavior printed them in a pseudorandom order, which made >> them look odd in man pages. >> >> Signed-off-by: Justin Pettit >

[ovs-dev] [branch-2.7] Set release date for 2.7.0.

Signed-off-by: Justin Pettit --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 89bb026..4ec96de 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -v2.7.0 - xx xxx +v2.7.0 - 21 Feb 2017

[ovs-dev] [branch-2.5 1/2] Set release date for 2.5.2.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 9 +++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 27c15af..7c697db 100644 --- a/NEWS +++ b/NEWS @@ -1,10 +1,11 @@ -v2.5.2 - xx xxx +v2.5.2 - 21 Feb 2017

[ovs-dev] [branch-2.5 2/2] Prepare for 2.5.3.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 7c697db..6c1d998 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.5.3 - xx xxx

Re: [ovs-dev] [branch-2.5 2/2] Prepare for 2.5.3.

> On Feb 23, 2017, at 10:37 AM, Ben Pfaff wrote: > > On Tue, Feb 21, 2017 at 02:42:36PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this to branch-2.5. I'll start prepp

Re: [ovs-dev] [branch-2.7] Set release date for 2.7.0.

> On Feb 23, 2017, at 10:36 AM, Ben Pfaff wrote: > > On Tue, Feb 21, 2017 at 01:59:23PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this to branch-2.7. I'll start prepp

Re: [ovs-dev] [branch-2.7] Set release date for 2.7.0.

> On Feb 24, 2017, at 4:32 AM, Flavio Leitner wrote: > > > Hi, > > We pushed 2.7 through our testing and found no issues. Thank you for doing that! I hope to release today. Jarno is just checking the supported kernel versions, and then we'll send it out. --Justin ___

Re: [ovs-dev] [PATCH] FAQ: Update kernel support info.

> On Feb 27, 2017, at 5:45 PM, Jarno Rajahalme wrote: > > OVS 2.7 works with Linux kernels 3.10-4.9. > > Signed-off-by: Jarno Rajahalme Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.

Re: [ovs-dev] [PATCH] ovs-fields.7: Use a more general approach to groff encodings.

> On Jan 26, 2017, at 10:26 AM, Ben Pfaff wrote: > > It turns out that, since groff 1.20 around 2009, groff comes with a > preprocessor named "preconv" that can fix encoding issues. Use it instead > of the existing hack. Geez, you didn't know that? Where've you been? > --- a/lib/automake.m

[ovs-dev] [PATCH 1/3] ofproto-dpif: Update handle_action() comment.

The comment didn't mention the SLOW_LLDP and SLOW_ACTION reasons. Signed-off-by: Justin Pettit --- ofproto/ofproto-dpif-upcall.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 07086ee

[ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Update comment for recirc_alloc_id__().

The hash is not recomputed if it is passed in as 0. Signed-off-by: Justin Pettit --- ofproto/ofproto-dpif-rid.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c index d27669ef1f68..9381dee61404 100644 --- a/ofproto

[ovs-dev] [PATCH 3/3] ofproto-dpif-xlate.c: Include controller traffic for NetFlow.

: Justin Pettit --- ofproto/ofproto-dpif-xlate.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 7df92e58dcf5..6b7a4fe51072 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-xlate.c

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate.c: Include controller traffic for NetFlow.

> On Mar 23, 2017, at 10:03 AM, Jarno Rajahalme wrote: > > >> On Mar 22, 2017, at 11:26 PM, Justin Pettit wrote: >> >> The code previously did not include packets forwarded to the controller >> in NetFlow, as it considered this control traffic. That is debat

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

> On Mar 5, 2018, at 10:59 PM, Pravin Shelar wrote: > > right, I have already done with the testing, I forgot to push it. > Thanks for reminding me. Thanks for pushing it! --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.

Re: [ovs-dev] [PATCH] vswitchd: Remove support for deprecated "null" interfaces.

/* We will add new interfaces later. */ > } I think there's another reference in the function port_del_ifaces(). Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovsdb-idl: Use modern form of .

commit makes that change. > > Reported-by: Anil Jangam > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/6] ofp-protocol: Better abstract changing the protocol used for flow matches.

sert(&b) == OFPRAW_NXT_FLOW_MOD_TABLE_ID); > +uint8_t *enable = ofpbuf_pull(&b, 8); > +return *enable != 0; Should that function description be referencing "NXT_FLOW_MOD_TABLE_ID" instead? Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/6] ofp-packet: Better abstract packet-in format.

(format)); > } > +return error; > } Do you think it's worth printing some sort of error message if it's not a known protocol? The previous version just printed the raw number. Signed-off-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/6] ofp-flow: Move parse_ofp_flow_mod_str() into correct file.

> On Feb 16, 2018, at 2:54 PM, Ben Pfaff wrote: > > This function was left behind by accident in the patch that split up > ofp-parse. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@ope

Re: [ovs-dev] [PATCH 5/6] ofp-match: Make some public functions static.

> On Feb 16, 2018, at 2:54 PM, Ben Pfaff wrote: > > These were only used inside ofp-match itself. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswi

Re: [ovs-dev] [PATCH 3/6] ofp-packet: Better abstract packet-in format.

> On Mar 12, 2018, at 6:22 PM, Justin Pettit wrote: > > >> On Feb 16, 2018, at 2:54 PM, Ben Pfaff wrote: >> >> diff --git a/lib/ofp-print.c b/lib/ofp-print.c >> index b13bc380386a..c0bfa92843c6 100644 >> --- a/lib/ofp-print.c >>

Re: [ovs-dev] [PATCH 6/6] ofp-print: Move much of the printing code into message-specific files.

> On Feb 16, 2018, at 2:54 PM, Ben Pfaff wrote: It looks like this was mostly moving code around, so I didn't pore over the review, but let me know if you want me to take a closer look. I did notice a few smaller things: > diff --git a/lib/ofp-table.c b/lib/ofp-table.c > index 558e4bcd9127..

Re: [ovs-dev] [PATCH 6/6] ofp-print: Move much of the printing code into message-specific files.

> On Mar 13, 2018, at 4:04 PM, Justin Pettit wrote: > > >> On Feb 16, 2018, at 2:54 PM, Ben Pfaff wrote: > > It looks like this was mostly moving code around, so I didn't pore over the > review, but let me know if you want me to take a closer look. I did n

[ovs-dev] [PATCH] Clean up some minor spelling and typos.

Signed-off-by: Justin Pettit --- Documentation/howto/docker.rst | 6 +++--- Documentation/howto/dpdk.rst | 12 ++-- Documentation/howto/firewalld.rst| 2 +- Documentation/howto/lisp.rst

Re: [ovs-dev] [PATCH] Clean up some minor spelling and typos.

> On Mar 14, 2018, at 3:39 PM, Ben Pfaff wrote: > > On Wed, Mar 14, 2018 at 02:39:34PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this to master. --Justin _

Re: [ovs-dev] [patch v5 01/11] dp-packet: Add const qualifiers for checksum apis.

The functions dp_packet_l4_checksum_valid() and dp_packet_l4_checksum_bad() seem similar. Should we also add "const" to them? Acked-by: Justin Pettit --Justin > On Feb 4, 2018, at 8:22 AM, Darrell Ball wrote: > > Signed-off-by: Darrell Ball > --- > lib/dp-p

Re: [ovs-dev] [patch v5 02/11] flow: Enhance parse_ipv6_ext_hdrs.

> On Feb 4, 2018, at 8:22 AM, Darrell Ball wrote: > > Enhance the api parse_ipv6_ext_hdrs to return the > fragmentation header to be used in later patches. > > Signed-off-by: Darrell Ball Acked-by: Justin Pettit --Justin ___

[ovs-dev] [PATCH] stopwatch: Explicitly ignore write() return value.

pkt); This patch explicitly ignores the return value of write(). This also fixes some minor coding style issues. Signed-off-by: Justin Pettit --- lib/stopwatch.c | 25 + lib/stopwatch.h | 8 +--- 2 files changed, 18 insertions(+), 15 deletions(-) diff --git a

Re: [ovs-dev] [PATCH] stopwatch: Explicitly ignore write() return value.

> On Apr 6, 2018, at 12:27 PM, Mark Michelson wrote: > > I just had a look, and unfortunately, the current code doesn't translate > directly to a latch. The reason is that you can't control the data that is > sent to and read from the latch. It's essentially a boolean of "set" or "not > set".

Re: [ovs-dev] [PATCH] ovsdb.7: Clarify description of OVSDB.

> On Apr 26, 2018, at 12:39 PM, Ben Pfaff wrote: > > A reader reported that "network database system" made it sound like OVSDB > was specialized for databases about networks. It's not, it's just > accessible over the network. > > Signed-off-by: Ben P

Re: [ovs-dev] [PATCH] ovs-vswitchd: Better document that ovs-vswitchd manages its own datapaths.

> On May 3, 2018, at 11:27 PM, Ben Pfaff wrote: > > More explicitly discourage users from managing them themselves. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvs

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Fix incorrect mask in probe_multi_mask_per_prio().

d00eeded6a9b ("netdev-tc-offloads: Probe for allowing multiple masks > on single priority") > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [patch v1] conntrack-tcp: Handle tcp session reuse.

Thank you for the patch. Sorry it took so long to review. What do you think of the incremental at the end of this message? It doesn't change the functionality, but it shortens the code a tad, and I think improves the readability a bit. Also, thanks for indicating that this should be backport

Re: [ovs-dev] [PATCH] sparse: Support newer GCC/glibc versions.

> On May 14, 2018, at 10:06 AM, Ben Pfaff wrote: > > This fixes some "sparse" errors I encountered after upgrading. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit ___ dev mailing list d...@openvswitch.org htt

Re: [ovs-dev] [patch v2] conntrack-tcp: Handle tcp session reuse.

> On May 14, 2018, at 6:38 PM, Darrell Ball wrote: > > Fix tcp sequence tracking for cases when picking up an existing connection. > This can happen, for example, by doing VM migration and sequence tracking > should be more permissive in these cases. We don't differentiate picking > up an exist

[ovs-dev] [PATCH] ovs-ofctl: Clean up Group description in man page.

This fixes a few minor issues in the Group description of the ovs-ofctl man page. It also puts the description of the dump commands in the same section as the other Group-related commands. Signed-off-by: Justin Pettit --- utilities/ovs-ofctl.8.in | 132

Re: [ovs-dev] [PATCH 1/7] ofproto-dpif-xlate: Fix reference leak in xlate_dp_hash_select_group().

This commit fixes the problem. > > Found by inspection. > > Signed-off-by: Ben Pfaff xlate_group_action__() also calls xlate_all_group(). Should xlate_all_group() include a call to ofproto_group_unref()? Acked-by: Justin Pettit --Justin

Re: [ovs-dev] [PATCH] ovs-ofctl: Clean up Group description in man page.

> On May 16, 2018, at 4:14 PM, Ben Pfaff wrote: > > On Wed, May 16, 2018 at 04:04:14PM -0700, Justin Pettit wrote: >> This fixes a few minor issues in the Group description of the ovs-ofctl >> man page. It also puts the description of the dump commands in the same >>

Re: [ovs-dev] [PATCH 2/7] ofproto-dpif-xlate: Simplify translation for groups.

Pfaff Looks better. Thanks. Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/7] ofp-group: Require watch_port or watch_group when parsing ff groups.

rder > to understand. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/7] Add OpenFlow extensions for group support in OpenFlow 1.0.

n: > lib/netdev-dpdk-unixctl.man: > lib/service.man: > lib/ssl-bootstrap.man: > +lib/ssl-peer-ca-cert.man: > lib/ssl.man: > lib/unixctl.man: > lib/vlog-unixctl.man: Did you mean to include this? Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 5/7] ofp-group: Move formatting code for groups into ofp-group.

> On May 10, 2018, at 4:24 PM, Ben Pfaff wrote: > > This does a better job of putting related code together. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.

Re: [ovs-dev] [PATCH 6/7] ofp-print: Handle statistics more systematically.

missing (and fixes up a test case). > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 7/7] ofproto-dpif-xlate: Improve tracing through groups.

> On May 10, 2018, at 4:24 PM, Ben Pfaff wrote: > > This makes it clear which buckets from a group are executed and why. > > The update to nsh.at provides an example. > > Signed-off-by: Ben Pfaff Nice addition. Acked-by: Jus

[ovs-dev] [PATCH] ovsdb: Use new ovsdb_log_write_and_free().

Signed-off-by: Justin Pettit --- ovsdb/ovsdb-tool.c | 14 +++--- tests/test-ovsdb.c | 3 +-- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/ovsdb/ovsdb-tool.c b/ovsdb/ovsdb-tool.c index 61ee6b377b6f..c2ad2310c234 100644 --- a/ovsdb/ovsdb-tool.c +++ b/ovsdb/ovsdb-tool.c

Re: [ovs-dev] [PATCH] ovsdb: Use new ovsdb_log_write_and_free().

> On May 17, 2018, at 11:20 AM, Ben Pfaff wrote: > > On Thu, May 17, 2018 at 11:07:32AM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Thanks for the cleanup. > > Acked-by: Ben Pfaff Thanks. I pushe

[ovs-dev] [branch-2.9 2/2] Prepare for 2.9.2.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 62fba8090cda..06f4a6475f81 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.9.2 - xx xxx

[ovs-dev] [branch-2.9 1/2] Set release date for 2.9.1.

Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 0a36e1fa3967..62fba8090cda 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -v2.9.1 - xx xxx +v2.9.1 - 18 May 2018

[ovs-dev] [branch-2.8 1/2] Set release date for 2.8.3.

Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 7c219f4034d4..bab4f9daab13 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.8.3 - xx xxx +v2.8.3 - 18 May 2018

[ovs-dev] [branch-2.8 2/2] Prepare for 2.8.4.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index bab4f9daab13..31fb40ac4cbc 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.8.4 - xx xxx

[ovs-dev] [branch-2.7 1/2] Set release date for 2.7.5.

Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index ca95308bb0db..a975168066f0 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.7.5 - xx xxx +v2.7.5 - 18 May 2018

[ovs-dev] [branch-2.7 2/2] Prepare for 2.7.6.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index a975168066f0..1e392f8cb443 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.7.6 - xx xxx

[ovs-dev] [branch-2.6 1/2] Set release date for 2.6.2.

Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 99702975a598..27c00b77d7c2 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.6.2 - xx xxx +v2.6.2 - 18 May 2018

[ovs-dev] [branch-2.6 2/2] Prepare for 2.6.3.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 ++- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 27c00b77d7c2..baf9895f6213 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.6.3 - xx xxx

[ovs-dev] [branch-2.5 1/2] Set release date for 2.5.5.

Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 4a45a2b41a74..c3bd934f2fd5 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.5.5 - xx xxx +v2.5.5 - 18 May 2018

[ovs-dev] [branch-2.5 2/2] Prepare for 2.5.6.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index c3bd934f2fd5..9ae1758b6a48 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.5.6 - xx xxx

Re: [ovs-dev] [branch-2.9 1/2] Set release date for 2.9.1.

> On May 18, 2018, at 2:34 PM, Ben Pfaff wrote: > > On Fri, May 18, 2018 at 02:03:58PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > This series seems fine, as do your other series for releasing new minor > versions. Thanks for doing all of this.

Re: [ovs-dev] [branch-2.9 1/2] Set release date for 2.9.1.

> On May 20, 2018, at 5:52 PM, Ben Pfaff wrote: > > On Fri, May 18, 2018 at 03:57:37PM -0700, Justin Pettit wrote: >> >>> On May 18, 2018, at 2:34 PM, Ben Pfaff wrote: >>> >>> On Fri, May 18, 2018 at 02:03:58PM -0700, Justin Pettit wrote: >&g

Re: [ovs-dev] New Release for branch 2.9, 2.8, 2.7, 2.6

Sure. No problem. --Justin > On May 23, 2018, at 1:59 AM, Stokes, Ian wrote: > > Hi Justin, > > A bug has been discovered that is present from branches 2.9 -> 2.6 that can > break DPDK compilation for users. > > https://mail.openvswitch.org/pipermail/ovs-dev/2018-May/347435.html > > There

Re: [ovs-dev] [PATCH] ovn: Update TODO.

> On May 24, 2018, at 11:00 AM, Ben Pfaff wrote: > > We've actually made a lot of improvements. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.ope

Re: [ovs-dev] [PATCH] Embrace anonymous unions.

es. This > commit embraces it in several others. > > Signed-off-by: Ben Pfaff I didn't read through it carefully, but I support the change, and it's the sort of thing that normally breaks in obvious ways. Acked-by: Justin Pettit --Justin _

Re: [ovs-dev] [PATCH] vconn: Remove obsolete comment.

> On May 23, 2018, at 4:39 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] tests: Avoid printing Python exception for hosts without IPv6 support.

expected and harmless, but it reasonably surprised some > users. This commit fixes the problem. > > Reported-by: Paul Greenberg > Reported-at: > https://github.com/openvswitch/ovs-issues/issues/146#issuecomment-390081887 > Signed-off-by: Ben Pfaff Acked-by: Justin Pett

Re: [ovs-dev] [PATCH 1/7] ovsdb: Improve torture test for clusters.

yslog:off --bare get SB_Global . external-ids | sed 's/, /\n/g; > s/[[{}""]]//g;' | sort], [0], [expout]) I believe the original code, as well as this new version, mixes spaces and tabs. Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/7] ovsdb: Improve timing in cluster torture test.

; it got. s/too/took Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/7] ovs-sim: Convert documentation to RST format.

controllers); do > + rungdb $gdb_ovn_controller $gdb_ovn_controller_ex ovn-controller \ > + $OVN_CTRLR_PKI --detach --no-chdir --pidfile -vconsole:off > --log-file > +done Do you want to distinguish the separate ovn-controller instance pidfiles a

Re: [ovs-dev] [PATCH 4/7] ovs-sim: Install RST manpages into simulation environment too.

> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 5/7] ovs-sim, ovs-sandbox: Turn off logging to syslog.

> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote: > > There's no value in having these testing tools log to syslog. It just > pollutes the system log. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___

Re: [ovs-dev] [PATCH 6/7] ovs-vsctl, ovn-nbctl, ovn-sbctl, vtep-ctl: Parse options before logging.

nd. > This fixes the problem. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 7/7] ovs-sim: Support backup and clustered databases for ovn.

> On May 18, 2018, at 2:37 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] ovs-fields: Correct ideas about which OXM classes are official.

; OpenFlow version. This commit corrects it. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] ovs-fields: Improve formatting of NSH section.

> On May 18, 2018, at 10:16 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] New Release for branch 2.9, 2.8, 2.7, 2.6

Sounds good. I'll take it from here. Thanks. --Justin > On May 25, 2018, at 12:05 PM, Stokes, Ian wrote: > >> Sure. No problem. > > Thanks Justin, > > The bug fixes have now been merged to the release branches and are ready to > go. Thanks again for helping with this, is there anything el

[ovs-dev] [branch-2.6 1/2] Set release date for 2.6.3.

Signed-off-by: Justin Pettit --- NEWS | 5 +++-- debian/changelog | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index efbae2aced3b..7fec7dc3db51 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.6.3 - xx xxx -- +v2.6.3 - 25

[ovs-dev] [branch-2.6 2/2] Prepare for 2.6.4.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 7fec7dc3db51..dcef1e73a199 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.6.4 - xx xxx

[ovs-dev] [branch-2.7 1/2] Set release date for 2.7.6.

Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index f4046baa5a76..2a469b7df446 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,5 @@ -v2.7.6 - xx xxx -- +v2.7.6 - 25

[ovs-dev] [branch-2.7 2/2] Prepare for 2.7.7.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 2a469b7df446..aa1e476f3557 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.7.7 - xx xxx

[ovs-dev] [branch-2.8 2/2] Prepare for 2.8.5.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 047f8751bfab..101ded1ddca0 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.8.5 - xx xxx

[ovs-dev] [branch-2.8 1/2] Set release date for 2.8.4.

Signed-off-by: Justin Pettit --- NEWS | 6 +++--- debian/changelog | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index c8b5659e363c..047f8751bfab 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.8.4 - xx xxx

[ovs-dev] [branch-2.9 1/2] Set release date for 2.9.2.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- debian/changelog | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index 06f4a6475f81..452d0dd0bb02 100644 --- a/NEWS +++ b/NEWS @@ -1,5 +1,6 @@ -v2.9.2 - xx xxx +v2.9.2 - 25 May 2018

[ovs-dev] [branch-2.9 2/2] Prepare for 2.9.3.

Signed-off-by: Justin Pettit --- NEWS | 3 +++ configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 452d0dd0bb02..622c230ae5b0 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,6 @@ +v2.9.3 - xx xxx

Re: [ovs-dev] [branch-2.9 1/2] Set release date for 2.9.2.

> On May 25, 2018, at 5:27 PM, Ben Pfaff wrote: > > All of these releases seem fine to me. > > Acked-by: Ben Pfaff Thanks. I pushed these to all the appropriate branches. --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitc

Re: [ovs-dev] [PATCH] unixctl: Style fix.

> On Aug 8, 2018, at 1:31 PM, Ben Pfaff wrote: > > Reported-by: Aaron Conole > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

error. This commit follows the existing implementations and makes the API somewhat cleaner. Signed-off-by: Justin Pettit --- lib/dpif-netdev.c | 4 ++-- lib/dpif-netlink.c | 13 - lib/dpif-provider.h| 9 - lib/dpif.c | 14 ++ lib/dpif.h

[ovs-dev] [PATCH 2/2] dpif-netlink: Probe for broken Linux meter implementations.

. Signed-off-by: Justin Pettit --- lib/dpif-netlink.c | 54 ++ 1 file changed, 54 insertions(+) diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c index bf94e5413e71..60ce1a6d22a3 100644 --- a/lib/dpif-netlink.c +++ b/lib/dpif-netlink.c @@ -2926,6

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

--Justin > On Aug 8, 2018, at 8:12 AM, Ben Pfaff wrote: > > Justin, I already applied this as a straightforward backport. Hope it > doesn't disrupt your work. > > On Tue, Aug 07, 2018 at 08:31:35PM -0700, Justin Pettit wrote: >> Thanks, Greg. I actually have this

Re: [ovs-dev] [PATCH] datapath: meter: Fix setting meter id for new entries

> On Aug 7, 2018, at 10:19 PM, Gregory Rose wrote: > > > On 8/7/2018 8:31 PM, Justin Pettit wrote: >> Thanks, Greg. I actually have this queued up with another patch that will >> disable meters entirely on broken kernels. I plan to send that out tomorrow. >> &

Re: [ovs-dev] [patch v8 9/9] ipf: Add fragmentation status reporting.

> On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote: > > void > ct_dpif_entry_uninit(struct ct_dpif_entry *entry) > { > diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h > index f886ab9..2ff7e26 100644 > --- a/lib/ct-dpif.h > +++ b/lib/ct-dpif.h > @@ -204,6 +204,15 @@ int ct_dpif_get_nconns(struct dpif

Re: [ovs-dev] [PATCH v3 06/11] dpif: Support conntrack zone limit.

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h > index 09e7698cf2bc..4e83bc555e03 100644 > --- a/lib/ct-dpif.h > +++ b/lib/ct-dpif.h > @@ -191,6 +191,13 @@ struct ct_dpif_dump_state { > struct dpif *dpif; > }; > > +struct ct_dpif_zone_limi

Re: [ovs-dev] [PATCH v3 07/11] ct-dpif: Helper functions for conntrack zone limit

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > +/* The caller takes ownership of 'struct ct_dpif_zone_limit *', and is > + * responsible to free that struct. */ > +struct ct_dpif_zone_limit * > +ct_dpif_pop_zone_limit(struct ovs_list *zone_limits) > +{ > +struct ct_dpif_zone_limit *

Re: [ovs-dev] [PATCH 1/2] dpif: Don't pass in '*meter_id' to meter_set commands.

> On Aug 14, 2018, at 1:55 PM, Ben Pfaff wrote: > > On Wed, Aug 08, 2018 at 05:35:21PM -0700, Justin Pettit wrote: >> The original intent of the API appears to be that the underlying DPIF >> implementaion would choose a local meter id. However, neither of the >&

Re: [ovs-dev] [PATCH v3 08/11] dpif-netlink: Implement conntrack zone limit

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: I only had a few very minor suggestions. > +static int > +dpif_netlink_get_limits(struct dpif *dpif OVS_UNUSED, uint32_t > *default_limit, > +const struct ovs_list *zone_limits_request, > +struc

Re: [ovs-dev] [PATCH v3 09/11] dpctl: Refactor opt_dpif_open().

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > Make opt_dpif_open() to support mulitple optional arguments. It will > be useful for the following patches. > > Signed-off-by: Yi-Hung Wei > --- > lib/dpctl.c | 58 ++ > 1 file chang

Re: [ovs-dev] 2.10 release date?

The plan is to package everything tomorrow (Friday) and release on Monday. Does that work or do you need it tomorrow? --Justin > On Aug 16, 2018, at 4:49 PM, Flavio Leitner wrote: > > > Hi, > > According with our internal release process[1] the 2.10 should have > been released on Aug, 15 (

Re: [ovs-dev] [PATCH v3 10/11] dpctl: Implement dpctl commands for conntrack per zone limit

> On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > > diff --git a/lib/ct-dpif.c b/lib/ct-dpif.c > index a772799fe347..bb809d9920b5 100644 > --- a/lib/ct-dpif.c > +++ b/lib/ct-dpif.c > @@ -629,3 +629,70 @@ ct_dpif_free_zone_limits(struct ovs_list *zone_limits) > ... > +/* Parses a specific

Re: [ovs-dev] [PATCH v3 11/11] system-traffic: Add conntrack per zone limit test case

These look great. Thanks for writing some tests. --Justin > On Aug 14, 2018, at 11:56 AM, Yi-Hung Wei wrote: > > Signed-off-by: Yi-Hung Wei > --- > tests/system-traffic.at | 75 + > 1 file changed, 75 insertions(+) > > diff --git a/tests/system

Re: [ovs-dev] [ovs-dev, v4, 07 of 11] ct-dpif: Helper functions for conntrack zone limit

Thank you, 0-day Robot. I fixed this directly in my branch. --Justin > On Aug 17, 2018, at 3:08 AM, 0-day Robot wrote: > > Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your > patch. > Thanks for your contribution. > > I encountered some error that I wasn't expectin

<    1   2   3   4   5   6   7   8   9   >