o Chaudron
Signed-off-by: Mike Pattrick
---
Since v1:
- Retain support for pre-TCA_STATS_PKT64 kernels
Since v2:
- Added compat header
Since v3:
- Rebased on to current master
Since v4:
- Fixed alignment issue
- Moved declarations and definitions
Since v5:
-Aesthetic changes
Since v6:
-Aesthet
o Chaudron
Signed-off-by: Mike Pattrick
---
Since v1:
- Retain support for pre-TCA_STATS_PKT64 kernels
Since v2:
- Added compat header
Since v3:
- Rebased on to current master
Since v4:
- Fixed alignment issue
- Moved declarations and definitions
Since v5:
-Aesthetic changes
Since v6:
-Aesthet
32bit one has rolled over. Because
the TCA_STATS_PKT64 attribute may appear multiple times in a netlink
message, the method of parsing attributes was changed.
Fixes: f98e418fbdb6 ("tc: Add tc flower functions")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1776816
Signed-of
32bit one has rolled over. Because
the TCA_STATS_PKT64 attribute may appear multiple times in a netlink
message, the method of parsing attributes was changed.
Fixes: f98e418fbdb6 ("tc: Add tc flower functions")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1776816
Signed-of
packet_use lib/dp-packet.c:60
#3 in dp_packet_init lib/dp-packet.c:126
#4 in dp_packet_new lib/dp-packet.c:150
[...]
Signed-off-by: Mike Pattrick
---
lib/dp-packet.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/dp-packet.c b/lib/dp-packet.c
index 61e405460..ae8ab5800 10
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
lib/h
eam_create lib/netdev-dummy.c:208
#2 dummy_packet_conn_set_config lib/netdev-dummy.c:436
[...]
Signed-off-by: Mike Pattrick
---
lib/netdev-dummy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index 72cb95471..0b1eb7108 100644
On Wed, Jan 11, 2023 at 6:24 AM Ilya Maximets wrote:
>
> On 1/11/23 06:33, Mike Pattrick wrote:
> > UB Sanitizer report:
> >
> > lib/hash.h:219:17: runtime error: load of misaligned address
> > 0x7ffc164a88b4 for type 'const uint64_t', which require
packet_use lib/dp-packet.c:60
#3 in dp_packet_init lib/dp-packet.c:126
#4 in dp_packet_new lib/dp-packet.c:150
[...]
Signed-off-by: Mike Pattrick
---
lib/dp-packet.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/dp-packet.c b/lib/dp-packet.c
index 61e405460..ae8ab5800 10
eam_create lib/netdev-dummy.c:208
#2 dummy_packet_conn_set_config lib/netdev-dummy.c:436
[...]
Signed-off-by: Mike Pattrick
---
lib/netdev-dummy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index 72cb95471..0b1eb7108 100644
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
--
On Wed, Jan 11, 2023 at 1:46 PM Michael Santana wrote:
>
> This is an RFC about making the ovs-vsctl more strict with argument
> checking for the set command in other_config option. This RFC is
> intentionally limited in scope as it is written to be a proof on concept
> and doesn't cover all the o
On Tue, Oct 18, 2022 at 8:02 AM Adrian Moreno wrote:
>
> IPFIX templates have to be sent for each Observation Domain ID.
> Currently, a timer is kept at each dpif_ipfix_exporter to send them.
> This works fine for per-bridge sampling where there is only one
> Observation Domain ID per exporter. Ho
On Tue, Oct 18, 2022 at 8:03 AM Adrian Moreno wrote:
>
> Add options to the IPFIX table configure the interval to send statistics
> and template information.
>
> Signed-off-by: Adrian Moreno
Looks good!
Acked-by: Mike Pattrick
> ---
> NEWS | 2
On Mon, Jan 16, 2023 at 10:17 AM Adrián Moreno wrote:
>
> From: Adrian Moreno
>
> IPFIX templates have to be sent for each Observation Domain ID.
> Currently, a timer is kept at each dpif_ipfix_exporter to send them.
> This works fine for per-bridge sampling where there is only one
> Observation
On Tue, Jan 24, 2023 at 2:21 PM Adrián Moreno wrote:
>
> From: Adrian Moreno
>
> IPFIX templates have to be sent for each Observation Domain ID.
> Currently, a timer is kept at each dpif_ipfix_exporter to send them.
> This works fine for per-bridge sampling where there is only one
> Observation D
0 ( 0.0 % of total cycles)
> - idle iterations: 0 ( 0.0 % of used cycles)
> - busy iterations: 0 ( 0.0 % of used cycles)
>
> Signed-off-by: Kevin Traynor
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
0
>1025 0
>1469 0
>
> ---
>cycles/it
>0
>
> Signed-off-by: Kevin Traynor
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
eam_create lib/netdev-dummy.c:208
#2 dummy_packet_conn_set_config lib/netdev-dummy.c:436
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/netdev-dummy.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/
packet_use lib/dp-packet.c:60
#3 in dp_packet_init lib/dp-packet.c:126
#4 in dp_packet_new lib/dp-packet.c:150
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/dp-packet.c | 4
lib/dp-packet.h | 4
2 files changed, 8
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
v
On Mon, Jan 30, 2023 at 2:03 PM Ilya Maximets wrote:
>
> On 1/30/23 17:03, Mike Pattrick wrote:
> > UB Sanitizer report:
> >
> > lib/netdev-dummy.c:197:15: runtime error: member access within
> > misaligned address 0x0217a7f0 for type 'struct
> > dum
eam_create lib/netdev-dummy.c:208
#2 dummy_packet_conn_set_config lib/netdev-dummy.c:436
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/netdev-dummy.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/
packet_use lib/dp-packet.c:60
#3 in dp_packet_init lib/dp-packet.c:126
#4 in dp_packet_new lib/dp-packet.c:150
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/dp-packet.c | 4
lib/dp-packet.h | 4
2 files changed, 8
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
v
eam_create lib/netdev-dummy.c:208
#2 dummy_packet_conn_set_config lib/netdev-dummy.c:436
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
v4:
- fixed incorrectly spelled function name
---
lib/netdev-dummy.c | 10 +-
1 file changed, 5
packet_use lib/dp-packet.c:60
#3 in dp_packet_init lib/dp-packet.c:126
#4 in dp_packet_new lib/dp-packet.c:150
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/dp-packet.c | 4
lib/dp-packet.h | 4
2 files changed, 8 insertion
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
v
On Tue, Jan 31, 2023 at 10:45 AM Phelan, Michael
wrote:
>
> > -Original Message-
> > From: Ilya Maximets
> > Sent: Tuesday 31 January 2023 12:23
> > To: Phelan, Michael ; Mike Pattrick
> > ; Adrián Moreno
> > Cc: i.maxim...@ovn.org; d...@openvswitc
7;t see an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will recieve every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
ofproto/of
On Tue, Feb 21, 2023 at 5:35 AM Simon Horman wrote:
>
> On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote:
> > Currently OVS keeps track of which mirrors that each packet has been
> > sent to for the purpose of deduplication. However, this doesn't consider
>
There was a minor typo in the ovs-actions man page.
Signed-off-by: Mike Pattrick
---
Documentation/ref/ovs-actions.7.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/ref/ovs-actions.7.rst
b/Documentation/ref/ovs-actions.7.rst
index b59b7634f..d13895655
On Fri, Mar 3, 2023 at 12:31 PM Adrian Moreno wrote:
>
> Hi Mike,
>
> I've gone though this patch and have some minor style comments and nits. I've
> also played a bit with it and run it through valgrind and looks solid.
>
> On 12/8/22 17:22, Mike Pattrick wrote:
&g
are now making use
> of RCU to protect ofproto:
>
> https://patchwork.ozlabs.org/project/openvswitch/patch/1638530715-44436-1-git-send-email-wangyunj...@huawei.com/
>
> In this patch, I have merged guohongzhi's patch and mine, and fixes
> acco
On Fri, Feb 4, 2022 at 8:37 AM Adrian Moreno wrote:
>
>
>
> On 1/18/22 16:01, Peng He wrote:
> > From hepeng:
> > https://patchwork.ozlabs.org/project/openvswitch/patch/20200717015041.82746-1-hepeng.0...@bytedance.com/#2487473
> >
> > also from guohongzhi :
> > http://patchwork.ozlabs.org/project
On Thu, Jan 20, 2022 at 6:52 PM Limaye, Namrata
wrote:
>
> Hi,
>
> We are working on adding P4 support to OVS and we have recently open-sourced
> the patches on the IPDK github -
>https://github.com/ipdk-io/ovs/tree/ovs-with-p4
Hello Namrata,
I've been trying to compile this, b
n error message.
>
> This patch captures the request output and prints
> the error message to the ovs logs.
>
> Signed-off-by: Mohammad Heib
This should make it easier to debug IPSec issues.
Acked-by: Mike Pattrick
___
dev mailing l
ICMP echo request, id 1, seq 10, length 40
>
> Reported-at:openvswitch/ovs-issues#244
> Signed-off-by: Frank Guo
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
"netdev-vport: Fix userspace tunnel ioctl(SIOCGIFINDEX) info
> logs.")
> Signed-off-by: Wan Junjie
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
#x27;:
lib/ofp-packet.c:886:27: warning: 'value' may be used
uninitialized [-Wmaybe-uninitialized]
The caller doesn't happen to use the variables in these cases because
an error is set. But checking for the error resolves this warning.
Signed-off-by: Mike Pattrick
---
lib
n for this port
> and ignores the request output which can contain an error message.
>
> This patch captures the request output and prints
> the error message to the ovs logs.
>
> Signed-off-by: Mohammad Heib
Acked-by: Mike Pattrick
_
On Thu, 2022-01-20 at 16:33 +0100, Andreas Karis wrote:
> Both LibreSwan and OpenSwan allow administrators to unconditionally
> force enable NAT-T for ESP. This may help to surmount restrictive
> firewalls in scenarios where IP protocol number 50 is blocked, but
> where
> NAT autodetection fails. A
On Fri, Feb 25, 2022 at 4:43 PM Gregory Rose wrote:
>
>
>
> On 2/25/2022 12:02 PM, Mike Pattrick wrote:
> > GCC 11.2.1-2.2 emits a false-positive warnings like:
> >
> > lib/ofp-packet.c: In function 'ofputil_decode_packet_in':
> > lib/ofp-
#x27;:
lib/ofp-packet.c:886:27: warning: 'value' may be used
uninitialized [-Wmaybe-uninitialized]
Modifying callers of ofpprop_parse_* functions to always check
the return value before using the value from these functions.
Signed-off-by: Mike Pattrick
---
lib/ofp-act
)
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1776816
Signed-off-by: Mike Pattrick
---
acinclude.m4 | 7
include/linux/automake.mk | 1 +
include/linux/gen_stats.h | 82 +++
lib/tc.c | 12 +-
4 files ch
, we now suppress these messages at
the INFO level and display exact byte count at the debug level.
Signed-off-by: Mike Pattrick
---
lib/lacp.c | 15 +++
ofproto/bond.c | 72 --
2 files changed, 73 insertions(+), 14 deletions(-)
diff
detection fails. Add a switch --force-encapsulation to expose
> this feature to users of ovs-monitor-ipsec
>
> Signed-off-by: Andreas Karis
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> Rename pmd_reblance_dry_run_needed() to
> pmd_rebalance_dry_run_needed().
>
> Fixes: a83a406096e9 ("dpif-netdev: Sync PMD ALB state with user commands.")
>
> Signed-off-by: Kevin Traynor
last numa used when successfully finding a non-local numa
> with available pmds, so the numa RR state is kept for subsequent rxqs.
>
> Fixes: f577c2d046b2 ("dpif-netdev: Rework rxq scheduling code.")
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Mike Pattric
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> There are currently some checks for cross-numa polling cases to
> ensure that they won't effect the accuracy of the PMD ALB.
>
> If an rxq is pinned to a pmd core by the user it will not be
> reassigned by OVS, so even if it is non-local num
On Wed, Mar 2, 2022 at 11:32 AM Kevin Traynor wrote:
>
> Hi Mike, thanks for reviewing,
>
> On 02/03/2022 15:41, Mike Pattrick wrote:
> > On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
> >>
> >> There are currently some checks for cross-numa polling
On Wed, Mar 2, 2022 at 10:50 AM Adrian Moreno wrote:
>
> Thanks Mike,
>
> On 3/1/22 20:14, Mike Pattrick wrote:
> > Add additional logging for debug and info level with a focus on code
> > related to bond members coming up, go down, and changing.
> >
> >
On Tue, Mar 1, 2022 at 12:25 PM Kevin Traynor wrote:
>
> PMD auto load balance currently only operates when the polling pmd core
> will not change numa after reassignment. Add a unit test for this.
>
> Signed-off-by: Kevin Traynor
> ---
Acked
, we now suppress these messages at
the INFO level and display exact byte count at the debug level.
Since v2:
- Normalized log capitalization and periods
- Summarized info level hash transfers
- Added log if bond members were significantly deviant
Signed-off-by: Mike Pattrick
---
lib/lacp.c
gt; Also, update function comments to make it's operation clearer.
>
> Fixes: 6193e03267c1 ("dpif-netdev: Allow pin rxq and non-isolate PMD.")
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tions of the ovs-monitor-ipsec.
>
> This patch adds a list-commands alias name to'help' operation.
>
> Signed-off-by: Mohammad Heib
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Feb 16, 2022 at 9:31 AM Adrian Moreno wrote:
>
> It seems versions older than 0.6.2 generate false positives. Bump the
> recommended version and make sure we uset the headers from the
>
> Suggested-by: Dumitru Ceara
> Signed-off-by: Adrian Moreno
> ---
> Documentation/intro/install/gene
gt; Also, update function comments to make it's operation clearer.
>
> Fixes: 6193e03267c1 ("dpif-netdev: Allow pin rxq and non-isolate PMD.")
>
> Signed-off-by: Kevin Traynor
> ---
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
string, now we just keep
track of the 16 byte flow map.
Signed-off-by: Mike Pattrick
---
lib/dpctl.c| 13 +++--
lib/dpif-netdev-private-flow.h | 2 +-
lib/dpif-netdev.c | 15 +--
lib/dpif-netlink.c | 2 +-
lib/dpif.h
On Thu, Mar 17, 2022 at 7:36 AM Mohammad Heib wrote:
>
> IPsec unit tests uses tcpdump to capture and validate the ESP
> traffic so the test must be skipped in environment that don't
> have the tcpdump tool installed.
>
> Signed-off-by: Mohammad Heib
Doesn't system-traffic.at also use tcpdump? W
cking valid key/value pairs.
>
> Signed-off-by: Andreas Karis
Acked-by: Mike Pattrick
> ---
> Documentation/tutorials/ipsec.rst | 45 +++
> ipsec/ovs-monitor-ipsec.in| 17 +++-
> vswitchd/vswitch.xml | 4 ++-
>
In glibc 2.32 sys_siglist is no longer exported. The MT-safe function
sigdescr_np() is now available for the same purpose.
Signed-off-by: Mike Pattrick
---
configure.ac | 1 +
lib/signals.c | 5 +
2 files changed, 6 insertions(+)
diff --git a/configure.ac b/configure.ac
index 298ea85ab
On Wed, Mar 23, 2022 at 4:23 AM David Marchand
wrote:
>
> On Tue, Mar 22, 2022 at 6:43 PM Mike Pattrick wrote:
> >
> > In glibc 2.32 sys_siglist is no longer exported. The MT-safe function
> > sigdescr_np() is now available for the same purpose.
>
> I am not f
On Wed, Mar 23, 2022 at 10:09 AM Kevin Traynor wrote:
>
> Ensure that if there are no local numa PMD thread
> cores available that pmd cores from all other non-local
> numas will be used.
>
> Signed-off-by: Kevin Traynor
Acked-by: Mike Pattrick
> ---
On Thu, Mar 17, 2022 at 11:54 AM Christophe Fontaine
wrote:
>
> This config param allows the delivery of broadcast and multicast packets
> to the secondary interface of non-lacp bonds, identical to the same option
> for kernel bonds.
>
> Tested with an ovs-dpdk balance-slb bond with 2 virtual func
Add new option --dump-hugepages option in ovs-ctl to enable the addition
of hugepages in the core dump filter.
Signed-off-by: Mike Pattrick
---
NEWS | 4
utilities/ovs-ctl.in | 15 +++
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/NEWS b/NEWS
On Mon, Mar 28, 2022 at 7:11 AM Eelco Chaudron wrote:
>
> This change implements support for the check_pkt_len
> action using the TC police action, which supports MTU
> checking.
>
> Signed-off-by: Eelco Chaudron
Hello Eelco, I've run into a few problems with this patch.
I've found that the fol
On Mon, Mar 28, 2022 at 7:10 AM Eelco Chaudron wrote:
>
> Move handling of the individual actions in the netdev_tc_flow_put()
> function to a separate function that will make recursive action handling
> easier.
>
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattrick
&
On Mon, Mar 28, 2022 at 7:10 AM Eelco Chaudron wrote:
>
> Move handling of the individual actions in the parse_tc_flower_to_match()
> function to a separate function that will make recursive action handling
> easier.
>
> Signed-off-by: Eelco Chaudron
Acked-by: Mike Pattr
Verify that a flow isn't adding more than 64kB in actions when an action
uses multiple check_pkt_larger statements. Failure to do so can cause
ovs-vswitchd to throw signal 6. Also add a depth check to clone and
check_pkt_larger.
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif-xlate.c
On Thu, Apr 7, 2022 at 7:26 AM Adrian Moreno wrote:
>
> Hi Mike,
>
> On 4/6/22 18:48, Mike Pattrick wrote:
> > Verify that a flow isn't adding more than 64kB in actions when an action
> > uses multiple check_pkt_larger statements. Failure to do so can cause
>
On Fri, Apr 8, 2022 at 6:35 AM Eelco Chaudron wrote:
>
>
>
> On 8 Apr 2022, at 11:18, Adrian Moreno wrote:
>
> > On 4/7/22 18:00, Mike Pattrick wrote:
> >> On Thu, Apr 7, 2022 at 7:26 AM Adrian Moreno wrote:
> >>>
> >>> Hi Mike,
> >
have the side effect of leaving only the dpdk
transmit code under the txq lock.
Signed-off-by: Flavio Leitner
Reviewed-by: David Marchand
Signed-off-by: Mike Pattrick
---
V2:
- mentioned the tx lock change in the commit message.
- fixed packet leak when copy fails.
- moved pkt_cnt = cnt
On Thu, Jul 7, 2022 at 7:03 AM David Marchand wrote:
>
> Hello Mike,
>
>
> I did not review carefully yet.
> Just two quick comments.
>
>
> On Fri, Jul 1, 2022 at 5:58 AM Mike Pattrick wrote:
> >
> > From: Flavio Leitner
> >
> > This provides a
instead.
>
> setuptools < 59.0 doesn't have setuptools.errors and so, in this case,
> distutils.errors is still used.
>
> Signed-off-by: Timothy Redaelli
LGTM!
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
htt
On Thu, Jul 7, 2022 at 5:53 AM Amber, Kumar wrote:
>
> Hi Flavio, Mike,
>
>
>
> I did have a quick look over the patch-set
> https://patchwork.ozlabs.org/project/openvswitch/list/?series=307485
>
>
>
> I have some comments over the patches mentioned below:
>
> 1. Can a Cover letter
This is a subset of the larger TSO patchset with various checksumming
improvements. This set includes additional documentation, new appctl
command "dpif-netdev/offload-show" to display interface offload
support, and improvements to tracking when an updated checksum is
required.
Flavio Leitner (4)
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Documentation/automake.mk| 1 +
Documentation/topics/index.rst | 1
alone, so the
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
v5:
- Refactor was mostly removed, except for valid->good
- Reset unsupported offload flags in send_prepare
- Moved send_prepare from process_upcall to
From: Flavio Leitner
Add a new command to show the offloading features of
each data path port.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Reviewed-by: David Marchand
---
lib/dpif-netdev-unixctl.man | 6
lib/dpif-netdev.c | 58
d, so this
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
v5:
- Added David&
It looks like one of the test files fell out of this patch, I'll
re-submit with that corrected.
-M
On Wed, Jul 13, 2022 at 2:14 PM Mike Pattrick wrote:
>
> From: Flavio Leitner
>
> The netdev receiving packets is supposed to provide the flags
> indicating if the IP csum wa
This is a subset of the larger TSO patchset with various checksumming
improvements. This set includes additional documentation, new appctl
command "dpif-netdev/offload-show" to display interface offload
support, and improvements to tracking when an updated checksum is
required.
Flavio Leitner (4):
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Documentation/automake.mk| 1 +
Documentation/topics/index.rst | 1
From: Flavio Leitner
Add a new command to show the offloading features of
each data path port.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Reviewed-by: David Marchand
---
lib/dpif-netdev-unixctl.man | 6
lib/dpif-netdev.c | 58
alone, so the
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
v5:
- Refactor was mostly removed, except for valid->good
- Reset unsupported offload flags in send_prepare
- Moved send_prepare from process_upcall to netd
d, so this
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
v5:
- Added David&
adding a new flag to recalculate the checksum only for last frag.
Should be "only for the first frag."
Acked-by: Mike Pattrick .
>
> Fixes: bc7a5acdff08 ("datapath: add ipv6 'set' action")
> Signed-off-by: Salem Sol
> ---
> lib/pack
On Thu, Jun 23, 2022 at 6:32 AM yangchang wrote:
>
> change 'negotations' to 'negotiations'
>
> Signed-off-by: yangchang
Good catch!
Acked-by: Mike Pattrick
> ---
> lib/lacp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
eate may
> fail, most of the examples in python documentation include
> handling of a NULL case.
>
> Signed-off-by: Ilya Maximets
Looks good to me!
Acked-by: Mike Pattrick
> ---
> python/ovs/_json.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
&g
://bugzilla.redhat.com/show_bug.cgi?id=2109946
Signed-off-by: Mike Pattrick
---
net/openvswitch/datapath.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index 7e8a39a35627..029f9c3e1c28 100644
--- a/net
Signed-off-by: Mike Pattrick
---
net/openvswitch/datapath.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index 029f9c3e1c28..3eee4b0a2005 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
meter to tc police action")
> Signed-off-by: Ilya Maximets
Should we also add these flags to the other system tests?
Acked-by: Mike Pattrick
> ---
> tests/system-offloads-traffic.at | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/syst
On Wed, Aug 3, 2022 at 11:12 AM Ilya Maximets wrote:
>
> On 8/3/22 16:58, Mike Pattrick wrote:
> > On Thu, Jul 28, 2022 at 2:27 PM Ilya Maximets wrote:
> >>
> >> $NC_EOF_OPT should be used to avoid some netcat implementations
> >> to wait indefinitely.
(/lib/x86_64-linux-gnu/libc.so.6+0x29e3f)
> #14 0x562594eed024 in _start (vswitchd/ovs-vswitchd+0x787024)
>
> Fixes: 526df7d8543f ("tunnel: Provide framework for tunnel extensions for
> VXLAN-GBP and others")
> Signed-off-by: Ilya Maximets
Acked-by: Mike Pattrick
>
On Fri, Jul 1, 2022 at 6:53 AM Han Ding wrote:
>
>
> When the bridge protocols is not included Openflow10, printing an error
> message "version negotiation failed" when doing "Restoring saved flows".
>
> Signed-off-by: Han Ding
Looks good to me!
Acked-by:
use we're installing extra dependencies
> that backtrack flake8 down to 4.1 or even 3.9.
>
> Signed-off-by: Ilya Maximets
Looks good to me!
Acked-by: Mike Pattrick
> ---
> python/setup.py | 4 ++--
> tests/test-ovsdb.py | 2 +-
> utilit
On Sat, Jun 4, 2022 at 11:19 AM Peng He wrote:
>
> There is a race condition between the revalidator threads and
> the handler/pmd threads.
>
> revalidator PMD threads
> push_dp_ops deletes a key and tries
> to del the dp magaflow.
> do
n;
+}
VLOG_ABORT("Invalid ukey transition %d->%d (last transitioned from "
"thread %u at %s)", ukey->state, dst, ukey->state_thread,
ukey->state_where);
>
> Mike Pattrick 于2022年8月15日周一 20:16写道：
>>
&
Frames sent to userspace can be reported as dropped in
ovs_dp_process_packet, however, if they are dropped in the netlink code
then netlink_attachskb will report the same frame as dropped.
This patch checks for error codes which indicate that the frame has
already been freed.
Signed-off-by: Mike
601 - 700 of 790 matches
Mail list logo
