[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2021-02-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 cli...@gmail.com changed: What|Removed |Added Status|POST|CLOSED Resolution|---

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #11 from Gwyn Ciesla --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rpm-git-tag-sort -- You are receiving this mail because: You are on the CC list for the bug. You are always

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #10 from Robert-André Mauchin  --- (In reply to clime7 from comment #9) > Ok, great. I think it should be rather marked as 'W'. > > Anyway, do you have some package you would like me to review? Not at the moment, thank you.

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #9 from cli...@gmail.com --- Ok, great. I think it should be rather marked as 'W'. Anyway, do you have some package you would like me to review? -- You are receiving this mail because: You are on the CC list for the bug. You

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #8 from Robert-André Mauchin  --- It's a rpmlint warning: explicit-lib-dependency, not mandatory, just a recommendation. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_requires -- You are receiving

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #7 from cli...@gmail.com --- So requires are unnecessary because they will dynamically added by rpm. I still don't think this should be an error. There is rarely anything wrong with being explicit instead of implicit (in

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #6 from Robert-André Mauchin  --- (In reply to clime7 from comment #5) > - These should be autodetected: > > rpm-git-tag-sort.x86_64: E: explicit-lib-dependency libgit2 > rpm-git-tag-sort.x86_64: E: explicit-lib-dependency

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #5 from cli...@gmail.com --- - These should be autodetected: rpm-git-tag-sort.x86_64: E: explicit-lib-dependency libgit2 rpm-git-tag-sort.x86_64: E: explicit-lib-dependency rpm-libs You mean I shouldn't put them into spec file

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 Robert-André Mauchin  changed: What|Removed |Added Status|NEW |POST

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #3 from cli...@gmail.com --- I made most of changes according to the review. spec file:

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 --- Comment #2 from cli...@gmail.com --- Robert, thank you very much. I will address the issues today. I would argue that 0.0.git.2.498f832d.dirty.0nub0m is sortable but I will replace it by 0.1 if you agree (I am actually upstream too for

[Bug 1858256] Review Request: rpm-git-tag-sort - Sorts git annotated tags according to topology and rpm version sorting

2020-07-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1858256 Robert-André Mauchin  changed: What|Removed |Added CC||zebo...@gmail.com