necessary fixups at
https://github.com/ajdlinux/patchwork/tree/series-api-applied. No
guarantees it's correct.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
P
On 31/10/16 17:08, Daniel Axtens wrote:
Looks good to me, thanks for making the fixups I asked for.
Reviewed-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
I think now every patch in the series has >= 1 review!
SHIP IT! Or something...
Andrew
--
Andrew Donnellan OzL
On 30/10/16 00:13, Stephen Finucane wrote:
Two filters - SubmitterFilter and DelegateFilter - don't attempt to
handle invalid id values and will bubble an exception up as a 5xx
error. Correct this.
Signed-off-by: Stephen Finucane
Ooh, a use of try/else!
Reviewed-by: Andrew Donn
Argh, of course - I neglected the fact that it's a raw string so doesn't
need double escaping. It's been a while since I've touched regexes in
Python...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
On 16/10/16 23:50, Stephen Finucane wrote:
It is now possible to parse and store series, so do just that.
The parsing at the moment is based on both RFC822 headers and
subject lines.
Signed-off-by: Stephen Finucane
One minor issue below.
Reviewed-by: Andrew Donnellan
+def parse_version
that Daniel pointed out.
Otherwise, with Daniel's comments fixed:
Reviewed-by: Andrew Donnellan
diff --git a/patchwork/models.py b/patchwork/models.py
index d0ef44d..49572ec 100644
--- a/patchwork/models.py
+++ b/patchwork/models.py
@@ -292,7 +292,7 @@ class EmailMixin(mo
:
Reviewed-by: Andrew Donnellan
Will try to get through the rest of the series this week...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
On 11/10/16 11:51, Russell Currey wrote:
- no series in the patch API at all. This could probably be implemented a few
different ways, but having no series at all is limiting
I'm looking at this currently.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ib
and project is very low, so form a "handle"
from just this.
Signed-off-by: Stephen Finucane
Reviewed-by: Andy Doan
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 10/10/16 09:25, Stephen Finucane wrote:
A number of models contain functions that are, semantically speaking,
actually properties. Mark them as such.
Signed-off-by: Stephen Finucane
Reviewed-by: Andy Doan
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL
make it to the list again.
I assume it's
https://github.com/stephenfin/patchwork/commit/8a7d483e96c6dd52ef6de2ac4a8df37f39df37c2.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
On 10/10/16 09:36, Stephen Finucane wrote:
This field was unused and has been for a long time (pre-0.9.0).
Signed-off-by: Stephen Finucane
LGTM!
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
s. And I'd like at least
maintainers, or perhaps series authors, etc. to be able to give series
names in patchwork. I don't really mind whether this attaches to a
Series or to a SeriesRevision.
I realise this makes the models a bit more heavy-weight.
Thoughts?
I like this idea quite
On 13/09/16 07:53, Stephen Finucane wrote:
Add a series model. This model is intentionally very minimal to allow
as much dynaminism as possible. It is expected that patches will be
migrated between series as new data is provided.
Signed-off-by: Stephen Finucane
Co-authored-by: Andrew Donnellan
On 14/09/16 16:38, Johannes Berg wrote:
That would be before the redirect though, no? Also, every page (while
Yes it would be.
logged in) loads the n_todo_pages(), and that takes virtually no time
at all.
Good point...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel
te
difference.
A quick look at the code says that the todo list views call
.todo_patches() on every single project, which could be a bit slow.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
On 13/09/16 07:53, Stephen Finucane wrote:
Add support for series. Series are groups of patches sent as one
bundle. For example:
It looks like patch 4 didn't hit the list.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Li
On 03/09/16 17:07, Daniel Axtens wrote:
The try block just raises the exception it catches, so just get rid of
it.
Signed-off-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
---
patchwork/views/xmlrpc.py | 30 +-
1 file changed, 13 insertions(+), 17 deletions
es #2
- [3/3] is the same as above.
This is the sanest approach I think. For each 1/N patch, create a new
series.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
P
On 05/09/16 13:58, Andrew Donnellan wrote:
+def handle(self, *args, **options):
+path = (args[0] if args else
+options['infile'] if 'infile' in options else None)
argparse is giving you a file, not a string. As you've given a default
in
))
+
+self.assertEqual(exc.exception.code, 1)
+
+def test_stdin_failure(self):
+# we haven't created a project yet, so this will fail
+with open(os.path.join(TEST_MAIL_DIR,
+ '0001-git-pull-request.mbox')) as file_:
+
ptions['infile'] if 'infile' in options else None)
+stdin = options.get('stdin', sys.stdin)
+
+# Attempt to parse the path if provided, and fallback to stdin if not
+if path and not isinstance(path, file):
This is
with old
versions of Django interfering.
Signed-off-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
---
This is my suggestion at a better way to approach the
sqlparse/django-debug-toolbar mess.
---
patchwork/settings/dev.py | 34 +++---
requirements-de
On 09/08/16 14:38, Daniel Axtens wrote:
Yay for debugging with Docker.
Signed-off-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
data from fixtures.
Signed-off-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
mmand line interface
can be insecure.
db_1 | mysql: [Warning] Using a password on the command line interface
can be insecure.
db_1 |
db_1 | /usr/local/bin/docker-entrypoint.sh: ignoring
/docker-entrypoint-initdb.d/*
db_1 |
db_1 |
db_1 | MySQL init process done. Ready for start up.
d
othing else
+# just exit cleanly
+ exit 0
+elif [ "$1" == "--shell" ]; then
+exec bash
+elif [ "$1" == "--quick-test" ]; then
+export PW_SKIP_BROWSER_TESTS=yes
+python3 manage.py test
+elif [ "$1" == "--test" ]; then
+xvfb-run --server-args='-screen 0, 1024x768x16' python3 manage.py test
+else # run whatever CMD is set to
+$@
+fi
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
.
Signed-off-by: Daniel Axtens
All looks good.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https
On 04/08/16 16:10, Daniel Axtens wrote:
This is preparation for a Docker-based dev environment.
Signed-off-by: Daniel Axtens
A good move generally.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 04/08/16 16:10, Daniel Axtens wrote:
Signed-off-by: Daniel Axtens
Reviewed-by: Andrew Donnellan
Maybe chuck "\#*#" in there as well?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Austral
main
chromium git repo.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
name "seriesrevision-detail". You may have failed to include the related model
in your API, or incorrectly configured the `lookup_field` attribute on this
field.
Full log here: http://dpaste.com/0P3C63K
Temporary fix to exclude the series field from the Patch endpoint.
Signed-off-by: A
l patch, and we have all of those results
appearing on every patch, things could get more than a little bit
confusing. Personally, I'd be inclined to submit series-wide test
results as checks on the very last patch in the series instead of using
this.
--
Andrew Donnellan OzLa
h model to a series model? Any kind of tests run on a patch are
typically focused on the entire series.
I'd like to see the ability to report a test state against an entire
series, but I think it would be useful to keep test states against
individual patches as well.
--
A
201 - 234 of 234 matches
Mail list logo