[pgadmin-hackers] Possible crash fix for xmlCleanupParser

2013-08-12 Thread Neel Patel
Hi Dave, Please find attached patch for the below issue in pgAdmin. "As per libxml2 document (below link) we should call xmlCleanupParser() only one time when the application exists not every time when we compute the xml parser. As per the document application may crash if another thread or plugi

Re: [pgadmin-hackers] Possible crash fix for xmlCleanupParser

2013-08-12 Thread Dave Page
On Mon, Aug 12, 2013 at 12:28 PM, Neel Patel wrote: > Hi Dave, > > Please find attached patch for the below issue in pgAdmin. > > "As per libxml2 document (below link) we should call xmlCleanupParser() only > one time when the application exists not every time when we compute the xml > parser. As

Re: [pgadmin-hackers] Possible crash fix for xmlCleanupParser

2013-08-12 Thread Neel Patel
Hi Dave, Thanks for the comments. Find the updated patch after fixing the below review comments. -- Removed the cleanup call when we exit the application. Thanks, Neel Patel On Mon, Aug 12, 2013 at 5:58 PM, Dave Page wrote: > On Mon, Aug 12, 2013 at 12:28 PM, Neel Patel > wrote: > > Hi Dave

[pgadmin-hackers] pgAdmin III commit: Don't try to cleanup the libxml2 parser when closin

2013-08-12 Thread Dave Page
Don't try to cleanup the libxml2 parser when closing frmReport, as it clears all of the library's state and can potentially lead to crashes if libxml2 is used elsewhere later. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=02423e7718c514fc8b1d9

[pgadmin-hackers] pgAdmin III commit: Don't try to cleanup the libxml2 parser when closin

2013-08-12 Thread Dave Page
Don't try to cleanup the libxml2 parser when closing frmReport, as it clears all of the library's state and can potentially lead to crashes if libxml2 is used elsewhere later. Branch -- REL-1_16_0_PATCHES Details --- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=2d752c6b0

Re: [pgadmin-hackers] Possible crash fix for xmlCleanupParser

2013-08-12 Thread Dave Page
Thanks, applied. On Mon, Aug 12, 2013 at 1:43 PM, Neel Patel wrote: > Hi Dave, > > Thanks for the comments. > > Find the updated patch after fixing the below review comments. > -- Removed the cleanup call when we exit the application. > > Thanks, > Neel Patel > > > > On Mon, Aug 12, 2013 at 5:58