[pgadmin-hackers] PATCH: To fix salt generation in session.py

Hi, With latest pull session.py fails with below error with python3 because in python3 strings 'lowercase' method has been renamed to 'ascii_lowercase', PFA patch to fix the issue. Issue: -- * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign* *self.randval = ''.join(

Re: [pgadmin-hackers] PATCH: To fix salt generation in session.py

Hi, Please hold on in this patch, Need additional changes. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > With latest pull sessio

[pgadmin-hackers] [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime

Hi *Issue:* When we click on "Clear query window" button in Query tool, a new instance of query tool opens in new window. The event "StopEventPropogation" was not working. Please find the attached patch and review. Thanks, Surinder Kumar clear_query_opens_in_new_window_mac_runtime.patch Descri

Re: [pgadmin-hackers] PATCH: Fix the issue for saving query output as CSV

Hi, PFA patch for RM1405. Also to allow download in runtime we will still need patch sent by Neel. Changes: To download query result to CSV directly from server and not to use download

[pgadmin-hackers] [pgAdmin4][Patch]: RM#1420 - Reverse engineered SQL incomplete for Databases

Hi Please find attached patch with fix and review. Included missing Create and Drop comments in generated sql query. Thanks, Surinder Kumar RM#1420.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: ht

Re: [pgadmin-hackers] PATCH: To fix salt generation in session.py

Hi Murtuza, Can you please test this patch for the same? -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Jul 11, 2016 at 12:44 PM, Murtu

Re: [pgadmin-hackers] PATCH: To fix salt generation in session.py

Hi, Tested, I'm able to login now. Thanks, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi wrote: > Hi Murtuza, > > Can you please test this patch for the same? > > -- > > Thanks &

[pgadmin-hackers] pgAdmin 4 commit: [Python 3 compability] Allow to run the auto-discover

[Python 3 compability] Allow to run the auto-discovery implementation on Python 3. Refs #1389 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=889b69ac82ea6aae3149eb44ae6488785c9bb0d8 Modified Files -- web/pgadmin/__init__.py | 64 ++

[pgadmin-hackers] pgAdmin 4 commit: Do not try to show the database dashboard, when click

Do not try to show the database dashboard, when clicked on one of the children node. This implementation will allow to add new nodes at server level without modifying the dashboard code. I found the issue during the pgAgent Jobs node implementation. Branch -- master Details --- http://git

[pgadmin-hackers] pgAdmin 4 commit: [Python 3 Compability] Made changes to make the new s

[Python 3 Compability] Made changes to make the new server-side session implementation works with Python 3. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b809523eb929ef9467b59f2d59c05770496a247 Modified Files -- web/pgadmin/utils

Re: [pgadmin-hackers] PATCH: To fix salt generation in session.py

I've committed the patch. Thanks for testing it. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, Jul 11, 2016 at 4:30 PM, Murtuza Zabuawa

Re: [pgadmin-hackers] [Patch] Fix Unicode in errmsg

Just found another decoding error, this time during server group creation. Path attached. Thanks again. --- Magnun Leno Em 07-07-2016 08:39, Ashesh Vashi escreveu: Sure - I will do. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [Patch] Fix Unicode in errmsg

Ashesh, please review/commit this one too. Thanks. On Fri, Jul 8, 2016 at 5:07 PM, Magnun Leno (Pessoal) wrote: > Just found another decoding error, this time during server group creation. > Path attached. > > Thanks again. > > --- > > Magnun Leno > > Em 07-07-2016 08:39, Ashesh Vashi escreveu:

Re: [pgadmin-hackers] Where do I submit patches?

On Fri, Jul 8, 2016 at 3:25 PM, Stuart Gathman wrote: > On 07/07/2016 06:48 PM, Dave Page wrote: >>> On 7 Jul 2016, at 17:35, Stuart Gathman wrote: >>> >>> I submitted a bugfix to this mailing list, didn't see a response, but >>> *did* see references to issue numbers. Where do you file issues?

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

On Fri, Jul 8, 2016 at 2:30 PM, Navnath Gadakh < navnath.gad...@enterprisedb.com> wrote: > > Hi Dave, > > PFA patch for modular API test cases. > > Kindly, review the same and let me know for any modification. > Please re-create the patch so that it doesn't revert various changes made to config.p

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

Hi, No, sorry I don't have an extra system you can test on. It's pretty clear that query would fail - it's missing a database OID after the = On Fri, Jul 8, 2016 at 10:38 AM, Priyanka Shendge wrote: > Hi Dave, > > I have tried to reproduce the issue by running the test-suite on different > mach

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

Sorry, by mistake i copied incomplete query. There is an OID present for added database. SELECT db.oid as did, db.datname, db.datallowconn, pg_encoding_to_char(db.encoding) AS serverencoding, has_database_privilege(db.oid, 'CREATE') as cancreate, datlastsysoid FROM pg_database db

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge wrote: > Sorry, by mistake i copied incomplete query. There is an OID present for > added database. > > SELECT > db.oid as did, db.datname, db.datallowconn, > pg_encoding_to_char(db.encoding) AS serverencoding, > has_database_privilege

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar wrote: > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar > wrote: >> >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page wrote: >>> >>> Hi, >>> >>> I think we need more changes than just that; >>> >>> - The path at the top should not be editable (it should

Re: [pgadmin-hackers] pgAdmin IV : Unittest modular patch

Hi Dave, PFA updated patch for modular API test cases. On Mon, Jul 11, 2016 at 5:11 PM, Dave Page wrote: > > > On Fri, Jul 8, 2016 at 2:30 PM, Navnath Gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> >> Hi Dave, >> >> PFA patch for modular API test cases. >> >> Kindly, review the same and

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

On 11 July 2016 at 18:35, Dave Page wrote: > On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge > wrote: > > Sorry, by mistake i copied incomplete query. There is an OID present for > > added database. > > > > SELECT > > db.oid as did, db.datname, db.datallowconn, > > pg_encoding_to_char

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

On Mon, Jul 11, 2016 at 7:15 PM, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > > > On 11 July 2016 at 18:35, Dave Page wrote: > >> On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge >> wrote: >> > Sorry, by mistake i copied incomplete query. There is an OID present >> for >> > a

Re: [pgadmin-hackers] [Patch] Fix Unicode in errmsg

Hi Magun, Please find my comments inline.. On Fri, Jul 8, 2016 at 9:37 PM, Magnun Leno (Pessoal) wrote: > Just found another decoding error, this time during server group creation. > What error are you getting? Can you please share the exact error message to understand the issue properly? We w

[pgadmin-hackers] PATCH: To update table dialog column definition

Hi, PFA patch to fix below issues *1) User** cannot select a datatype without using the mouse.* Fixed. Remaining issue, --- We are using Switch cell to select Not NULL & Is primary key options. But as per Backgrid design we are not allowed to enter in edit mode directly for

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

On Mon, Jul 11, 2016 at 6:41 PM, Dave Page wrote: > On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar > wrote: > > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar > > wrote: > >> > >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page wrote: > >>> > >>> Hi, > >>> > >>> I think we need more changes than jus