[pgadmin-hackers] [pgAdmin4][Patch]: CanDrop option is missing for newly created database

2016-07-12 Thread Surinder Kumar
Hi I found this issue while working on an RM case. *Solution:* setting *canDrop* flag to True fix the issue. Please find attached patch with fix and review. Thanks, Surinder Kumar canDrop_missing_for_new_created_db.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pg

[pgadmin-hackers] pgAdmin 4 commit: 'hasattr' function on '__builtins__' for 'xrange' fun

2016-07-12 Thread Ashesh Vashi
'hasattr' function on '__builtins__' for 'xrange' function does not return correct information from a script, but works well on interactive shell. Used a more proper check for Python > 2 instead of the current implementation. Thanks Vishal for the report. Branch -- master Details --- htt

[pgadmin-hackers] PATCH: Unable to create procedure (pgAdmin4)

2016-07-12 Thread Murtuza Zabuawala
Hi, PFA patch to fixed the issue in procedure node where user were not able to create new procedure when they provide arguments. (RM#1449) To fix the issue we used qtTypeIdent in sql template for datatype, earlier it was qtIdent which was causing issue. -- Regards, Murtuza Zabuawala EnterpriseD

[pgadmin-hackers] pgAdmin 4 feedback

2016-07-12 Thread Michael Hornick
Hello team - great work! We have been using Postrgres as the main database for our insurance product for over 10 years, and it has been a great experience so far. Personally, I have been using a product called AQT to do most of my Postgres SQL work - mainly because of the lack of "features" of

[pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Surinder Kumar
Hi *What is happening in code?* Database is created with Chinese characters successfully with ascii values(Chinese characters converted to ascii) before saving internally. but when database properties is retrieved by name, it fails to fetch data and throws UnicodeError. *Solution:* Database name

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Murtuza Zabuawala
Hi, Just a heads up, This issue is occurs only in runtime & If you try in web everything works fine when you provide unicode characters as object name. Now sure but the issue is when runtime(QtWebkit) sends data it does not encodes it properly & this should be generic fix in runtime. Regards, Mu

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Surinder Kumar
On Tue, Jul 12, 2016 at 3:43 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Just a heads up, This issue is occurs only in runtime & If you try in web > everything works fine when you provide unicode characters as object name. > No, this issue is reported for both web

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Murtuza Zabuawala
May be because of Python2.7 but if you try in Python3. It works. we can use PEP 0263 to fix this issue. // # -*- coding: utf-8 -*- -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 12

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Surinder Kumar
On Tue, Jul 12, 2016 at 3:48 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Tue, Jul 12, 2016 at 3:43 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> Just a heads up, This issue is occurs only in runtime & If you try in web >> everything works

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Ashesh Vashi
On Tue, Jul 12, 2016 at 3:58 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > May be because of Python2.7 but if you try in Python3. It works. > > we can use PEP 0263 to fix > this issue. // # -*- coding: utf-8 -*- > Isn't this about

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Surinder Kumar
On Tue, Jul 12, 2016 at 4:07 PM, Ashesh Vashi wrote: > On Tue, Jul 12, 2016 at 3:58 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> May be because of Python2.7 but if you try in Python3. It works. >> >> we can use PEP 0263 to fi

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Regarding RM#1419 - Internal Server Error displayed if create any object through simplified Chinese character

2016-07-12 Thread Murtuza Zabuawala
Please refer, http://stackoverflow.com/questions/3828723/why-should-we-not-use-sys-setdefaultencodingutf-8-in-a-py-script -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Jul 12, 2016 at 4:18 PM, Surinder Kumar < surinder.ku...@ent

[pgadmin-hackers] PATCH: Comments are not visible in Language node (pgAdmin4)

2016-07-12 Thread Murtuza Zabuawala
Hi, PFA patch to fix RM#1412, where comments are not visible in sql pane for Languages node. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1421.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hacke

Re: [pgadmin-hackers] pgAdmin 4 feedback

2016-07-12 Thread Dave Page
Hi On Mon, Jul 11, 2016 at 9:18 PM, Michael Hornick < mhorn...@insurancesystems.com> wrote: > Hello team – great work! > Thanks! > We have been using Postrgres as the main database for our insurance > product for over 10 years, and it has been a great experience so far. > Personally, I have be

Re: [pgadmin-hackers] pgAdmin IV API test cases patch

2016-07-12 Thread Dave Page
On Tue, Jul 12, 2016 at 5:14 AM, Khushboo Vashi wrote: > > > On Mon, Jul 11, 2016 at 7:15 PM, Priyanka Shendge > wrote: >> >> >> >> On 11 July 2016 at 18:35, Dave Page wrote: >>> >>> On Mon, Jul 11, 2016 at 1:25 PM, Priyanka Shendge >>> wrote: >>> > Sorry, by mistake i copied incomplete query.

Re: [pgadmin-hackers] [Patch] Fix Unicode in errmsg

2016-07-12 Thread Ashesh Vashi
On Wed, Jul 13, 2016 at 1:11 AM, Magnun Leno wrote: > What error are you getting? > Can you please share the exact error message to understand the issue > properly? > > Sorry, my bad. Here is the traceback: > > 2016-07-12 16:12:22,366: ERRORpgadmin:Exception on > /browser/server-group/obj

[pgadmin-hackers] Regarding issue in psycopg2 driver handling duplicate field names in query (pgAdmin4)

2016-07-12 Thread Murtuza Zabuawala
Hi, I was looking into RM#1409 and found that it is issue with psycopg2 driver handling DictCursor result which is not handling duplicate field names. I have also raised issue for the same https://github.com/psycopg/psycopg2/issues/454 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.ent

[pgadmin-hackers] [pgAdmin4][Patch]: Render data grid only if Dashboard Panel is active

2016-07-12 Thread Surinder Kumar
Hi In Dashboard, the ajax calls to *render data grid* should only made, if dashboard panel is active. Currently it make ajax calls even if other panels like properties, sql are active. Please find attached patch and review. Thanks, Surinder Kumar dashboard_render_if_panel_is_opened.patch Descr