[pgadmin-hackers] pgAdmin 4 commit: Request Six>=1.9.0 as the current version is 1.10.0 a

2017-01-27 Thread Dave Page
Request Six>=1.9.0 as the current version is 1.10.0 and it gets pre-installed in every new virtualenv. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=42d3121369df49e67a4556c7191466f4fd1014a2 Modified Files -- requirements_py2.txt

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-27 Thread Jan Alexander Steffens
On Thu, Jan 26, 2017 at 3:58 PM Dave Page wrote: > In the meantime, I'm thinking something like the attached patch would > be more appropriate. The only issue I can find with it at the moment > (having just tested on a Mac dev environment for now) is that if > initialisation fails and you enter a

[pgadmin-hackers] [pgAdmin4][patch][FileManager]: RM-2110 - Invalid path error displayed

2017-01-27 Thread Neel Patel
Hi, Please find attached patch file for the fix of RM#2110. When user try to save the file through fileManager then it gives error saying "Invalid Path" while getting folder details from python server. This issue is only reproducible with desktop runtime application with windows OS. I have teste

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fix RM1790 - [Web] Support setting a field's value to "null"

2017-01-27 Thread Surinder Kumar
Hi Dave, Please find updated patch. On Mon, Jan 16, 2017 at 10:01 PM, Dave Page wrote: > Hi > > On Fri, Jan 13, 2017 at 9:24 AM, Surinder Kumar > wrote: > > Hi > > > > Please find attached patch and review. > > > > On Sun, Jan 8, 2017 at 3:27 PM, Dave Page wrote: > >> > >> Hi > >> > >> On Fri

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-27 Thread Dave Page
On Thu, Jan 26, 2017 at 7:22 PM, Jan Alexander Steffens wrote: > On Thu, Jan 26, 2017 at 3:58 PM Dave Page wrote: >> >> In the meantime, I'm thinking something like the attached patch would >> be more appropriate. The only issue I can find with it at the moment >> (having just tested on a Mac dev

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 2069 - Wrong tablespace displayed in table properties

2017-01-27 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Jan 20, 2017 at 5:31 PM, Dave Page wrote: > On Fri, Jan 13, 2017 at 6:41 AM, Khushboo Vashi > wrote: > > Hi, > > > > Please find the attached patch to fix the RM 2069 - Wrong tablespace > > displayed in table properties. > >

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-27 Thread Jan Alexander Steffens
On Fri, Jan 27, 2017 at 12:04 PM Dave Page wrote: > On Thu, Jan 26, 2017 at 7:22 PM, Jan Alexander Steffens > wrote: > > Looking through the cpython code, Py_SetPath(NULL) clears the calculated > > module search path again. Try calling this before the Py_Initialize. > > Unfortunately that just c

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-27 Thread Dave Page
On Thu, Jan 26, 2017 at 10:40 PM, George Gelashvili wrote: > instead of that patch, please use this no-zombies version that kills the > started process group instead of pid-only. Very cool :-). The only minor annoyance for me is that my Mac pops up a message asking me if I want pgAdmin to accept

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
Very nice indeed! I didn't realise we'd ended up with quite so many duplicated templates. Both patches look good to me - really the only thing that caught my eye was the name versioned_template_loader which is somewhat longer than I'd prefer. As it's a major change, and we're going to be wrapping

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
Scrub that Khushboo - Murtuza, can you review on Monday please? I'm being told Khushboo is on the critical path for something else at the moment. On Fri, Jan 27, 2017 at 4:22 PM, Dave Page wrote: > Very nice indeed! I didn't realise we'd ended up with quite so many > duplicated templates. > > Bot

Re: [pgadmin-hackers] Acceptance Tests against a browser (WIP)

2017-01-27 Thread Dave Page
On Fri, Jan 27, 2017 at 4:11 PM, Dave Page wrote: > On Thu, Jan 26, 2017 at 10:40 PM, George Gelashvili > wrote: >> instead of that patch, please use this no-zombies version that kills the >> started process group instead of pid-only. > > Very cool :-). The only minor annoyance for me is that my

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread George Gelashvili
Thanks! Did you have a name in mind? We're not sure we could come up with a clear name in fewer words. On Fri, Jan 27, 2017 at 11:27 AM, Dave Page wrote: > Scrub that Khushboo - Murtuza, can you review on Monday please? I'm > being told Khushboo is on the critical path for something else at the

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
sql_loader ? On Fri, Jan 27, 2017 at 4:38 PM, George Gelashvili wrote: > Thanks! > Did you have a name in mind? We're not sure we could come up with a clear > name in fewer words. > > On Fri, Jan 27, 2017 at 11:27 AM, Dave Page wrote: >> >> Scrub that Khushboo - Murtuza, can you review on Monday

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread George Gelashvili
That would work, but the versioned template loader can load anything that is a template, as it extends from DispatchingJinjaLoader On Fri, Jan 27, 2017 at 11:39 AM, Dave Page wrote: > sql_loader ? > > On Fri, Jan 27, 2017 at 4:38 PM, George Gelashvili > wrote: > > Thanks! > > Did you have a nam

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread Dave Page
Good point. How about just versioned_loader? On Fri, Jan 27, 2017 at 4:40 PM, George Gelashvili wrote: > That would work, but the versioned template loader can load anything that is > a template, as it extends from DispatchingJinjaLoader > > On Fri, Jan 27, 2017 at 11:39 AM, Dave Page wrote: >>

Re: [pgadmin-hackers] [pgAdmin4] [PATCH] Simplify Server's python setup

2017-01-27 Thread Dave Page
On Fri, Jan 27, 2017 at 1:37 PM, Jan Alexander Steffens wrote: > On Fri, Jan 27, 2017 at 12:04 PM Dave Page wrote: >> >> On Thu, Jan 26, 2017 at 7:22 PM, Jan Alexander Steffens >> wrote: >> > Looking through the cpython code, Py_SetPath(NULL) clears the calculated >> > module search path again.

Re: [pgadmin-hackers][Patch] Refactor sql template version picking

2017-01-27 Thread George Gelashvili
We thought of that one too. That sort of makes it sound like the loader is versioned rather than the template files. Also, it's unclear what it is a loader for without "template". That said, do you think there is a better place for it to live? We stuck it under utils just because we didn't see any

[pgadmin-hackers][Patch] Bypass recovery state for Greenplum

2017-01-27 Thread George Gelashvili
This bypasses checking if the DB is in recovery for versions of postgres that don't support pg_is_in_recovery() (anything pre-9.0, such as Greenplum). This patch depends on the "Refactor sql template version picking" patch. diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/

[pgadmin-hackers] [pgAdmin4][Patch]: RM#2015 - Trigger issues

2017-01-27 Thread Neel Patel
Hi, Please find attached patch file for the fix of RM#2015. Below additional issues are fixed along with description provided in RM. - When user update any of the parameter - trigger gets disappear from browser tree. To make it visible user has to do refresh. - Edit Mode - 'Row level'