Re: pgsql: Implement channel binding tls-server-end-point for SCRAM

2018-01-08 Thread Simon Riggs
On 4 January 2018 at 21:02, Tom Lane wrote: > Peter Eisentraut writes: >> Implement channel binding tls-server-end-point for SCRAM > > Buildfarm doesn't like this one bit. Can't we automate these messages? Seems strange to send manual emails every time. We do know who the commits are coming from

Buildfarm status monitoring (was Re: pgsql: Implement channel binding tls-server-end-point for SCRAM)

2018-01-08 Thread Tom Lane
Simon Riggs writes: > On 4 January 2018 at 21:02, Tom Lane wrote: >> Peter Eisentraut writes: >>> Implement channel binding tls-server-end-point for SCRAM >> Buildfarm doesn't like this one bit. > Can't we automate these messages? It's not that easy. First, the buildfarm gets random failures

Re: Buildfarm status monitoring (was Re: pgsql: Implement channel binding tls-server-end-point for SCRAM)

2018-01-08 Thread Andrew Dunstan
On 01/08/2018 11:01 AM, Tom Lane wrote: > Simon Riggs writes: >> On 4 January 2018 at 21:02, Tom Lane wrote: >>> Peter Eisentraut writes: Implement channel binding tls-server-end-point for SCRAM >>> Buildfarm doesn't like this one bit. >> Can't we automate these messages? > It's not that

pgsql: Cosmetic improvements in condition_variable.[hc].

2018-01-08 Thread Tom Lane
Cosmetic improvements in condition_variable.[hc]. Clarify a bunch of comments. Discussion: https://postgr.es/m/CAEepm=0nwkehyw7ndousf8juukoprncyy3vuasvhrewsota...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e35dba475a440f73dccf9ed1fd61e3abc6ee61

pgsql: Improve error detection capability in proclists.

2018-01-08 Thread Tom Lane
Improve error detection capability in proclists. Previously, although the initial state of a proclist_node is expected to be next == prev == 0, proclist_delete_offset would reset nodes to next == prev == INVALID_PGPROCNO when removing them from a list. This is the same state that a node in a singl

pgsql: pg_upgrade: prevent check on live cluster from generating error

2018-01-08 Thread Bruce Momjian
pg_upgrade: prevent check on live cluster from generating error Previously an inaccurate but harmless error was generated when running --check on a live server before reporting the servers as compatible. The fix is to split error reporting and exit control in the exec_prog() API. Reported-by: Da

pgsql: pg_upgrade: prevent check on live cluster from generating error

2018-01-08 Thread Bruce Momjian
pg_upgrade: prevent check on live cluster from generating error Previously an inaccurate but harmless error was generated when running --check on a live server before reporting the servers as compatible. The fix is to split error reporting and exit control in the exec_prog() API. Reported-by: Da