[COMMITTERS] pgsql: Fix various instances of "the the".

2010-04-23 Thread Robert Haas
Log Message: --- Fix various instances of "the the". Two of these were pointed out by Erik Rijkers; the rest I found. Modified Files: -- pgsql/contrib/cube: CHANGES (r1.3 -> r1.4) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/cube/CHANGES?r1=1.3&

Re: [HACKERS] [COMMITTERS] pgsql: Add missing optimizer hooks for function cost and number of rows.

2010-04-23 Thread Robert Haas
On Fri, Apr 23, 2010 at 6:55 PM, Tom Lane wrote: > sri...@postgresql.org (Simon Riggs) writes: >> Log Message: >> --- >> Add missing optimizer hooks for function cost and number of rows. >> Closely follow design of other optimizer hooks: if hook exists >> retrieve value from plugin; if sti

Re: [COMMITTERS] pgsql: Add missing optimizer hooks for function cost and number of rows.

2010-04-23 Thread Tom Lane
sri...@postgresql.org (Simon Riggs) writes: > Log Message: > --- > Add missing optimizer hooks for function cost and number of rows. > Closely follow design of other optimizer hooks: if hook exists > retrieve value from plugin; if still not set then get from cache. What exactly are we doin

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Tom Lane
Robert Haas writes: > On Fri, Apr 23, 2010 at 4:44 PM, Tom Lane wrote: >> A design that might work is >> (1) store the active value of wal_mode in pg_control (but NOT as part of >> the last-checkpoint-record image). >> (2) invent a new WAL record type that is transmitted when we change >> wal_mod

[COMMITTERS] pgsql: Add missing optimizer hooks for function cost and number of rows.

2010-04-23 Thread Simon Riggs
Log Message: --- Add missing optimizer hooks for function cost and number of rows. Closely follow design of other optimizer hooks: if hook exists retrieve value from plugin; if still not set then get from cache. Modified Files: -- pgsql/src/backend/utils/cache: lsys

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Simon Riggs
On Fri, 2010-04-23 at 16:44 -0400, Tom Lane wrote: > There's no connection at all between what the GUC state > was at shutdown and what it might be after starting again. > > A design that might work is > (1) store the active value of wal_mode in pg_control (but NOT as part of > the last-checkpoin

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Robert Haas
On Fri, Apr 23, 2010 at 4:44 PM, Tom Lane wrote: > Simon Riggs writes: >> No intention of doing that. This change allows people to see what the >> dependency actually is once the bug has been fixed. Change needs to >> start from here, not from where we were before. > > Well, actually, now that I'

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Tom Lane
Simon Riggs writes: > No intention of doing that. This change allows people to see what the > dependency actually is once the bug has been fixed. Change needs to > start from here, not from where we were before. Well, actually, now that I've looked at the patch I think it's starting from a fundam

Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Simon Riggs
On Fri, 2010-04-23 at 16:05 -0400, Robert Haas wrote: > On Fri, Apr 23, 2010 at 3:57 PM, Simon Riggs wrote: > > Log Message: > > --- > > Make CheckRequiredParameterValues() depend upon correct combination > > of parameters. Fix bug report by Robert Haas that error message and > > hint was

[COMMITTERS] pgsql: Previous patch revoked following objections.

2010-04-23 Thread Simon Riggs
Log Message: --- Previous patch revoked following objections. Modified Files: -- pgsql/src/backend/access/transam: xlog.c (r1.402 -> r1.403) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c?r1=1.402&r2=1.403) pgsql/src/i

Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Simon Riggs
On Fri, 2010-04-23 at 16:04 -0400, Tom Lane wrote: > sri...@postgresql.org (Simon Riggs) writes: > > Log Message: > > --- > > Make CheckRequiredParameterValues() depend upon correct combination > > of parameters. Fix bug report by Robert Haas that error message and > > hint was incorrect if

Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Robert Haas
On Fri, Apr 23, 2010 at 3:57 PM, Simon Riggs wrote: > Log Message: > --- > Make CheckRequiredParameterValues() depend upon correct combination > of parameters. Fix bug report by Robert Haas that error message and > hint was incorrect if wrong mode parameters specified on master. > Internal

Re: [COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Tom Lane
sri...@postgresql.org (Simon Riggs) writes: > Log Message: > --- > Make CheckRequiredParameterValues() depend upon correct combination > of parameters. Fix bug report by Robert Haas that error message and > hint was incorrect if wrong mode parameters specified on master. > Internal changes

[COMMITTERS] pgsql: Make CheckRequiredParameterValues() depend upon correct

2010-04-23 Thread Simon Riggs
Log Message: --- Make CheckRequiredParameterValues() depend upon correct combination of parameters. Fix bug report by Robert Haas that error message and hint was incorrect if wrong mode parameters specified on master. Internal changes only. Proposals for parameter simplification on master/p

[COMMITTERS] pgbouncer - pgbouncer: v1.3.3rc1

2010-04-23 Thread User Mkz
Log Message: --- v1.3.3rc1 Modified Files: -- pgbouncer: NEWS (r1.41 -> r1.42) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/NEWS?r1=1.41&r2=1.42) configure.ac (r1.59 -> r1.60) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi

[COMMITTERS] pgbouncer - pgbouncer: Now actually improve few disconnect messages.

2010-04-23 Thread User Mkz
Log Message: --- Now actually improve few disconnect messages. Modified Files: -- pgbouncer/src: client.c (r1.28 -> r1.29) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/src/client.c?r1=1.28&r2=1.29) -- Sent via pgsql-committers mailing

[COMMITTERS] pgbouncer - pgbouncer: Let disconnect_server/client() take printf style

2010-04-23 Thread User Mkz
Log Message: --- Let disconnect_server/client() take printf style args. Modified Files: -- pgbouncer/include: objects.h (r1.8 -> r1.9) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/include/objects.h?r1=1.8&r2=1.9) pgbouncer/src:

[COMMITTERS] pgbouncer - pgbouncer: gcc braindamage: -Wformat-security is not turned

2010-04-23 Thread User Mkz
Log Message: --- gcc braindamage: -Wformat-security is not turned on by -Wall -Wextra -Wformat Modified Files: -- pgbouncer: configure.ac (r1.58 -> r1.59) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/configure.ac?r1=1.58&r2=1.59) pgb

[COMMITTERS] pgbouncer - pgbouncer: Increase size of various startup-related buffers.

2010-04-23 Thread User Mkz
Log Message: --- Increase size of various startup-related buffers. Also bring them under single define. Modified Files: -- pgbouncer/src: admin.c (r1.44 -> r1.45) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/src/admin.c?r1=1.44&r2=1.45)