Re: hio.c does visibilitymap_pin()/IO while holding buffer lock

2023-03-25 Thread Andres Freund
Hi, On 2023-03-25 12:57:17 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2023-03-25 14:34:25 +0100, Tomas Vondra wrote: > >> Can't we ensure we actually lock the vm buffer too in ReadBufferBI, > >> before calling ReadBufferExtended? Or am I confused and that's

Re: hio.c does visibilitymap_pin()/IO while holding buffer lock

2023-03-25 Thread Andres Freund
Hi, On 2023-03-25 14:34:25 +0100, Tomas Vondra wrote: > On 3/25/23 03:57, Andres Freund wrote: > > 2) Change relevant code so that we only return a valid vmbuffer if we could > > do > >so without blocking / IO and, obviously, skip updating the VM if we > >

Re: meson/msys2 fails with plperl/Strawberry

2023-03-25 Thread Andres Freund
uot; [16:32:28.997] Checking if "libperl" : links: YES > I would expect the ld flags to be "-LC:/STRAWB~1/perl/lib/CORE -lperl532" You didn't say what they ended up as? > (Off topic peeve - one of the things I dislike about meson is that the > meson.build files are written in YA bespoke language). I don't really disagree. However, all the general purpose language using build etools I found were awful. And meson's language is a heck of a lot nicer than e.g. cmake's... Greetings, Andres Freund

Re: refactoring relation extension and BufferAlloc(), faster COPY

2023-03-24 Thread Andres Freund
Hi, On 2022-10-28 19:54:20 -0700, Andres Freund wrote: > I've done a fair bit of benchmarking of this patchset. For COPY it comes out > ahead everywhere. It's possible that there's a very small regression for > extremly IO miss heavy workloads, more below. > > > server &q

Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry

2023-03-24 Thread Andres Freund
om being a hot path. The xact functions are barely ever used. Compared to the cost of query evaluation the cost of iterating throught he subxacts is neglegible. Greetings, Andres Freund

hio.c does visibilitymap_pin()/IO while holding buffer lock

2023-03-24 Thread Andres Freund
only return a valid vmbuffer if we could do so without blocking / IO and, obviously, skip updating the VM if we couldn't get the buffer. Greetings, Andres Freund

Re: Make fop less verbose when building PDF

2023-03-24 Thread Andres Freund
Hi, On 2023-03-24 16:19:57 -0400, Tom Lane wrote: > Andres Freund writes: > > I just figured out that one can hide those. Unfortunately not at the > > commandline, but in "$HOME/.foprc" or /etc. > > > $ cat ~/.foprc > > LOGLEVEL=-Dorg.apache.commons.log

Re: Should we remove vacuum_defer_cleanup_age?

2023-03-24 Thread Andres Freund
Hi, On 2023-03-23 10:18:35 +0100, Daniel Gustafsson wrote: > > On 22 Mar 2023, at 18:00, Andres Freund wrote: > > > It wasn't actually that much work to write a patch to remove > > vacuum_defer_cleanup_age, see the attached. > > -and provide protection

Make fop less verbose when building PDF

2023-03-24 Thread Andres Freund
[1]. But the next two might be relevant? I don't immediately see a way that's not too gross (like redefining HOME when invoking fop) to set LOGLEVEL without editing .foprc. Perhaps we should add advice to do so to docguide.sgml? Greetings, Andres Freund [1] https://lists.apache.org/thread/yqkjzow3y8fpo9fc3hlbqb9fk49fonlf

Re: Transparent column encryption

2023-03-24 Thread Andres Freund
r isn't able to > enforce that anyway, so we could just prohibit specifying a nondefault > typmod for encrypted columns. Why not just use typmod for the underlying typmod? It doesn't seem like encrypted datums will need that? Or are you using it for something important there? Greetings, Andres Freund

Remove 'htmlhelp' documentat format (was meson documentation build open issues)

2023-03-24 Thread Andres Freund
Hi, On 2023-03-24 11:59:23 +0100, Peter Eisentraut wrote: > Another option here is to remove support for htmlhelp. That might actually be the best path - it certainly doesn't look like anybody has been actively using it. Or otherwise somebody would have complained about there not being any

Re: meson documentation build open issues

2023-03-24 Thread Andres Freund
Hi, On 2023-03-22 11:59:17 -0700, Andres Freund wrote: > Unless somebody sees a reason to wait, I am planning to commit: > meson: add install-{quiet, world} targets > meson: add install-{docs,doc-html,doc-man} targets > meson: make install_test_files more generic, rename to i

Re: POC: Lock updated tuples in tuple_update() and tuple_delete()

2023-03-23 Thread Andres Freund
Hi, An off-list conversation veered on-topic again. Reposting for posterity: On 2023-03-23 23:24:19 +0300, Alexander Korotkov wrote: > On Thu, Mar 23, 2023 at 8:06 PM Andres Freund wrote: > > I seriously doubt that solving this at the tuple locking level is the right > > th

Re: HOT chain validation in verify_heapam()

2023-03-23 Thread Andres Freund
Hi, On 2023-03-23 15:37:15 -0400, Robert Haas wrote: > On Wed, Mar 22, 2023 at 8:38 PM Andres Freund wrote: > > skink / valgrind reported in a while back and found another issue: > > > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink=2023-03-22%2021%3A53%3

Re: HOT chain validation in verify_heapam()

2023-03-23 Thread Andres Freund
Hi, On 2023-03-23 11:20:04 +0530, Himanshu Upadhyaya wrote: > On Thu, Mar 23, 2023 at 2:15 AM Andres Freund wrote: > > > > > Currently the new verify_heapam() follows ctid chains when XMAX_INVALID is > > set > > and expects to find an item it can derefere

Re: HOT chain validation in verify_heapam()

2023-03-23 Thread Andres Freund
Hi, On 2023-03-23 11:41:52 -0400, Robert Haas wrote: > On Wed, Mar 22, 2023 at 5:56 PM Andres Freund wrote: > > I also think it's not quite right that some of checks inside if > > (ItemIdIsRedirected()) continue in case of corruption, others don't. While > > there's a later

Re: POC: Lock updated tuples in tuple_update() and tuple_delete()

2023-03-23 Thread Andres Freund
Hi, On 2023-03-23 18:08:36 +0300, Alexander Korotkov wrote: > On Thu, Mar 23, 2023 at 3:30 AM Andres Freund wrote: > > On 2023-03-21 01:25:11 +0300, Alexander Korotkov wrote: > > > I'm going to push patchset v15 if no objections. > > > > Just saw that

Re: HOT chain validation in verify_heapam()

2023-03-22 Thread Andres Freund
Hi, On 2023-03-22 13:45:52 -0700, Andres Freund wrote: > On 2023-03-22 09:19:18 -0400, Robert Haas wrote: > > On Fri, Mar 17, 2023 at 8:31 AM Aleksander Alekseev > > wrote: > > > The patch needed a rebase due to a4f23f9b. PFA v12. > > > > I have committed thi

Re: POC: Lock updated tuples in tuple_update() and tuple_delete()

2023-03-22 Thread Andres Freund
> Reviewed-by: Aleksander Alekseev, Pavel Borisov, Vignesh C, Mason Sharp > Reviewed-by: Andres Freund, Chris Travers > --- > src/backend/executor/nodeModifyTable.c | 48 +++--- > 1 file changed, 35 insertions(+), 13 deletions(-) > > diff --git a/s

Re: HOT chain validation in verify_heapam()

2023-03-22 Thread Andres Freund
Hi, On 2023-03-22 14:56:22 -0700, Andres Freund wrote: > A patch addressing some, but not all, of those is attached. With that I don't > see any crashes or false-positives anymore. That patch missed that, as committed, the first if (ItemIdIsRedirected()) check sets lp_valid[n] = tru

Re: HOT chain validation in verify_heapam()

2023-03-22 Thread Andres Freund
Hi, On 2023-03-22 13:45:52 -0700, Andres Freund wrote: > On 2023-03-22 09:19:18 -0400, Robert Haas wrote: > > On Fri, Mar 17, 2023 at 8:31 AM Aleksander Alekseev > > wrote: > > > The patch needed a rebase due to a4f23f9b. PFA v12. > > > > I have committed thi

Re: HOT chain validation in verify_heapam()

2023-03-22 Thread Andres Freund
new verify_heapam() follows ctid chains when XMAX_INVALID is set and expects to find an item it can dereference - but I don't think that's something we can rely on: Afaics HOT pruning can break chains, but doesn't reset xmax. Greetings, Andres Freund

Re: Set arbitrary GUC options during initdb

2023-03-22 Thread Andres Freund
Hi, This commit unfortunately broke --wal-segsize. If I use a slightly larger than the default setting, I get: initdb --wal-segsize 64 somepath running bootstrap script ... 2023-03-22 13:06:41.282 PDT [639848] FATAL: "min_wal_size" must be at least twice "wal_segment_size"

Re: meson documentation build open issues

2023-03-22 Thread Andres Freund
Hi, On 2023-03-20 10:32:49 -0700, Andres Freund wrote: > On 2023-03-20 11:58:08 +0100, Peter Eisentraut wrote: > > Oh, this patch set grew quite quickly. ;-) > > Yep :) Unless somebody sees a reason to wait, I am planning to commit: meson: add install-{quiet, world} targe

Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)

2023-03-22 Thread Andres Freund
33 > +4{a, 4} 4 > + > +5{5} 5 > +\. > +SELECT * FROM check_ign_err; > + I suggest adding a few more tests: - COPY with a datatype error that can't be handled as a soft error - test documenting that COPY FORMAT BINARY is incompatible with IGNORE_DATATYPE_ERRORS - a soft error showing the error context - although that will require some care to avoid the function name + line in the output Greetings, Andres Freund

Re: CREATE DATABASE ... STRATEGY WAL_LOG issues

2023-03-22 Thread Andres Freund
On 2023-03-22 09:58:58 -0400, Robert Haas wrote: > On Wed, Mar 22, 2023 at 1:12 AM Andres Freund wrote: > > Patch with the two minimal fixes attached. As we don't know whether it's > > worth > > changing the strategy, the more minimal fixes seem more appropriate. > >

Re: Should we remove vacuum_defer_cleanup_age?

2023-03-22 Thread Andres Freund
Hi, On 2023-03-22 11:44:20 -0500, Justin Pryzby wrote: > On Sat, Mar 18, 2023 at 10:33:57AM +0100, Alvaro Herrera wrote: > > On 2023-Mar-17, Andres Freund wrote: > > > > > I started writing a test for vacuum_defer_cleanup_age while working on > > > the fix >

Re: CREATE DATABASE ... STRATEGY WAL_LOG issues

2023-03-21 Thread Andres Freund
Hi, On 2023-03-21 09:34:14 -0700, Andres Freund wrote: > On 2023-03-21 11:33:59 -0400, Robert Haas wrote: > > That feels like it would be slightly more rational behavior, > > but I'm not smart enough to guess whether anyone would actually be > > happier (or less happy) aft

Re: Save a few bytes in pg_attribute

2023-03-21 Thread Andres Freund
Hi, On 2023-03-21 21:02:08 +0100, Matthias van de Meent wrote: > On Tue, 21 Mar 2023 at 20:58, Andres Freund wrote: > > On 2023-03-21 20:20:40 +0100, Matthias van de Meent wrote: > > > Yes, attcacheoff is a tremendous performance boon in many cases. > > > > W

Re: Save a few bytes in pg_attribute

2023-03-21 Thread Andres Freund
s only really beneficial for fastgetattr(). Which conditions it's use more strictly - not only can there not be any NULLs before the accessed column, there may not be any NULLs in the tuple at all. Greetings, Andres Freund

Re: Save a few bytes in pg_attribute

2023-03-21 Thread Andres Freund
Hi, On 2023-03-21 20:20:40 +0100, Matthias van de Meent wrote: > On Tue, 21 Mar 2023 at 19:55, Tom Lane wrote: > > > > Andres Freund writes: > > > FWIW, I think we should consider getting rid of attcacheoff. I doubt it's > > > worth its weight these days, b

Re: Transparent column encryption

2023-03-21 Thread Andres Freund
Hi, On 2023-03-21 18:05:15 +0100, Peter Eisentraut wrote: > On 16.03.23 17:36, Andres Freund wrote: > > Maybe a daft question, but why do we need a separate type and typmod for > > encrypted columns? Why isn't the fact that the column is encrypted exactly > > one >

Re: Save a few bytes in pg_attribute

2023-03-21 Thread Andres Freund
Hi, On 2023-03-21 18:15:40 +0100, Peter Eisentraut wrote: > On 21.03.23 17:43, Andres Freund wrote: > > > The context of my message was to do the proposed change for PG16 to buy > > > back > > > a few bytes that are being added by another feature > > How much

Re: Save a few bytes in pg_attribute

2023-03-21 Thread Andres Freund
Hi, On 2023-03-21 17:36:48 +0100, Peter Eisentraut wrote: > On 21.03.23 00:51, Tom Lane wrote: > > Andres Freund writes: > > > On 2023-03-20 10:37:36 -0400, Tom Lane wrote: > > > > I agree that attinhcount could be narrowed, but I have some concern > > >

Re: CREATE DATABASE ... STRATEGY WAL_LOG issues

2023-03-21 Thread Andres Freund
Hi, On 2023-03-21 11:33:59 -0400, Robert Haas wrote: > On Tue, Mar 21, 2023 at 3:01 AM Andres Freund wrote: > > Easy enough to fix and shows clear improvement. One thing I wonder is if > > it's > > worth moving the strategies up one level? Probaly not, but ... > &g

CREATE DATABASE ... STRATEGY WAL_LOG issues

2023-03-21 Thread Andres Freund
, therefore requiring a read of a block guaranteed to be zero Easy enough to fix and shows clear improvement. One thing I wonder is if it's worth moving the strategies up one level? Probaly not, but ... Greetings, Andres Freund

Re: Track IO times in pg_stat_io

2023-03-20 Thread Andres Freund
023 10:41:51 -0500 Subject: [PATCH v6 1/2] Track IO times in pg_stat_io Add IO timing for reads, writes, extends, and fsyncs to pg_stat_io. Reviewed-by: Bertrand Drouvot Reviewed-by: Andres Freund Discussion: https://www.postgresql.org/message-id/flat/CAAKRu_ay5iKmnbXZ3DsauViF3eMxu4m1oNnJXqV_HyqYe

Re: Save a few bytes in pg_attribute

2023-03-20 Thread Andres Freund
dering would save 4 bytes from the fixed portion. attndims seems like another good candidate to shrink. Greetings, Andres Freund

Re: Save a few bytes in pg_attribute

2023-03-20 Thread Andres Freund
. Greetings, Andres Freund

Re: meson documentation build open issues

2023-03-20 Thread Andres Freund
Hi, On 2023-03-19 19:33:38 -0700, Andres Freund wrote: > I think we can make the docs build in parallel and incrementally, by building > the different parts of the docs in parallel, using --stringparam rootid, > e.g. building each 'part' separately. > > A very very rough

Re: meson documentation build open issues

2023-03-20 Thread Andres Freund
rrectly for the standalone file. Greetings, Andres Freund

Re: meson documentation build open issues

2023-03-19 Thread Andres Freund
Hi, On 2023-03-15 20:55:33 -0700, Andres Freund wrote: > WIP patch for that attached. There's now > install-doc-man > install-doc-html > run targets and a > install-docs > alias target. > > > I did end up getting stuck when hacking on this, and ended up addin

Re: buildfarm + meson

2023-03-18 Thread Andres Freund
Hi, On 2023-03-18 17:53:38 -0400, Andrew Dunstan wrote: > On 2023-03-11 Sa 16:25, Andres Freund wrote: > > Hi, > > > > On 2023-03-09 18:31:10 -0500, Andrew Dunstan wrote: > > > Another thing: the test for uuid.h is too strict. On Fedora 36 the OSSP > > &

Re: gcc 13 warnings

2023-03-17 Thread Andres Freund
abled if /DEBUG is specified. I guess we can live with that. Greetings, Andres Freund

Should we remove vacuum_defer_cleanup_age?

2023-03-17 Thread Andres Freund
much hot_standby_feedback can hold the horizon back. I don't think I have the cycles to push this through in the next weeks, but if we agree removing vacuum_defer_cleanup_age is a good idea, it seems like a good idea to mark it as deprecated in 16? Greetings, Andres Freund

Re: Making background psql nicer to use in tap tests

2023-03-17 Thread Andres Freund
t; > that worse. > > > > Yeah, I can go along with that. Cool - I'd prefer a separate file. I do find Cluster.pm somewhat unwieldy at this point, and I susect that we'll end up with additional helpers around BackgroundPsql. Greetings, Andres Freund

Re: slapd logs to syslog during tests

2023-03-17 Thread Andres Freund
Hi, On 2023-03-16 22:43:17 -0700, Andres Freund wrote: > So unless somebody has a better idea, I'm gonna replace 'logfile-only on' with > 'loglevel 0' for now. I also am open to reverting and trying again tomorrow. Did that now. I used the commandline option -s0 instead of logl

Re: slapd logs to syslog during tests

2023-03-16 Thread Andres Freund
Hi, On 2023-03-16 23:52:04 -0400, Tom Lane wrote: > Andres Freund writes: > > I got sidetracked trying to make slapd stop any and all syslog access, but > > it > > doesn't look like that's possible. But working on commiting the logfile-only > > approach now. Plannin

Re: slapd logs to syslog during tests

2023-03-16 Thread Andres Freund
ess somebody protests very soon. Greetings, Andres Freund

Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?

2023-03-16 Thread Andres Freund
Avoiding warnings on a > 10 year old compiler a) is a waste of time b) unnecessarily requires making our code uglier. Greetings, Andres Freund

Re: More weird compiler warnings

2023-03-16 Thread Andres Freund
On 2023-03-16 14:31:37 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2022-03-26 13:55:49 -0700, Andres Freund wrote: > >> On 2022-03-26 16:23:26 -0400, Tom Lane wrote: > >>> but I'm wondering if we could silence the warning by changing the loop > >&g

Re: gcc 13 warnings

2023-03-16 Thread Andres Freund
Hi, On 2023-03-16 13:54:29 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2023-03-16 12:10:27 -0400, Tom Lane wrote: > >> It wouldn't be entirely surprising if meson is selecting some -W > >> switches that the configure script doesn't ... but I don't know &g

Re: gcc 13 warnings

2023-03-16 Thread Andres Freund
Hi, On 2023-03-16 10:05:06 -0700, Andres Freund wrote: > I think it's just that meson defaults to -O3 (fwiw, I see substantial gains of > that over -O2). I see such warnings with autoconf as well if I make it use > -O3. WRT: In file included from /home/andres/src/postgresql/src/inclu

Re: More weird compiler warnings

2023-03-16 Thread Andres Freund
Hi, On 2022-03-26 13:55:49 -0700, Andres Freund wrote: > On 2022-03-26 16:23:26 -0400, Tom Lane wrote: > > serinus' experimental gcc whines about a few places in network.c: > > > > ../../../../../pgsql/src/backend/utils/adt/network.c: In function 'inetnot': > > ../..

Re: gcc 13 warnings

2023-03-16 Thread Andres Freund
know > where to check or change that. I think it's just that meson defaults to -O3 (fwiw, I see substantial gains of that over -O2). I see such warnings with autoconf as well if I make it use -O3. I think some of these are stemming from https://postgr.es/m/20230204130708.pta7pjc4dvu225ey%40alap3.anarazel.de Greetings, Andres Freund

Re: Transparent column encryption

2023-03-16 Thread Andres Freund
Hi, On 2023-03-16 11:26:46 +0100, Peter Eisentraut wrote: > On 13.03.23 22:11, Andres Freund wrote: > > > It adds branches, and it makes tupledescs wider. In tight spots, such as > > > printtup, that can hurt, even if the branches aren't ever entered. > > In

Re: meson documentation build open issues

2023-03-15 Thread Andres Freund
ing css support for nochunk and support for the website style for htmlhelp and nochunk, as well as obsoleting the need for copying the css files... But perhaps that's a bit too much. Greetings, Andres Freund >From e604a5c5acdaa840ede0c83205c9799a9edb2630 Mon Sep 17 00:00:00 2001 From: Andres Freund

Re: pkg-config Requires.private entries should be comma-separated

2023-03-15 Thread Andres Freund
gt; https://github.com/pkgconf/pkgconf/blob/master/libpkgconf/dependency.c#L286 > > I think for consistency we should change the make build to use commas > anyway. See attached patch. Makes sense. Greetings, Andres Freund

Re: Combine pg_walinspect till_end_of_wal functions with others

2023-03-14 Thread Andres Freund
Hi, On 2023-03-15 09:56:10 +0900, Michael Paquier wrote: > On Tue, Mar 14, 2023 at 02:54:40PM -0700, Andres Freund wrote: > > Object description > > --- > > function pg_get_wal_record_info(p

Re: Making background psql nicer to use in tap tests

2023-03-14 Thread Andres Freund
Hi, On 2023-03-14 21:24:32 +0100, Daniel Gustafsson wrote: > > On 31 Jan 2023, at 01:00, Andres Freund wrote: > > > I've hacked some on this. I first tried to just introduce a few helper > > functions in Cluster.pm, but that ended up being awkward. So I bit the > >

Re: Track IO times in pg_stat_io

2023-03-14 Thread Andres Freund
Hi, On 2023-03-09 11:50:38 -0500, Melanie Plageman wrote: > On Tue, Mar 7, 2023 at 1:39 PM Andres Freund wrote: > > On 2023-03-06 11:30:13 -0500, Melanie Plageman wrote: > > > > As pgstat_bktype_io_stats_valid() is called only in Assert(), I think > > &g

Re: Combine pg_walinspect till_end_of_wal functions with others

2023-03-14 Thread Andres Freund
) (5 rows) -- Make sure checkpoints don't interfere with the test. Looks like it's missing an ORDER BY. Greetings, Andres Freund

DROP DATABASE is interruptible

2023-03-14 Thread Andres Freund
: /* Close all smgr fds in all backends. */ WaitForProcSignalBarrier(EmitProcSignalBarrier(PROCSIGNAL_BARRIER_SMGRRELEASE)); ISTM that at the very least dropdb() needs to internally commit *before* dropping buffers - after that point the database is corrupt. Greetings, Andres Freund

Re: ICU 54 and earlier are too dangerous

2023-03-13 Thread Andres Freund
/unicode-org.atlassian.net/browse/ICU-10823 - I guess the issue tracker was migrated at some point or such... If indeed 2014 is the correct year of release, then it might be ok to increase the minimum version... Greetings, Andres Freund

Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED

2023-03-13 Thread Andres Freund
On 2023-03-14 09:29:56 +0900, Michael Paquier wrote: > The emulation of waitpid() for WIN32 is now in postmaster.c. Could it > make sense for some of the frontend code to be able to rely on that, > as well? Please not as part of this bugfix. It's intricately tied to postmaster.c specific code,

Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED

2023-03-13 Thread Andres Freund
uct a reproduction of the case, but it seems to me that > the race condition is not impossible here. I suspect the issue could be made much more likely by adding a sleep before the pg_queue_signal(SIGCHLD) in pgwin32_deadchild_callback(). Greetings, Andres Freund

Re: Microsecond-based timeouts

2023-03-13 Thread Andres Freund
> I suppose we could also consider an interface with an absolute timeout > instead, and then stop thinking about the units so much. That seesm pretty awful to use, and we'd just end up with the same question at the callsites. Greetings, Andres Freund

Re: meson: Non-feature feature options

2023-03-13 Thread Andres Freund
Hi, On 2023-03-13 23:46:41 +0300, Nazir Bilal Yavuz wrote: > Thanks for the patch, I understand the problem now and your patch fixes this. Pushed the patch. Greetings, Andres Freund

Re: Transparent column encryption

2023-03-13 Thread Andres Freund
Hi, On 2023-03-13 13:41:19 -0700, Andres Freund wrote: > On 2023-03-13 21:22:29 +0100, Peter Eisentraut wrote: > > On 12.03.23 01:11, Andres Freund wrote: > > > Have you done benchmarks of some simple workloads to verify this doesn't > > > cause > > >

Re: Transparent column encryption

2023-03-13 Thread Andres Freund
Hi, On 2023-03-13 21:22:29 +0100, Peter Eisentraut wrote: > On 12.03.23 01:11, Andres Freund wrote: > > Have you done benchmarks of some simple workloads to verify this doesn't > > cause > > slowdowns (when not using encryption, obviously)? printtup.c is a > > perfor

Re: meson: Non-feature feature options

2023-03-13 Thread Andres Freund
are not present? > > Yes, I tested again and it is working as expected on my end. It > shouldn't fail like that unless the 'ssl' option is set to 'openssl'. > Is it possible that it has been set to 'openssl' without you noticing? It worked for the dependency() path, but not the cc.find_library() path. See the patch I just sent. Greetings, Andres Freund

Re: meson: Non-feature feature options

2023-03-13 Thread Andres Freund
l_int wouldn't exist. Maybe something like the attached? Greetings, Andres Freund >From b8bd0200667bac16674e40e769a9fb4bc4f54306 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Mon, 13 Mar 2023 13:11:37 -0700 Subject: [PATCH v1] meson: fix openssl detection issues in 6a30027 Reported-by: N

Re: unsafe_tests module

2023-03-11 Thread Andres Freund
ke a good idea to me. Greetings, Andres Freund

Re: Transparent column encryption

2023-03-11 Thread Andres Freund
hey return multiple columns. And making tupledescs even wider is likely to have some price, both due to the increase in memory usage, and due to the lower cache density - and that's code where we're already hurting noticeably. Greetings, Andres Freund

Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE

2023-03-11 Thread Andres Freund
Hi, On 2023-03-11 15:34:55 -0800, Mark Dilger wrote: > > On Mar 11, 2023, at 3:22 PM, Andres Freund wrote: > > > > Something like the attached. > > I like that your patch doesn't make the test longer. I assume you've already > run the tests and that it works. I

slapd logs to syslog during tests

2023-03-11 Thread Andres Freund
? That still leaves a few logline, from before the config file parsing, but it's a lot better than all requests getting logged. Obviously I also could reconfigure syslog to just filter this stuff, but it seems that the tests shouldn't spam like that. Greetings, Andres Freund

Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE

2023-03-11 Thread Andres Freund
r 500ms. > > I don't recall the reasoning. Feel free to optimize the tests. Something like the attached. I don't know enough perl to know how to interpolate something like use constant ROWCOUNT => 17; so I just made it a variable. Greetings, Andres Freund >From a01e1481505e74097112c0ea3

Re: buildfarm + meson

2023-03-11 Thread Andres Freund
gt; do) Yea, that was just wrong. It happened to work on debian and a few other OSs, but ossp's .pc puts whatever the right directory is into the include path. Pushed the fairly obvious fix. Greetings, Andres Freund

Re: Dead code in ps_status.c

2023-03-10 Thread Andres Freund
ve the following in my ~/.ssh/config to work around that: Host gcc210.fsffrance.org PubkeyAcceptedKeyTypes +ssh-rsa KexAlgorithms +diffie-hellman-group1-sha1 Host gcc211.fsffrance.org PubkeyAcceptedKeyTypes +ssh-rsa Greetings, Andres Freund

Re: cpluspluscheck vs ICU

2023-03-10 Thread Andres Freund
Hi, On 2023-03-10 19:37:27 -0800, Andres Freund wrote: > On 2022-03-23 08:56:17 -0700, Andres Freund wrote: > > On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote: > > > On 3/22/22 22:23, Andres Freund wrote: > > > That only helps when running the CI/cfbot setup. Fixing

Re: cpluspluscheck vs ICU

2023-03-10 Thread Andres Freund
Hi, On 2022-03-23 08:56:17 -0700, Andres Freund wrote: > On 2022-03-23 08:19:38 -0400, Andrew Dunstan wrote: > > On 3/22/22 22:23, Andres Freund wrote: > > That only helps when running the CI/cfbot setup. Fixing it for other > > (manual or buildfarm) users would be nice

Re: buildfarm + meson

2023-03-10 Thread Andres Freund
Hi, On 2023-03-09 11:55:57 -0800, Andres Freund wrote: > On 2023-03-09 14:47:36 -0500, Andrew Dunstan wrote: > > On 2023-03-09 Th 08:28, Andrew Dunstan wrote: > > > At this stage I think I'm prepared to turn this loose on a couple of my > > > buildfarm animal

Re: buildfarm + meson

2023-03-09 Thread Andres Freund
at, but the make situation is overly complicated. I don't really want to emulate having randomly differing database names just because a test is in contrib/ rather than src/. Greetings, Andres Freund

Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?)

2023-03-09 Thread Andres Freund
Hi, On 2023-03-09 06:51:31 -0600, Justin Pryzby wrote: > On Tue, Mar 07, 2023 at 10:18:44AM -0800, Andres Freund wrote: > > Hi, > > > > On 2023-03-06 15:21:14 -0500, Melanie Plageman wrote: > > > Good point. Attached is what you suggested. I committed the transacti

Re: meson vs make: missing/inconsistent ENV

2023-03-08 Thread Andres Freund
Hi, On 2023-03-09 09:36:52 +0900, Michael Paquier wrote: > On Sun, Feb 26, 2023 at 03:21:04PM -0800, Andres Freund wrote: > > On 2023-02-26 16:52:39 -0600, Justin Pryzby wrote: > >> Also, e6927270c added ZSTD to src/bin/pg_basebackup/meson.build, but > >> it's

Re: Track IO times in pg_stat_io

2023-03-08 Thread Andres Freund
Hi, On 2023-03-08 12:55:34 +0100, Drouvot, Bertrand wrote: > On 3/7/23 7:47 PM, Andres Freund wrote: > > On 2023-03-07 13:43:28 -0500, Melanie Plageman wrote: > > > > Now I've a second thought: what do you think about resetting the > > > > related number > &

Re: Should vacuum process config file reload more often

2023-03-08 Thread Andres Freund
ange and honoring it for future attempts to grow the memory > and on future passes through the heap would be plenty. > > All that said, don't let these suggestions get in the way of committing > this. Just having the ability to tweak cost parameters would be a win. Nobody said anything about it not being useful to react to m_w_m changes, just that it's not required to make some progress . So I really don't understand what the point of your comment is. Greetings, Andres Freund

Re: BUG: Postgres 14 + vacuum_defer_cleanup_age + FOR UPDATE + UPDATE

2023-03-08 Thread Andres Freund
Hi, On 2023-02-06 13:02:05 -0800, Andres Freund wrote: > I didn't quite feel confident pushing a fix for this just before a minor > release, so I'll push once the minor releases are tagged. A quite minimal fix > to GetFullRecentGlobalXmin() in 12-13 (returning FirstNormalTransactionId i

Re: Non-superuser subscription owners

2023-03-08 Thread Andres Freund
Hi, On 2023-02-07 16:56:55 -0500, Robert Haas wrote: > On Wed, Feb 1, 2023 at 4:02 PM Andres Freund wrote: > > > + /* Is the use of a password mandatory? */ > > > + must_use_password = MySubscription->passwordrequired && > > > +

Re: Add shared buffer hits to pg_stat_io

2023-03-08 Thread Andres Freund
a simple nested loop self-join, that'll prevent the page being evicted, because it'll still be pinned on the outer side, while generating hits on the inner side. Greetings, Andres Freund

Re: buildfarm + meson

2023-03-08 Thread Andres Freund
Hi, On 2023-03-02 17:35:26 -0500, Andrew Dunstan wrote: > On 2023-03-02 Th 17:06, Andres Freund wrote: > > Hi > > > > On 2023-03-02 17:00:47 -0500, Andrew Dunstan wrote: > > > On 2023-03-01 We 16:32, Andres Freund wrote: > > > > > This is now working

Re: buildfarm + meson

2023-03-08 Thread Andres Freund
Hi, On 2023-03-08 09:41:57 -0500, Andrew Dunstan wrote: > On 2023-03-08 We 08:57, Andrew Dunstan wrote: > > On 2023-03-07 Tu 20:29, Andres Freund wrote: > > > On 2023-03-07 15:47:54 -0500, Andrew Dunstan wrote: > > > Here's a prototype for that. > > > > &

Re: buildfarm + meson

2023-03-07 Thread Andres Freund
On 2023-03-07 18:26:21 -0800, Andres Freund wrote: > On 2023-02-23 06:27:23 -0500, Andrew Dunstan wrote: > > Yeah. For touch I think we can probably just get rid of this line in the > > root meson.build: > > > > touch = find_program('touch', native: true) > >

Re: buildfarm + meson

2023-03-07 Thread Andres Freund
eplace with something else - tar, gzip - just for tests I'm not sure it's worth working on not requiring those. There's also flex, bison, perl, but those will stay a hard requirement for a while longer... :) Greetings, Andres Freund >From 564092bfb4c108c387cac3562a7dbad8c3126fea Mon Sep 17 00

Re: buildfarm + meson

2023-03-07 Thread Andres Freund
Hi, On 2023-03-07 15:47:54 -0500, Andrew Dunstan wrote: > On 2023-03-07 Tu 14:37, Andres Freund wrote: > > The failures are like this: > > > > +ERROR: extension "dummy_index_am" is not available > > +DETAIL: Could not open extension control file > >

Re: POC: Lock updated tuples in tuple_update() and tuple_delete()

2023-03-07 Thread Andres Freund
actually improves. Introducing even infrastructure to get a not that big win, in a not particularly interesting, extreme, workload... What is motivating this? Greetings, Andres Freund

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

2023-03-07 Thread Andres Freund
Hi, On 2023-03-07 08:22:45 +0530, Amit Kapila wrote: > On Tue, Mar 7, 2023 at 1:34 AM Andres Freund wrote: > > I think even as-is it's reasonable to just use it. The sequential scan > > approach is O(N^2), which, uh, is not good. And having an index over > > thousands

Re: Add shared buffer hits to pg_stat_io

2023-03-07 Thread Andres Freund
Hi, LGTM. The only comment I have is that a small test wouldn't hurt... Compared to the other things it should be fairly easy... Greetings, Andres Freund

Re: buildfarm + meson

2023-03-07 Thread Andres Freund
Hi, On 2023-03-01 13:32:58 -0800, Andres Freund wrote: > On 2023-03-01 16:21:32 -0500, Andrew Dunstan wrote: > > Perhaps the latest version will be more to your taste. > > I'll check it out. A simple conversion from an existing config failed with: Can't use an undefined va

Re: Track IO times in pg_stat_io

2023-03-07 Thread Andres Freund
n basis. I think we simply shouldn't do anything here. This is a pre-existing issue. I also think that loosing stats when turning track_io_timing on/off would not be helpful. Greetings, Andres Freund

<    9   10   11   12   13   14   15   16   17   18   >