Hi hackers,
Currently, pgp_sym_decrypt_text and pgp_pub_decrypt_text doesn't
enforce database encoding validation even when returning text. This
patch adds validation and dedicated tests to verify its
effectiveness. Additionally, some existing unit tests were moved to
the new tests as they failed
On Fri, Feb 9, 2024 at 5:34 PM cary huang wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, failed
> Implements feature: not tested
> Spec compliant: not tested
> Documentation:not tested
>
> Hello
>
Hi hackers,
I'd like to bring to your attention that I recently identified some
functions in pgcrypto that are using PG_GETARG functions in a way that
doesn't match the expected function signature of the stored
procedures. This patch proposes a solution to address these
inconsistencies and ensure
On Tue, Feb 13, 2024 at 7:08 PM Michael Paquier wrote:
>
> On Tue, Feb 13, 2024 at 05:36:36PM +0900, Michael Paquier wrote:
> > You've indeed grabbed some historical inconsistencies here. Please
> > note that your patch has reversed diffs (for example, the SQL
> > definition of pgp_sym_encrypt_by
Hi Jian,
Thanks for your comments, a new version is attached.
Thanks,
Shihao
On Fri, Nov 10, 2023 at 9:59 AM jian he wrote:
> On Wed, Nov 1, 2023 at 10:30 AM shihao zhong
> wrote:
> >
> > Thank you for your feedback on my previous patch. I have fixed the issue
> and att
I have reviewed the changes and it looks fine.
The new status of this patch is: Ready for Committer
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:tested, passed
I took a look for this commit, it looks correct to me
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
That looks correct for me
The new status of this patch is: Ready for Committ
I do like the idea that we should keep the set and the altar system with
the same behavior. But one thing I am worried about is the typo detected
here because I usually make that type of mistake myself. I believe we
should have an extra log to explicitly tell the user this is a `custom
variable` gu
Thanks for the answer. The code looks good to me.
Thanks,
Shihao
On Thu, Oct 19, 2023 at 12:00 PM Tom Lane wrote:
> shihao zhong writes:
> > I do like the idea that we should keep the set and the altar system with
> > the same behavior. But one thing I am worried about is th
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: not tested
Documentation:tested, passed
It seems like people have been talking about this problem since 2010
(ht
Hi hackers,
I hope this email finds you well.
I noticed that the CREATE/ALTER TABLE document does not mention that
EXCLUDE can accept a collation. I created a documentation fix for this
issue, and I have attached it to this email.
Please let me know if you have any questions or concerns.
Thanks
On Tue, Oct 31, 2023 at 9:07 PM Tom Lane wrote:
> shihao zhong writes:
> > I noticed that the CREATE/ALTER TABLE document does not mention that
> > EXCLUDE can accept a collation. I created a documentation fix for this
> > issue, and I have attached it to this email.
I think this is duplicate with https://commitfest.postgresql.org/45/4637/
The new status of this patch is: Waiting on Author
On Wed, Nov 1, 2023 at 7:59 AM Aleksander Alekseev
wrote:
> Hi,
>
> > I didn't see any recent mentions in the archives, so I'll volunteer to
> > be CF manager for 2023-11.
>
> I would love to help with that if you need.
>
> --
> Thanks,
>
Shihao
That looks good to me!
The new status of this patch is: Ready for Committer
16 matches
Mail list logo