Re: Extensible storage manager API - SMGR hook Redux

2024-03-15 Thread Aleksander Alekseev
Hi, > Thought I would show off what is possible with this patchset. > > [...] Just wanted to let you know that cfbot doesn't seem to be entirely happy with the patch [1]. Please consider submitting an updated version. Best regards, Aleksander Alekseev (wearing co-CFM hat) [1]:

Re: Extensible storage manager API - SMGR hook Redux

2024-01-12 Thread Tristan Partin
Thought I would show off what is possible with this patchset. Heikki, a couple of months ago in our internal Slack, said: [I would like] a debugging tool that checks that we're not missing any fsyncs. I bumped into a few missing fsync bugs with unlogged tables lately and a tool like that

Re: Extensible storage manager API - SMGR hook Redux

2023-12-04 Thread Matthias van de Meent
On Mon, 4 Dec 2023 at 22:03, Kirill Reshke wrote: > > On Mon, 4 Dec 2023 at 22:21, Matthias van de Meent > wrote: >> >> On Mon, 4 Dec 2023 at 17:51, Kirill Reshke wrote: >> > >> > So, 0002 patch uses the `get_tablespace` function, which searches Catalog >> > to tablespace SMGR id. I wonder

Re: Extensible storage manager API - SMGR hook Redux

2023-12-04 Thread Kirill Reshke
On Mon, 4 Dec 2023 at 22:21, Matthias van de Meent < boekewurm+postg...@gmail.com> wrote: > On Mon, 4 Dec 2023 at 17:51, Kirill Reshke wrote: > > > > So, 0002 patch uses the `get_tablespace` function, which searches > Catalog to tablespace SMGR id. I wonder how `smgr_redo` would work with it? >

Re: Extensible storage manager API - SMGR hook Redux

2023-12-04 Thread Matthias van de Meent
On Mon, 4 Dec 2023 at 17:51, Kirill Reshke wrote: > > So, 0002 patch uses the `get_tablespace` function, which searches Catalog to > tablespace SMGR id. I wonder how `smgr_redo` would work with it? That's a very good point I hadn't considered in detail yet. Quite clearly, the current code is

Fwd: Extensible storage manager API - SMGR hook Redux

2023-12-04 Thread Kirill Reshke
Sorry for double-posting, I accidentally replied to Matthias, not the mailing list :( -- Forwarded message - From: Kirill Reshke Date: Mon, 4 Dec 2023 at 19:46 Subject: Re: Extensible storage manager API - SMGR hook Redux To: Matthias van de Meent Hi! On Fri, 30 Jun 2023

Re: Extensible storage manager API - SMGR hook Redux

2023-09-19 Thread Tristan Partin
Found these warnings while compiling while only 0001 is applied. [1166/2337] Compiling C object src/backend/postgres_lib.a.p/storage_smgr_md.c.o ../src/backend/storage/smgr/md.c: In function ‘mdexists’: ../src/backend/storage/smgr/md.c:224:28: warning: passing argument 1 of ‘mdopenfork’ from

Re: Extensible storage manager API - SMGR hook Redux

2023-07-11 Thread Tristan Partin
> Subject: [PATCH v1 1/2] Expose f_smgr to extensions for manual implementation >From what I can see, all the md* APIs that were exposed in md.h can now be made static in md.c. The only other references to those APIs were in smgr.c. > Subject: [PATCH v1 2/2] Prototype: Allow tablespaces to

Re: Extensible storage manager API - SMGR hook Redux

2023-06-30 Thread Andres Freund
Hi, On 2023-06-30 14:26:44 +0200, Matthias van de Meent wrote: > diff --git a/src/backend/postmaster/postmaster.c > b/src/backend/postmaster/postmaster.c > index 4c49393fc5..8685b9fde6 100644 > --- a/src/backend/postmaster/postmaster.c > +++ b/src/backend/postmaster/postmaster.c > @@ -1002,6

Extensible storage manager API - SMGR hook Redux

2023-06-30 Thread Matthias van de Meent
Hi hackers, At Neon, we've been working on removing the file system dependency from PostgreSQL and replacing it with a distributed storage layer. For now, we've seen most success in this by replacing the implementation of the smgr API, but it did require some core modifications like those