Re: HOT chain bug in latestRemovedXid calculation

2020-12-30 Thread Peter Geoghegan
On Mon, Dec 28, 2020 at 9:49 PM Peter Geoghegan wrote: > I would like to commit this patch to v12, the first version that did > this process during original execution rather than in REDO routines. > It seems worth keeping the back branches in sync here. I suspect that > the old approach used prior

Re: HOT chain bug in latestRemovedXid calculation

2020-12-28 Thread Peter Geoghegan
On Tue, Dec 22, 2020 at 9:52 AM Peter Geoghegan wrote: > ISTM that heap_compute_xid_horizon_for_tuples() calculates > latestRemovedXid for index deletion callers without sufficient care. > The function only follows line pointer redirects, which is necessary > but not sufficient to visit all releva

HOT chain bug in latestRemovedXid calculation

2020-12-22 Thread Peter Geoghegan
ISTM that heap_compute_xid_horizon_for_tuples() calculates latestRemovedXid for index deletion callers without sufficient care. The function only follows line pointer redirects, which is necessary but not sufficient to visit all relevant heap tuple headers -- it also needs to traverse HOT chains, b