Re: More parallel pg_dump bogosities

2018-08-28 Thread Tom Lane
Alvaro Herrera writes: > On 2018-Aug-28, Tom Lane wrote: >> Doesn't pg_backup_archiver.c's identify_locking_dependencies() need to >> treat POLICY and ROW SECURITY items as requiring exclusive lock on >> the referenced table? Those commands definitely acquire >> AccessExclusiveLock in a quick tes

Re: More parallel pg_dump bogosities

2018-08-28 Thread Alvaro Herrera
On 2018-Aug-28, Tom Lane wrote: > ... just when you thought it was safe to go back in the water ... > > Doesn't pg_backup_archiver.c's identify_locking_dependencies() need to > treat POLICY and ROW SECURITY items as requiring exclusive lock on > the referenced table? Those commands definitely ac

Re: More parallel pg_dump bogosities

2018-08-28 Thread Tom Lane
... just when you thought it was safe to go back in the water ... Doesn't pg_backup_archiver.c's identify_locking_dependencies() need to treat POLICY and ROW SECURITY items as requiring exclusive lock on the referenced table? Those commands definitely acquire AccessExclusiveLock in a quick test.

Re: More parallel pg_dump bogosities

2018-08-27 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> And lastly, the ROW SECURITY items are ready because they are not marked > >> with any dependency at all, none, nada. This seems bad. In principle > >> it could mean that parallel

Re: More parallel pg_dump bogosities

2018-08-27 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> And lastly, the ROW SECURITY items are ready because they are not marked >> with any dependency at all, none, nada. This seems bad. In principle >> it could mean that parallel restore would try to emit "ALTER TABLE ENABLE >> ROW L

Re: More parallel pg_dump bogosities

2018-08-27 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > So I started poking at the idea of sorting by size during parallel > restore instead of sorting pg_dump's TOC that way. While investigating > just where to do that, I discovered that, using the regression database > as test case, restore_toc_ent

More parallel pg_dump bogosities

2018-08-27 Thread Tom Lane
So I started poking at the idea of sorting by size during parallel restore instead of sorting pg_dump's TOC that way. While investigating just where to do that, I discovered that, using the regression database as test case, restore_toc_entries_parallel() finds these objects to be *immediately* rea