Re: new option to allow pg_rewind to run without full_page_writes

2022-11-07 Thread Andres Freund
Hi, On 2022-11-08 00:07:09 +0100, Jérémie Grauer wrote: > On 06/11/2022 03:38, Andres Freund wrote: > > Hi, > > > > On 2022-11-03 16:54:13 +0100, Jérémie Grauer wrote: > > > Currently pg_rewind refuses to run if full_page_writes is off. This is to > > > prevent it to run into a torn page during

Re: new option to allow pg_rewind to run without full_page_writes

2022-11-07 Thread Thomas Munro
On Tue, Nov 8, 2022 at 12:07 PM Jérémie Grauer wrote: > On 06/11/2022 03:38, Andres Freund wrote: > > On 2022-11-03 16:54:13 +0100, Jérémie Grauer wrote: > >> Currently pg_rewind refuses to run if full_page_writes is off. This is to > >> prevent it to run into a torn page during operation. > >> >

Re: new option to allow pg_rewind to run without full_page_writes

2022-11-07 Thread Jérémie Grauer
Hello, First, thank you for reviewing. ZFS writes files in increment of its configured recordsize for the current filesystem dataset. So with a recordsize configured to be a multiple of 8K, you can't get torn pages on writes, that's why full_page_writes can be safely deactivated on ZFS

Re: new option to allow pg_rewind to run without full_page_writes

2022-11-05 Thread Andres Freund
Hi, On 2022-11-03 16:54:13 +0100, Jérémie Grauer wrote: > Currently pg_rewind refuses to run if full_page_writes is off. This is to > prevent it to run into a torn page during operation. > > This is usually a good call, but some file systems like ZFS are naturally > immune to torn page (maybe

new option to allow pg_rewind to run without full_page_writes

2022-11-03 Thread Jérémie Grauer
Hello, Currently pg_rewind refuses to run if full_page_writes is off. This is to prevent it to run into a torn page during operation. This is usually a good call, but some file systems like ZFS are naturally immune to torn page (maybe btrfs too, but I don't know for sure for this one).