Re: pg_upgrade and cross-library upgrades

2023-07-07 Thread Daniel Gustafsson
> On 6 Jul 2023, at 02:19, Michael Paquier wrote: > On Wed, Jul 05, 2023 at 07:03:56AM -0400, Tom Lane wrote: >> Not entirely sure this is worth the effort. > > I am not sure either.. I can't see off the cuff that it would bring better test coverage or find bugs relative to the effort of making

Re: pg_upgrade and cross-library upgrades

2023-07-05 Thread Michael Paquier
On Wed, Jul 05, 2023 at 07:03:56AM -0400, Tom Lane wrote: > Alvaro Herrera writes: > > 002_pg_upgrade.pl can test for presence or absence of pgcrypto by > > grepping pg_config --configure for --with-ssl or --with-openssl. If the > > old cluster has it but the new doesn't, we must drop the > > con

Re: pg_upgrade and cross-library upgrades

2023-07-05 Thread Tom Lane
Alvaro Herrera writes: > 002_pg_upgrade.pl can test for presence or absence of pgcrypto by > grepping pg_config --configure for --with-ssl or --with-openssl. If the > old cluster has it but the new doesn't, we must drop the > contrib_regression_pgcrypto database. Hmm, but you'd also need code to

Re: pg_upgrade and cross-library upgrades

2023-07-05 Thread Alvaro Herrera
On 2023-Jul-05, Michael Paquier wrote: > The same thing as HEAD could be done on its back-branches by removing > --with-openssl and bring more consistency, but pg_upgrade has never > been good at handling upgrades with different library requirements. > Something I am wondering is if AdjustUpgrade.

Re: pg_upgrade and cross-library upgrades

2023-07-04 Thread Michael Paquier
On Wed, Jul 05, 2023 at 06:00:25PM +1200, Thomas Munro wrote: > If this were my animal and if the hardware couldn't be > upgraded to a modern distro for technical reasons like a de-supported > architecture, I would now disable HEAD, or more likely give the whole > machine a respectful send-off cere

Re: pg_upgrade and cross-library upgrades

2023-07-04 Thread Thomas Munro
On Wed, Jul 5, 2023 at 4:29 PM Michael Paquier wrote: > Thoughts? I am grateful for all the bug discoveries that these Debian 7 animals provided in their time, but at this point we're unlikely to learn things that are useful to our mission from them. It costs our community time to talk about eac

pg_upgrade and cross-library upgrades

2023-07-04 Thread Michael Paquier
Hi all, After removing --with-openssl from its build of HEAD, snapper has begun failing in the pg_upgrade path 11->HEAD, because it attempts pg_upgrade from binaries that have OpenSSL to builds without it: https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=snapper&br=HEAD Using the TAP t