Re: win32ver data in meson-built postgres.exe

2023-06-09 Thread Noah Misch
On Thu, Jun 08, 2023 at 01:10:00PM +0200, Magnus Hagander wrote: > On Thu, Jun 8, 2023 at 3:45 AM Noah Misch wrote: > > On Wed, Jun 07, 2023 at 04:47:26PM -0700, Andres Freund wrote: > > > On 2023-06-07 16:14:07 -0700, Noah Misch wrote: > > > > postgres.exe is icon-free. > > > > > > We could a

Re: win32ver data in meson-built postgres.exe

2023-06-09 Thread Andres Freund
Hi, On 2023-06-07 18:45:07 -0700, Noah Misch wrote: > On Wed, Jun 07, 2023 at 04:47:26PM -0700, Andres Freund wrote: > > On 2023-06-07 16:14:07 -0700, Noah Misch wrote: > > > A postgres.exe built with meson, ninja, and MSVC lacks the version > > > metadata > > > that postgres.exe gets under non-m

Re: win32ver data in meson-built postgres.exe

2023-06-08 Thread Magnus Hagander
On Thu, Jun 8, 2023 at 3:45 AM Noah Misch wrote: > > On Wed, Jun 07, 2023 at 04:47:26PM -0700, Andres Freund wrote: > > On 2023-06-07 16:14:07 -0700, Noah Misch wrote: > > > A postgres.exe built with meson, ninja, and MSVC lacks the version > > > metadata > > > that postgres.exe gets under non-me

Re: win32ver data in meson-built postgres.exe

2023-06-07 Thread Noah Misch
On Wed, Jun 07, 2023 at 04:47:26PM -0700, Andres Freund wrote: > On 2023-06-07 16:14:07 -0700, Noah Misch wrote: > > A postgres.exe built with meson, ninja, and MSVC lacks the version metadata > > that postgres.exe gets under non-meson build systems. Patch attached. > > I dimly recall that we dis

Re: win32ver data in meson-built postgres.exe

2023-06-07 Thread Andres Freund
Hi, On 2023-06-07 16:14:07 -0700, Noah Misch wrote: > A postgres.exe built with meson, ninja, and MSVC lacks the version metadata > that postgres.exe gets under non-meson build systems. Patch attached. I dimly recall that we discussed that and basically decided that it doesn't really make sense

win32ver data in meson-built postgres.exe

2023-06-07 Thread Noah Misch
A postgres.exe built with meson, ninja, and MSVC lacks the version metadata that postgres.exe gets under non-meson build systems. Patch attached. Author: Noah Misch Commit: Noah Misch Add win32ver data to meson-built postgres.exe. This preserves two quirks of the older buil