On 04/06/2017 03:21 PM, Aleksander Alekseev wrote:
Hi Robert,
Hmm. I don't see anything wrong with that, particularly, but it seems
we also don't need the distinction between XLOG_BTREE_SPLIT_L and
XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
XLOG_BTREE_SPLIT_R_ROOT --
Hi Robert,
> Thanks. Please add this to the next CommitFest, as there seems to be
> no urgency (and some risk) in committing it right before feature
> freeze.
Sure. Already done [1].
[1] https://commitfest.postgresql.org/14/1097/
--
Best regards,
Aleksander Alekseev
signature.asc
On Thu, Apr 6, 2017 at 8:21 AM, Aleksander Alekseev
wrote:
> Hi Robert,
>
>> Hmm. I don't see anything wrong with that, particularly, but it seems
>> we also don't need the distinction between XLOG_BTREE_SPLIT_L and
>> XLOG_BTREE_SPLIT_L_ROOT or likewise between
Hi Robert,
> Hmm. I don't see anything wrong with that, particularly, but it seems
> we also don't need the distinction between XLOG_BTREE_SPLIT_L and
> XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and
> XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go
> a
On Fri, Mar 31, 2017 at 10:10 AM, Aleksander Alekseev
wrote:
> Turned out that there is an unused argument `isroot` in
> `btree_xlog_split` procedure. Suggested patch fixes it.
>
> This issue was discovered by Anastasia Lubennikova, coding is done by me.
Hmm. I don't
Hi,
Turned out that there is an unused argument `isroot` in
`btree_xlog_split` procedure. Suggested patch fixes it.
This issue was discovered by Anastasia Lubennikova, coding is done by me.
--
Best regards,
Aleksander Alekseev
diff --git a/src/backend/access/nbtree/nbtxlog.c