On 2017-04-10 12:20:16 -0400, Tom Lane wrote:
> Barring objections, I'll push this shortly.
+1, to just about all of it
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
I wrote:
> Andrew Gierth writes:
>> In a discussion with Andres on the hash grouping sets review thread, I
>> proposed that we should have something of the form
>> #define lfirst_node(_type_, l) (castNode(_type_,lfirst(l)))
> That seems like a fairly good idea. A significant fraction of the
> e
Andrew Gierth writes:
> In the discussion with Andres the same point came up for palloc, for
> which I suggested we add something along the lines of:
> #define palloc_object(_type_) (_type_ *) palloc(sizeof(_type_))
> #define palloc_array(_type_, n) (_type_ *) palloc((n) * sizeof(_type_))
I'm fa
> "Thomas" == Thomas Munro writes:
>> SomeType *x = (SomeType *) lfirst(l);
>>
>> (in my code I tend to omit the (SomeType *), which I dislike because
>> it adds no real protection)
Thomas> Just BTW, without that cast it's not compilable as C++, so I'm
Thomas> guessing that Peter E wi
On Sun, Apr 9, 2017 at 8:27 AM, Andrew Gierth
wrote:
> foreach(l, blah)
> {
> SomeType *x = (SomeType *) lfirst(l);
>
> (in my code I tend to omit the (SomeType *), which I dislike because it
> adds no real protection)
Just BTW, without that cast it's not compilable as C++, so I'm
Tom Lane writes:
> I made the attached quick-hack patch, and found that check-world
> passes just fine with it. That's not complete proof that we have
> no other bugs of this ilk, but it definitely supports the idea
> that we don't really need to add the overhead. I'll just put this
> in the arc
> On Apr 8, 2017, at 7:41 PM, Mark Dilger wrote:
>
>
>> On Apr 8, 2017, at 7:35 PM, Tom Lane wrote:
>>
>> Mark Dilger writes:
>>> This is very near where the original crash reported in this thread was
>>> crashing, probably only
>>> different due to the extra lines of Assert that were added
> On Apr 8, 2017, at 7:35 PM, Tom Lane wrote:
>
> Mark Dilger writes:
>> This is very near where the original crash reported in this thread was
>> crashing, probably only
>> different due to the extra lines of Assert that were added. Am I missing
>> some portion of the
>> fix that you are te
Mark Dilger writes:
> This is very near where the original crash reported in this thread was
> crashing, probably only
> different due to the extra lines of Assert that were added. Am I missing
> some portion of the
> fix that you are testing? I have only applied the patch that Tom included in
> On Apr 8, 2017, at 6:48 PM, Mark Dilger wrote:
>
>
>> On Apr 8, 2017, at 6:38 PM, Mark Dilger wrote:
>>
>>
>>> On Apr 8, 2017, at 5:13 PM, Tom Lane wrote:
>>>
>>> I wrote:
Robert Haas writes:
> On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote:
> I think it's pretty dubious t
> On Apr 8, 2017, at 6:38 PM, Mark Dilger wrote:
>
>
>> On Apr 8, 2017, at 5:13 PM, Tom Lane wrote:
>>
>> I wrote:
>>> Robert Haas writes:
On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote:
I think it's pretty dubious to change this, honestly. Just because it
would have caught
> On Apr 8, 2017, at 5:13 PM, Tom Lane wrote:
>
> I wrote:
>> Robert Haas writes:
>>> On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote:
>>> I think it's pretty dubious to change this, honestly. Just because it
>>> would have caught this one bug doesn't make it an especially valuable
>>> thing i
I wrote:
> Robert Haas writes:
>> On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote:
>> I think it's pretty dubious to change this, honestly. Just because it
>> would have caught this one bug doesn't make it an especially valuable
>> thing in general. Bytes are still not free.
> What I think I mi
On 2017-04-08 17:20:28 -0400, Tom Lane wrote:
> Robert Haas writes:
> > On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote:
> >> This makes me wonder whether we were being penny-wise and pound-foolish
> >> by not making Bitmapsets be a kind of Node, so that there could be IsA
> >> assertions in the b
Robert Haas writes:
> On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote:
>> This makes me wonder whether we were being penny-wise and pound-foolish
>> by not making Bitmapsets be a kind of Node, so that there could be IsA
>> assertions in the bitmapset.c routines, as there are for Lists.
> I think
Andrew Gierth writes:
> "Tom" == Tom Lane writes:
> Tom> Experimentation shows that actually, the standard regression tests
> Tom> provide dozens of opportunities for find_relation_from_clauses to
> Tom> fail on non-RestrictInfo input. However, it lacks any IsA check,
> In a discussion with
On Sat, Apr 8, 2017 at 3:57 PM, Tom Lane wrote:
> This makes me wonder whether we were being penny-wise and pound-foolish
> by not making Bitmapsets be a kind of Node, so that there could be IsA
> assertions in the bitmapset.c routines, as there are for Lists. Most
> Bitmapsets in a typical backe
> "Tom" == Tom Lane writes:
Tom> Experimentation shows that actually, the standard regression tests
Tom> provide dozens of opportunities for find_relation_from_clauses to
Tom> fail on non-RestrictInfo input. However, it lacks any IsA check,
In a discussion with Andres on the hash groupin
I wrote:
> Andrew Gierth writes:
>> Commit ac2b095088 assumes that clauselist_selectivity is being passed a
>> list of RelOptInfo, but postgres_fdw is passing it a list of bare
>> clauses. One of them is wrong :-)
> It's a bit scary that apparently none of the committed regression tests
> caught
Andrew Gierth writes:
> "Andreas" == Andreas Seltenreich writes:
> Andreas> testing master at f0e44021df with a loopback postgres_fdw
> Andreas> installed, I see lots of crashes on queries joining foreign
> Andreas> tables with various expressions. Below is a reduced recipe
> Andreas> for th
> "Andreas" == Andreas Seltenreich writes:
Andreas> Hi,
Andreas> testing master at f0e44021df with a loopback postgres_fdw
Andreas> installed, I see lots of crashes on queries joining foreign
Andreas> tables with various expressions. Below is a reduced recipe
Andreas> for the regressi
Hi,
testing master at f0e44021df with a loopback postgres_fdw installed, I
see lots of crashes on queries joining foreign tables with various
expressions. Below is a reduced recipe for the regression database and
a backtrace.
regards,
Andreas
--8<---cut here---start-
22 matches
Mail list logo
