Re: [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Greg Stark
David Fetter <[EMAIL PROTECTED]> writes: > Not everybody's editor/mailer/whatever does this right, and it makes > things fragile. Another way to do this is to change the delimter to a > printable character like '|', but that raises hackles, too. Frankly if you're passing you data through an edi

Re: [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread David Fetter
On Wed, Mar 08, 2006 at 11:26:00AM -0500, Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > On Wed, Mar 08, 2006 at 11:03:00AM -0500, Tom Lane wrote: > >> Did anyone provide a convincing use case for this? > > > I've had one so far, and it was enough to cause me to make a > > special

Re: [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > On Wed, Mar 08, 2006 at 11:03:00AM -0500, Tom Lane wrote: >> Did anyone provide a convincing use case for this? > I've had one so far, and it was enough to cause me to make a special > patched version of pg_dump. To get some idea of how drastic that was,

Re: [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread David Fetter
On Wed, Mar 08, 2006 at 11:03:00AM -0500, Tom Lane wrote: > David Fetter <[EMAIL PROTECTED]> writes: > > From the earlier discussion, it appears that there is a variety of > > opinions on what the COPY delimiter should be in pg_dump. This > > patch allows people to set it and the NULL string. > >

Re: [HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread Tom Lane
David Fetter <[EMAIL PROTECTED]> writes: > From the earlier discussion, it appears that there is a variety of > opinions on what the COPY delimiter should be in pg_dump. This patch > allows people to set it and the NULL string. Did anyone provide a convincing use case for this? It's of zero valu

[HACKERS] Add switches for DELIMITER and NULL in pg_dump COPY

2006-03-08 Thread David Fetter
Folks, >From the earlier discussion, it appears that there is a variety of opinions on what the COPY delimiter should be in pg_dump. This patch allows people to set it and the NULL string. Thanks to Gavin Sherry for help with the pointers :) I didn't patch pg_dumpall, but it would be trivial if