Robert Haas writes:
> There's an awful lot of layers of function calls happening in
> explain.c for no really discernable purpose that I can see.
> ExplainOneQuery() calls either ExplainOneUtility() if it has a utility
> command or ExplainOneQuery_hook() if that's defined or else it plans
> the qu
On Mon, Dec 7, 2009 at 11:07 AM, Tom Lane wrote:
> Itagaki Takahiro writes:
>> Tom Lane wrote:
>>> Looks like auto_explain is under the illusion that it need not call
>>> ExplainBeginOutput/ExplainEndOutput.
>
>> Explain{Begin/End}Output are static functions, so we cannot call them
>> from an ex
On Mon, Dec 7, 2009 at 10:42 AM, Alvaro Herrera
wrote:
> Tom Lane wrote:
>> Euler Taveira de Oliveira writes:
>> > While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to
>> > provide a fix right now but if someone can take it I will appreciate. It
>> > seems
>> > ExplainJSONLine
Itagaki Takahiro writes:
> Tom Lane wrote:
>> Looks like auto_explain is under the illusion that it need not call
>> ExplainBeginOutput/ExplainEndOutput.
> Explain{Begin/End}Output are static functions, so we cannot call them
> from an external contrib module. Instead, I'll suggest to call them
Alvaro Herrera escreveu:
> Fortunately the author of auto_explain can now commit the fix by himself ...
> Kudos, BTW :-)
>
Congratulations!
--
Euler Taveira de Oliveira
http://www.timbira.com/
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your su
Tom Lane wrote:
> Euler Taveira de Oliveira writes:
> > While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to
> > provide a fix right now but if someone can take it I will appreciate. It
> > seems
> > ExplainJSONLineEnding() doesn't expect es->grouping_stack list as a null
> >
Tom Lane wrote:
> Looks like auto_explain is under the illusion that it need not call
> ExplainBeginOutput/ExplainEndOutput.
They were added by XML formatter; I suppose it worked on 8.4.
Explain{Begin/End}Output are static functions, so we cannot call them
from an external contrib module. Inst
Euler Taveira de Oliveira writes:
> While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to
> provide a fix right now but if someone can take it I will appreciate. It seems
> ExplainJSONLineEnding() doesn't expect es->grouping_stack list as a null
> pointer.
Looks like auto_expla
Hi,
While testing the EXPLAIN BUFFERS patch I found a bug. I'm too tired to
provide a fix right now but if someone can take it I will appreciate. It seems
ExplainJSONLineEnding() doesn't expect es->grouping_stack list as a null
pointer.
eu...@harman $ ./install/bin/psql
psql (8.5devel)
Type "hel
