Re: [HACKERS] Reduce palloc's in numeric operations.

2012-11-12 Thread Kyotaro HORIGUCHI
Thanks for comments, Have to be careful to really not modify the operands. numeric_out() and numeric_out_sci() are wrong; they call get_str_from_var(), which modifies the argument. Same with numeric_expr(): it passes the argument to numericvar_to_double_no_overflow(), which passes it to

Re: [HACKERS] Reduce palloc's in numeric operations.

2012-10-17 Thread Alvaro Herrera
Kyotaro HORIGUCHI wrote: Hello, I will propose reduce palloc's in numeric operations. The numeric operations are slow by nature, but usually it is not a problem for on-disk operations. Altough the slowdown is enhanced on on-memory operations. I inspcted them and found some very short term

Re: [HACKERS] Reduce palloc's in numeric operations.

2012-09-19 Thread Heikki Linnakangas
On 14.09.2012 11:25, Kyotaro HORIGUCHI wrote: Hello, I will propose reduce palloc's in numeric operations. The numeric operations are slow by nature, but usually it is not a problem for on-disk operations. Altough the slowdown is enhanced on on-memory operations. I inspcted them and found some

[HACKERS] Reduce palloc's in numeric operations.

2012-09-14 Thread Kyotaro HORIGUCHI
Hello, I will propose reduce palloc's in numeric operations. The numeric operations are slow by nature, but usually it is not a problem for on-disk operations. Altough the slowdown is enhanced on on-memory operations. I inspcted them and found some very short term pallocs. These palloc's are