Re: [PATCHES] Diagnostic functions

2007-05-17 Thread Bruce Momjian
Applied. I also updated /contrib/README. Thanks. --- Heikki Linnakangas wrote: > Bruce Momjian wrote: > > Heikki Linnakangas wrote: > We already played the name game on hackers. My original suggestion was > "pgfo

Re: [PATCHES] Diagnostic functions

2007-05-17 Thread Heikki Linnakangas
Bruce Momjian wrote: Heikki Linnakangas wrote: We already played the name game on hackers. My original suggestion was "pgforensics". "pgdiagfuncs" and "pginspect" were also suggested, among others. I'm still open to suggestions, though. Have any? Something involving "page" would at least explai

Re: [PATCHES] Diagnostic functions

2007-05-11 Thread Bruce Momjian
Heikki Linnakangas wrote: > >> We already played the name game on hackers. My original suggestion was > >> "pgforensics". "pgdiagfuncs" and "pginspect" were also suggested, among > >> others. I'm still open to suggestions, though. Have any? > > > > Something involving "page" would at least explain

Re: [PATCHES] Diagnostic functions

2007-05-07 Thread Heikki Linnakangas
Peter Eisentraut wrote: Am Montag, 7. Mai 2007 11:49 schrieb Heikki Linnakangas: It's handy to be able to inspect pages from within a live database. How reliable is it to inspect pages from within a database if you presumably suspect that database to be broken? As long as the page header is

Re: [PATCHES] Diagnostic functions

2007-05-07 Thread Peter Eisentraut
Am Montag, 7. Mai 2007 11:49 schrieb Heikki Linnakangas: > It's handy to be able to inspect pages from within a live database. How reliable is it to inspect pages from within a database if you presumably suspect that database to be broken? > We already played the name game on hackers. My origina

Re: [PATCHES] Diagnostic functions

2007-05-07 Thread Heikki Linnakangas
Peter Eisentraut wrote: Heikki Linnakangas wrote: Here's an update of Simon's Heap Page Diagnostic Functions. I now consider it ready to commit. How is this better than pg_filedump? It's handy to be able to inspect pages from within a live database. The new functions work through shared_buf

Re: [PATCHES] Diagnostic functions

2007-05-05 Thread Peter Eisentraut
Heikki Linnakangas wrote: > Here's an update of Simon's Heap Page Diagnostic Functions. I now > consider it ready to commit. How is this better than pg_filedump? "diagnostics" is an awfully general name, too. -- Peter Eisentraut http://developer.postgresql.org/~petere/

[PATCHES] Diagnostic functions

2007-05-02 Thread Heikki Linnakangas
Here's an update of Simon's Heap Page Diagnostic Functions. I now consider it ready to commit. The new functions are all under new contrib module, contrib/pgdiagnostics. I also moved bt_metap, bt_page_items and bt_page_stats from pgstattuple to the new module. I copied the bt_* functions alm