Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-18 Thread Ilia Alshanetsky
I've talked the patch over with Pierre and it would appear some testing on this code was already done without any issues being raised. So, for now thew new GD functions will stay, but if during testing any issues are identified with them, then they will be ifdefed out from the code and will

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-18 Thread Ilia Alshanetsky
On 17-Apr-07, at 11:31 AM, Pierre-Alain Joye wrote: pajoye Tue Apr 17 15:31:45 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/gd config.w32 gd.c php_gd.h Log: - MFH: add imagegrabwindow and imagegrabscreen (win32 only) [DOC] capture a window usi

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Edin Kadribasic
On 17/04/2007, at 21.24, Marcus Boerger wrote: Hello Edin, it appears i should read cvs commits more carefully. I thought that win64 change was a pretty easy one not affecting anything else. Reviewing it again i get a different opinion. And sorry but I can't care less about FCGI and whe

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Marcus Boerger
Hello Edin, it appears i should read cvs commits more carefully. I thought that win64 change was a pretty easy one not affecting anything else. Reviewing it again i get a different opinion. And sorry but I can't care less about FCGI and whether someone moves stuff from CLI to FCGI. Or did jani d

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Edin Kadribasic
On 17/04/2007, at 21.08, Marcus Boerger wrote: Hello Derick, Tuesday, April 17, 2007, 8:58:40 PM, you wrote: On Tue, 17 Apr 2007, Antony Dovgal wrote: On 04/17/2007 09:29 PM, Marcus Boerger wrote: Hello Pierre-Alain, since when are we adding major new features to release branches? Pi

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Edin Kadribasic
Hello Marcus, Did I miss your mail to Dmitry about making *major* engine changes to add Win64 support? I must also have lost your mail to Jani for adding new features to FastCGI too? I think I need to double check my spam filter. Or was your response more in regard of *who* committed it t

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Marcus Boerger
Hello Derick, Tuesday, April 17, 2007, 8:58:40 PM, you wrote: > On Tue, 17 Apr 2007, Antony Dovgal wrote: >> On 04/17/2007 09:29 PM, Marcus Boerger wrote: >> > Hello Pierre-Alain, >> > >> > since when are we adding major new features to release branches? >> >> Pierre, please leave this funct

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Derick Rethans
On Tue, 17 Apr 2007, Antony Dovgal wrote: > On 04/17/2007 09:29 PM, Marcus Boerger wrote: > > Hello Pierre-Alain, > > > > since when are we adding major new features to release branches? > > Pierre, please leave this function for HEAD only, we don't add new features to > 5.2. That's not true

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Marcus Boerger
Hello Edin, either way it is ridiculous to add new features in the middle of a releace process. We are not only in a release branch here. We are even in a middle of a release. In one that is even security focused. best regards marcus Tuesday, April 17, 2007, 8:27:50 PM, you wrote: > On 17/04/

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Antony Dovgal
On 04/17/2007 10:25 PM, Pierre Joye wrote: On 4/17/07, Antony Dovgal <[EMAIL PROTECTED]> wrote: On 04/17/2007 09:53 PM, Pierre Joye wrote: > On 4/17/07, Antony Dovgal <[EMAIL PROTECTED]> wrote: >> On 04/17/2007 09:29 PM, Marcus Boerger wrote: >> > Hello Pierre-Alain, >> > >> > since when are w

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Edin Kadribasic
On 17/04/2007, at 20.01, Antony Dovgal wrote: On 04/17/2007 09:53 PM, Pierre Joye wrote: On 4/17/07, Antony Dovgal <[EMAIL PROTECTED]> wrote: On 04/17/2007 09:29 PM, Marcus Boerger wrote: > Hello Pierre-Alain, > > since when are we adding major new features to release branches? Pierre, ple

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Antony Dovgal
On 04/17/2007 09:53 PM, Pierre Joye wrote: On 4/17/07, Antony Dovgal <[EMAIL PROTECTED]> wrote: On 04/17/2007 09:29 PM, Marcus Boerger wrote: > Hello Pierre-Alain, > > since when are we adding major new features to release branches? Pierre, please leave this function for HEAD only, we don't a

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Antony Dovgal
On 04/17/2007 09:29 PM, Marcus Boerger wrote: Hello Pierre-Alain, since when are we adding major new features to release branches? Pierre, please leave this function for HEAD only, we don't add new features to 5.2. Thanks. -- Wbr, Antony Dovgal -- PHP CVS Mailing List (http://www.php.

Re: [PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Marcus Boerger
Hello Pierre-Alain, since when are we adding major new features to release branches? best regards marcus Tuesday, April 17, 2007, 5:31:45 PM, you wrote: > pajoye Tue Apr 17 15:31:45 2007 UTC > Modified files: (Branch: PHP_5_2) > /php-src/ext/gd config.w32 gd.c

[PHP-CVS] cvs: php-src(PHP_5_2) /ext/gd config.w32 gd.c php_gd.h

2007-04-17 Thread Pierre-Alain Joye
pajoye Tue Apr 17 15:31:45 2007 UTC Modified files: (Branch: PHP_5_2) /php-src/ext/gd config.w32 gd.c php_gd.h Log: - MFH: add imagegrabwindow and imagegrabscreen (win32 only) [DOC] capture a window using its handle or a full screen http://cvs.php.net/vi