[PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-08 Thread Andrey Hristov
andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlndmysqlnd_palloc.c mysqlnd_wireprotocol.c Log: Merge with HEAD. Someone committed changes to HEAD and did not merge back to the branch. Also switch off the zval cach

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-08 Thread Lukas Kahwe Smith
On 08.06.2009, at 12:20, Andrey Hristov wrote: andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c Log: Merge with HEAD. Someone committed changes to HEAD and did not merge back to th

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local variable 'obj' used Cheers, On Mon, Jun 8, 2009 at 7:31 PM, Lukas Kahwe Smith wrote: > > On 08.06.2009, at 12:20, Andrey Hristov w

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Andrey Hristov
Hi Pierre, Pierre Joye wrote: hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local variable 'obj' used Cheers, Check with your eyes, the compiler is wrong. obj is touched only if

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Andrey Hristov
Hi Lukas, On Mon, Jun 8, 2009 at 7:31 PM, Lukas Kahwe Smith wrote: On 08.06.2009, at 12:20, Andrey Hristov wrote: andrey Mon Jun 8 10:20:27 2009 UTC Modified files: (Branch: PHP_5_3) /php-src/ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c Log: Merge with HEAD.

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
hi Andrey, On Thu, Jun 11, 2009 at 7:25 PM, Andrey Hristov wrote: >  Hi Pierre, > Pierre Joye wrote: >> >> hi, >> >> This change sounds wrong. The obj pointer is being used without being >> initialized: >> >> ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: >> uninitialized local variable

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Pierre Joye
On Thu, Jun 11, 2009 at 7:42 PM, Andrey Hristov wrote: > no :) Why not? it is clearly pointless when ZVAL_CACHE is not set. > But you can send the case to your colleagues at the compiler team so > they can analyze why the compiler failed to recognize it :) already sent :) > I like the MS > co

Re: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/mysqlnd mysqlnd_palloc.c mysqlnd_wireprotocol.c

2009-06-11 Thread Andrey Hristov
Hi Pierre, Pierre Joye wrote: hi Andrey, On Thu, Jun 11, 2009 at 7:25 PM, Andrey Hristov wrote: Hi Pierre, Pierre Joye wrote: hi, This change sounds wrong. The obj pointer is being used without being initialized: ext\mysqlnd\mysqlnd_wireprotocol.c(1632) : warning C4700: uninitialized local