Re: [Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

2013-05-13 Thread Ian Romanick
On 05/08/2013 10:49 AM, Marek Olšák wrote: --- tests/all.tests |1 + tests/spec/gl-3.1/CMakeLists.gl.txt |1 + tests/spec/gl-3.1/max-samplers.c| 274 +++ 3 files changed, 276 insertions(+) create mode 100644 tests/spec/gl-3.1

Re: [Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

2013-05-09 Thread Marek Olšák
No, it doesn't need a core profile. i have squashed your patch with mine and pushed the commit. As you have probably noticed, the test fails with Mesa. I think it's a deficiency of our GLSL linker, which assigns somewhat unfriendly IDs to samplers. (if a vertex shader uses 16 samplers, the first f

Re: [Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

2013-05-09 Thread Brian Paul
On 05/08/2013 07:27 PM, Marek Olšák wrote: On Thu, May 9, 2013 at 1:16 AM, Brian Paul wrote: BTW, I tried to test this with NVIDIA's driver but it appears that piglit can't create a GL 3.1 context: $ bin/gl-3.1-max-samplers -auto piglit: info: Failed to create GL 3.1 core context piglit: in

Re: [Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

2013-05-08 Thread Marek Olšák
On Thu, May 9, 2013 at 1:16 AM, Brian Paul wrote: >> +static const char *vs_source = >> + "#define NUM %i \n" >> + "uniform sampler2D vertex_tex[NUM]; \n" >> + "uniform int vertex_index;" >> + "varying vec3 vertex_tex_color; \n" >> + "void main() \n" >> + "{ \n"

Re: [Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

2013-05-08 Thread Brian Paul
On 05/08/2013 11:49 AM, Marek Olšák wrote: --- tests/all.tests |1 + tests/spec/gl-3.1/CMakeLists.gl.txt |1 + tests/spec/gl-3.1/max-samplers.c| 274 +++ 3 files changed, 276 insertions(+) create mode 100644 tests/spec/gl-3.1

[Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

2013-05-08 Thread Marek Olšák
--- tests/all.tests |1 + tests/spec/gl-3.1/CMakeLists.gl.txt |1 + tests/spec/gl-3.1/max-samplers.c| 274 +++ 3 files changed, 276 insertions(+) create mode 100644 tests/spec/gl-3.1/max-samplers.c diff --git a/tests/all.tests b/te