Review Request 110917: Remove usage of (fake) Amarok-Mockup theme

2013-06-09 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110917/ --- Review request for Amarok, Plasma and Aaron J. Seigo. Description ---

Re: qml trash

2013-06-09 Thread Heena Mahour
Hey , okay ,now the thing left here is empty trash in which I am not getting how to implement : KStandardDirs::findExe("ktrash") << "--empty"; m_emptyProcess->start(); in javascript (or c++ ? ) I will push the rest of the changes I made in some time as it is giving an error of remote reject

Re: qml trash

2013-06-09 Thread Kevin Krammer
On Sunday, 2013-06-09, Marco Martin wrote: > On Sunday 09 June 2013, Aaron J. Seigo wrote: > > QMetaObject::invokeMethod: No such method > > QDeclarativeFlow_QML_0::action_trash() > > > > there were other errors in there as well. all are visible by using > > plasmoidviewer. i'll push some fixes in

Re: qml trash

2013-06-09 Thread Marco Martin
On Sunday 09 June 2013, Heena Mahour wrote: > @Aaron .Yes,it is working on left clicking on it :P but on right click in > the original c++ trash can there is a pop up menu which contains open trash > and empty trash option ,So,for that open trash it is not working ,isn't it? > Regards setAction(St

Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

2013-06-09 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110476/#review33981 --- plasma/generic/dataengines/notifications/notificationaction.cp

Re: qml trash

2013-06-09 Thread Heena Mahour
@Aaron .Yes,it is working on left clicking on it :P but on right click in the original c++ trash can there is a pop up menu which contains open trash and empty trash option ,So,for that open trash it is not working ,isn't it? Regards @Marco, Yes,And what about open trash option? Regards On Sun, J

Re: qml trash

2013-06-09 Thread Marco Martin
On Sunday 09 June 2013, Aaron J. Seigo wrote: > QMetaObject::invokeMethod: No such method > QDeclarativeFlow_QML_0::action_trash() > > there were other errors in there as well. all are visible by using > plasmoidviewer. i'll push some fixes in a moment that you can look at. i guess that for empty

Re: Review Request 110476: Call KNotification::close() when notification is closed in the applet

2013-06-09 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110476/ --- (Updated June 9, 2013, 3:11 p.m.) Review request for Plasma. Description

Re: qml trash

2013-06-09 Thread Aaron J. Seigo
On Saturday, June 8, 2013 23:50:31 Heena Mahour wrote: > Hi , I am trying to implement qml plasmoid of trash , in the action menu > for statement KRun::runUrl(KUrl("trash:/"), "inode/directory", 0); I > implemented it is qml like this :http://pastebin.com/raw.php?i=266L3Hx0 but > it is not opening

Re: qml trash

2013-06-09 Thread Aaron J. Seigo
On Saturday, June 8, 2013 23:50:31 Heena Mahour wrote: > Hi , I am trying to implement qml plasmoid of trash , in the action menu > for statement KRun::runUrl(KUrl("trash:/"), "inode/directory", 0); I > implemented it is qml like this :http://pastebin.com/raw.php?i=266L3Hx0 but > it is not opening

Re: qml trash

2013-06-09 Thread Aaron J. Seigo
On Sunday, June 9, 2013 16:23:31 Heena Mahour wrote: > Hey all ,one more query is that in order to open trash:/ what should I > write in engine: and connectedSources you should not be using a DataEngine for this, but rather plasmoid.openUrl. here's the good news: it works perfectly here. i start

Re: qml trash

2013-06-09 Thread Heena Mahour
Hey all ,one more query is that in order to open trash:/ what should I write in engine: and connectedSources here : PlasmaCore.DataSource { id: dataEngine engine://what should be I include here among the data engine connectedSources: [??] } On Sun, Jun 9, 2013 at 12:06