Re: Review Request 117732: Move settings class to lib from shell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117732/ --- (Updated April 24, 2014, 11:40 a.m.) Review request for Plasma, Shantanu

Review Request 117732: Move settings class to lib from shell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117732/ --- Review request for Plasma and Shantanu Tushar. Repository: plasma-mediace

Qt Quick Controls style

Hello all, We completed the visual design for the UI controls recently in the VDG forums. After a little finalization work, it's available in my scratch repo (git.kde.org:scratch/alake/BreezeStyle). I know a general Breeze project repo was recently suggested, which would work just fine I think. We

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 23, 2014, 5:43 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 34 > > > > > > I'm wondering about the variable naming. It's m_ so one would assume > > it's a member variab

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

> On April 24, 2014, 4:38 a.m., Albert Astals Cid wrote: > > Seems to be an ulra-hack, but if it works, i guess you should commit it if > > it really helps your users to be able to use your product. > > > > Maybe adding a big "TODO" somewhere to recheck if this is needed later on > > or someth

Re: Re: Cursorsors: where?

On Wednesday 23 April 2014 23:10:41 Thomas Pfeiffer wrote: > On Wednesday 23 April 2014 13:58:02 Martin Gräßlin wrote: > > On Wednesday 23 April 2014 13:53:56 David Edmundson wrote: > > > Right now we have an oxygen repo full of all different things (icons, > > > window decoration, qstyle) > > > >

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

> On April 23, 2014, 11:08 p.m., Albert Astals Cid wrote: > > Seems to be an ulra-hack, but if it works, i guess you should commit it if > > it really helps your users to be able to use your product. > > > > Maybe adding a big "TODO" somewhere to recheck if this is needed later on > > or somet

Build failed in Jenkins: kde-runtime_frameworks_qt5 #152

See Changes: [jpwhiting] Remove knewstuff test applications since they are in knewstuff/tests now. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on Li

Build failed in Jenkins: plasma-desktop_master_qt5 #61

See Changes: [hein] Add note. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/#review56339 --- Seems to be an ulra-hack, but if it works, i guess you should

Build failed in Jenkins: plasma-desktop_master_qt5 #60

See Changes: [hein] Initial import of Application Menu aka (Homerun) Kicker. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LI

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 23, 2014, 5:43 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 34 > > > > > > I'm wondering about the variable naming. It's m_ so one would assume > > it's a member variab

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 23, 2014, 11:26 p.m.) Review request for kde-workspace, Pl

Re: Cursorsors: where?

On Wednesday 23 April 2014 13:58:02 Martin Gräßlin wrote: > On Wednesday 23 April 2014 13:53:56 David Edmundson wrote: > > Right now we have an oxygen repo full of all different things (icons, > > window decoration, qstyle) > > > > We can make a Breeze repo full of all these new different things.

Re: Review Request 117542: Improve battery monitor

> On April 23, 2014, 4:49 p.m., David Edmundson wrote: > > applets/batterymonitor/contents/code/logic.js, line 33 > > > > > > Can you explain this change? See the other reviews where I renamed this property becau

Re: Review Request 117728: Fix configure when optional packages are missing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117728/#review56319 --- Ship it! Ship It! - Martin Gräßlin On April 23, 2014, 8:33

Build failed in Jenkins: plasma-workspace_master_qt5 #86

See Changes: [hrvoje.senjan] fix build -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Review Request 117728: Fix configure when optional packages are missing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117728/ --- Review request for kwin and Plasma. Repository: kwin Description --

Re: Review Request 117455: [kglobalaccel] Remove Component::showKCM

> On April 15, 2014, 10:17 a.m., Martin Gräßlin wrote: > > David Faure changed the code with 1206a3eaaf31c5438011a53c4839e27249037ac0 > > to use QProcess. Should we still apply this patch or not? Yes, go ahead. Your analysis is more complete than my mindless port ;) - David

Review Request 117727: Handle tests and docs if deps are missing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117727/ --- Review request for Plasma. Repository: kio-extras Description ---

Re: Review Request 117542: Improve battery monitor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117542/#review56310 --- applets/batterymonitor/contents/ui/BatteryItem.qml

Re: Review Request 117625: Remove unused dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117625/#review56305 --- This review has been submitted with commit be79921445c441c380

Build failed in Jenkins: kmenuedit_master_qt5 #4

See Changes: [kensington] Remove unused dependencies. Add feature summary. Use renamed KDELibs4Support. -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on Linux

Re: Review Request 117625: Remove unused dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117625/ --- (Updated April 23, 2014, 5:06 p.m.) Status -- This change has been m

Re: Review Request 117542: Improve battery monitor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117542/#review56298 --- applets/batterymonitor/contents/code/logic.js

Re: Plasma Next - Translations KCM - What Languages?

On Sunday 16 March 2014 15:49:02 Chusslove Illich wrote: > The related problem for me is this: why are there still standalone language > packages for some of KDE software (the SC)? Other than historical reasons, > the only advantage I see is installation space. But I don't see anyone > complaining

Re: Review Request 117723: Adapt the PanelView to the new item status in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117723/#review56300 --- Ship it! Ship It! - Marco Martin On April 23, 2014, 4:28 p

Re: Review Request 117724: Fix plasmoid status when compact plasmoids expand

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117724/#review56299 --- Ship it! Ship It! - Marco Martin On April 23, 2014, 4:34 p

Re: Review Request 117722: Introduce a new plasmoid status

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117722/#review56301 --- Ship it! Ship It! - Marco Martin On April 23, 2014, 4:26 p

Review Request 117724: Fix plasmoid status when compact plasmoids expand

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117724/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 117723: Adapt the PanelView to the new item status in plasma-framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117723/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 117722: Introduce a new plasmoid status

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117722/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 117625: Remove unused dependencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117625/#review56297 --- Ship it! Ship It! - David Edmundson On April 18, 2014, 8:3

Build failed in Jenkins: plasma-workspace_master_qt5 #85

See Changes: [bettio] Weather DataEngine: Enable build for weather ion library and NOAA ion -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave

Build failed in Jenkins: plasma-workspace_master_qt5 #84

See Changes: [bettio] Weather DataEngine/ion library: Port to Plasma2/Qt5 ++ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER

Build failed in Jenkins: plasma-desktop_master_qt5 #59

See Changes: [notmart] set as requestingattention when open [notmart] tweak anchors -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PAC

Build failed in Jenkins: plasma-workspace_master_qt5 #83

See Changes: [bettio] Weather DataEngine/NOAA ion: Port to Plasma2 ++ -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUIL

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: > > Is that only relevant for the legacy (XSS) locker or also for the new > > locker? I'm just wondering whether it needs to be ported to master > > Wolfgang Bauer wrote: > Yes. I just tried, and the screen locker in master does have the

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56294 --- ksmserver/screenlocker/greeter/main.cpp

Build failed in Jenkins: plasma-workspace_master_qt5 #82

See Changes: [scripty] SVN_SILENT made messages (.desktop file) [me] KRunner: Set the window type [me] Add a System Monitor -- Started by remote host 127.0.0.1 with note: Triggered by comm

Re: [kdesrc-build] /: kf5: Port rc files to use branch-groups consistently.

On Wednesday 05 March 2014 10:44:24 Kevin Ottens wrote: > > * kactivities moved under kde/kdelibs/kactivities (a very odd location in > > the frameworks world, but kde_projects.xml is global, not > > branch-dependent) > > Ideally should be under frameworks at some point. I'd rather have it odd in

Re: Review Request 117632: Plasmoidviewer-Frameworks: Enable the konsole and fix the spacing.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117632/ --- (Updated April 23, 2014, 3:23 p.m.) Review request for Plasma. Changes

Re: Review Request 117631: Plasmoidviewer-Frameworks: The konsole button should be visible only if the konsole is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117631/#review56285 --- Ship it! Ship It! - Giorgos Tsiapaliokas On April 23, 2014

Re: Review Request 117631: Plasmoidviewer-Frameworks: The konsole button should be visible only if the konsole is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117631/ --- (Updated April 23, 2014, 3:12 p.m.) Status -- This change has been m

Re: Review Request 117631: Plasmoidviewer-Frameworks: The konsole button should be visible only if the konsole is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117631/#review56286 --- This review has been submitted with commit a3bb2315686a65a9c0

Re: Review Request 117632: Plasmoidviewer-Frameworks: Enable the konsole and fix the spacing.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117632/ --- (Updated April 23, 2014, 3:09 p.m.) Review request for Plasma. Changes

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: > > Is that only relevant for the legacy (XSS) locker or also for the new > > locker? I'm just wondering whether it needs to be ported to master > > Wolfgang Bauer wrote: > Yes. I just tried, and the screen locker in master does have the

Build failed in Jenkins: plasma-desktop_master_qt5 #58

See Changes: [aleixpol] Fix what clearly looks like a copy&paste typo -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDE

Re: Review Request 117631: Plasmoidviewer-Frameworks: The konsole button should be visible only if the konsole is enabled.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117631/ --- (Updated April 23, 2014, 2:38 p.m.) Review request for Plasma. Changes

Re: Review Request 117632: Plasmoidviewer-Frameworks: Enable the konsole and fix the spacing.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117632/ --- (Updated April 23, 2014, 2:29 p.m.) Review request for Plasma. Changes

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

> On April 23, 2014, 7:36 a.m., Martin Gräßlin wrote: > > would you please also adapt that for plasma-workspace repo (new master)? > > Wolfgang Bauer wrote: > Yes, I will. > > Should I create a new review request for that, or should I just submit it? The code looks pretty straight

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

> On April 23, 2014, 7:36 a.m., Martin Gräßlin wrote: > > would you please also adapt that for plasma-workspace repo (new master)? Yes, I will. Should I create a new review request for that, or should I just submit it? - Wolfgang --- T

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote: > > Is that only relevant for the legacy (XSS) locker or also for the new > > locker? I'm just wondering whether it needs to be ported to master Yes. I just tried, and the screen locker in master does have the same problem. I wasn't able ye

Re: Cursorsors: where?

On Wed, Apr 23, 2014 at 1:54 PM, Myriam Schweingruber wrote: > On Wed, Apr 23, 2014 at 1:50 PM, Marco Martin wrote: > > Hi all, > > so, someone from the VDG did a very pretty series of mouse cursors: > > https://forum.kde.org/viewtopic.php?f=285&t=119857&start=75 > > https://github.com/Ken-Vermet

Re: Re: Cursorsors: where?

On Wednesday 23 April 2014 13:53:56 David Edmundson wrote: > Right now we have an oxygen repo full of all different things (icons, > window decoration, qstyle) > > We can make a Breeze repo full of all these new different things. I think that's the best approach to it. We will hopefully soon see

Re: Cursorsors: where?

On Wednesday 23 April 2014, David Edmundson wrote: > Right now we have an oxygen repo full of all different things (icons, > window decoration, qstyle) > > We can make a Breeze repo full of all these new different things. > > Workspace can depend on both for a while so we fall back to oxygen, > t

Re: Cursorsors: where?

On Wed, Apr 23, 2014 at 1:50 PM, Marco Martin wrote: > Hi all, > so, someone from the VDG did a very pretty series of mouse cursors: > https://forum.kde.org/viewtopic.php?f=285&t=119857&start=75 > https://github.com/Ken-Vermette/Bridge-Cursor > > Thing is, if we want to ship that as default, it ne

Re: Cursorsors: where?

Right now we have an oxygen repo full of all different things (icons, window decoration, qstyle) We can make a Breeze repo full of all these new different things. Workspace can depend on both for a while so we fall back to oxygen, then at some point in the future we can drop that. ___

Cursorsors: where?

Hi all, so, someone from the VDG did a very pretty series of mouse cursors: https://forum.kde.org/viewtopic.php?f=285&t=119857&start=75 https://github.com/Ken-Vermette/Bridge-Cursor Thing is, if we want to ship that as default, it needs to be somewhere in the KDE infrastructure: where could we p

Build failed in Jenkins: plasma-desktop_master_qt5 #57

See Changes: [notmart] use again the expander from the taskmanager -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER)