Re: Review Request 122662: Meta-Tab activity switching for plasma-desktop

2015-02-21 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122662/ --- (Updated Feb. 21, 2015, 7:06 p.m.) Status -- This change has been ma

[plasma-framework] src/declarativeimports/core: Shorter animations

2015-02-21 Thread Sebastian Kügler
Git commit 2cf49abb3e2c4e8ea8d5cb55e523dc1c3f57bddd by Sebastian Kügler. Committed on 21/02/2015 at 18:53. Pushed by sebas into branch 'master'. Shorter animations This patch cuts down animation time quite considerably. We've discussed this during the sprint. The default long animation is now 120

Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-02-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: Review Request 122666: Remove separator functionality from kmenuedit

2015-02-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122666/ --- (Updated Feb. 21, 2015, 6:20 p.m.) Status -- This change has been ma

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/#review76398 --- Ship it! Ship It! - Marco Martin On Feb. 21, 2015, 12:56 p

Re: Review Request 122666: Remove separator functionality from kmenuedit

2015-02-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122666/#review76397 --- Ship it! Ship It! - David Edmundson On Feb. 21, 2015, 5:51

Re: Review Request 122662: Meta-Tab activity switching for plasma-desktop

2015-02-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122662/#review76395 --- Ship it! desktoppackage/contents/activitymanager/ActivityMan

Review Request 122666: Remove separator functionality from kmenuedit

2015-02-21 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122666/ --- Review request for Plasma. Bugs: 337305 https://bugs.kde.org/show_bug

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/#review76394 --- ... also note that (still imho), that there does not have to b

Papercuts from review at sprint

2015-02-21 Thread Sebastian Kügler
Hola, We've sat down at the Plasma sprint and reviewed Plasma 5 from our armchairs. Here are the notes I've taken during that session. = Plasma 5 Review = == Specific Bugs == * New default wallpaper not applied to login manager and splash screen * Pager should collapse when number of virtual de

Re: Review Request 122662: Meta-Tab activity switching for plasma-desktop

2015-02-21 Thread Ivan Čukić
> On Feb. 21, 2015, 1:40 p.m., Bhushan Shah wrote: > > plasma-desktop-git > > /usr/share/plasma/shells/org.kde.plasma.desktop/contents/activitymanager/import/ > > plasma-desktop-git > > /usr/share/plasma/shells/org.kde.plasma.desktop/contents/activitymanager/import/activityswitcherextensionplug

Re: Review Request 122662: Meta-Tab activity switching for plasma-desktop

2015-02-21 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122662/ --- (Updated Feb. 21, 2015, 4:46 p.m.) Review request for Plasma, Bhushan Sha

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Hugo Pereira Da Costa
> On Feb. 21, 2015, 1:44 p.m., Hugo Pereira Da Costa wrote: > > "Preinstalled colours schemes to ensure consistent colouring" > > that is a regression with respect to exiting code. Its a no go. Please > > include. > > > > "Updated the behaviour of the resize grip - fixed bug for fullscreen" >

Re: Review Request 122648: Make notifications --reverse aware

2015-02-21 Thread Martin Klapetek
> On Feb. 20, 2015, 4:03 p.m., David Edmundson wrote: > > applets/notifications/package/contents/ui/NotificationItem.qml, line 132 > > > > > > Just > > LayoutMirroring.enabled: true > > > > and then

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Ken Vermette
> On Feb. 21, 2015, 1:44 p.m., Hugo Pereira Da Costa wrote: > > "Preinstalled colours schemes to ensure consistent colouring" > > that is a regression with respect to exiting code. Its a no go. Please > > include. > > > > "Updated the behaviour of the resize grip - fixed bug for fullscreen" >

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/#review76384 --- Based on the screenshot it looks like the red circle for the c

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/#review76383 --- Personally I find the colored circles quite distracting, if I

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Ken Vermette
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/ --- (Updated Feb. 21, 2015, 2:53 p.m.) Review request for Plasma and Hugo Per

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Ken Vermette
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/ --- (Updated Feb. 21, 2015, 2:47 p.m.) Review request for Plasma and Hugo Per

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/#review76378 --- "Preinstalled colours schemes to ensure consistent colouring"

Re: Review Request 122662: Meta-Tab activity switching for plasma-desktop

2015-02-21 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122662/#review76377 --- plasma-desktop-git /usr/share/plasma/shells/org.kde.plasma.de

Re: Review Request 122662: Meta-Tab activity switching for plasma-desktop

2015-02-21 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122662/ --- (Updated Feb. 21, 2015, 1:08 p.m.) Review request for Plasma, Bhushan Sha

Review Request 122662: Meta-Tab activity switching for plasma-desktop

2015-02-21 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122662/ --- Review request for Plasma, Bhushan Shah and Marco Martin. Repository: pla

Re: Review Request 122595: Make it possible to let plasmoids to load scripts outside the plasma package

2015-02-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122595/ --- (Updated Feb. 21, 2015, 1:56 p.m.) Review request for Plasma. Changes -

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/#review76373 --- Looks good to me. - David Edmundson On Feb. 21, 2015, 11:45

Jenkins build is back to normal : plasma-workspace_master_qt5 #1353

2015-02-21 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Ken Vermette
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/ --- (Updated Feb. 21, 2015, 11:45 a.m.) Review request for Plasma and Hugo Pe

Build failed in Jenkins: plasma-workspace_master_qt5 #1352

2015-02-21 Thread KDE CI System
See Changes: [aleixpol] Fix plasma-workspace build -- [...truncated 3106 lines...] ^

Re: Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/#review76370 --- kdecoration/breezedecoration.cpp

Review Request 122660: Breeze Decoration Redesign

2015-02-21 Thread Ken Vermette
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122660/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-21 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122452/#review76325 --- Ship it! Design with transparent background is nice. But plea

Re: Review Request 122452: [shell] Emit dbus signals in org.kde.osdService

2015-02-21 Thread Heiko Tietze
> On Feb. 20, 2015, 9:39 vorm., Heiko Tietze wrote: > > Design with transparent background is nice. But please consider multiple > > notifications. For instance, "You got 5 new mails", "You have been > > mentioned on IRC", plus the loudness indicator. It would be nice to not > > only show the

Re: Review Request 122648: Make notifications --reverse aware

2015-02-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/#review76364 --- Ship it! Ship It! - Marco Martin On Feb. 20, 2015, 8:07 p.