KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 282 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/282/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 28 Apr 2018 03:33:15 + Build duration: 1 min 22 sec and counting CONSOLE

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick added a comment. I know that DrKonqi hardly pops up these days. But still, if this button became more popular, then D11235 and D11236 might get some attention as well... REPOSITORY R871 DrKonqi REVISION

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

zzag added a comment. I've just noticed that it's calling `setMinimumSize`. Why? (especially, with such a big minimum size) What about icon based view mode, i.e. the old settings layout? The new settings layout(with sidebar) is still usable with window sizes smaller than 1024x700.

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

ngraham added inline comments. INLINE COMMENTS > SettingsBase.cpp:107 > > +setMinimumSize(SettingsBase::sizeHint()); > + You've already added a `setMinimumSize()` call below (under the "// enforce minimum window size" comment); do we need this second one here? REPOSITORY R124 System

D12498: Fully remove `Application Name` from Details panel

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > authdetails.ui:26 > > - Action: > + Action ID: > Can you also change it for the placeholder label (row 2, col 1) - convention is to

D12539: Klipper: Do not insert secret data into history

graesslin added a comment. In D12539#254330 , @broulik wrote: > > And it's probably something we also want to add to KWallet and maybe every password field we have. > > Since when can you Copy from password fields? I just locked my

D12563: [Run Command] Add closable property so that close button can be disabled.

dscheffer created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dscheffer requested review of this revision. REVISION SUMMARY When using RunCommand.qml, e.g. as part of a plasmoid, it does not always make sense to have a

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in SettingsBase.cpp:108 > Do we actually need this? It wasn't referenced anywhere else in the project. Probably a leftover from times long ago. REPOSITORY R124 System Settings REVISION

D12252: Enlarge default window size. Use (adjusted) calculation in `SizeHint` to determine minimum window width.

sharvey updated this revision to Diff 33208. sharvey added a comment. - Remove old, unused call to KConfig "MainWindow" REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12252?vs=32814=33208 BRANCH enlarge-default-size (branched from master)

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.10 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.10/2/ Project: Plasma kwin kf5-qt5 SUSEQt5.10 Date of build: Fri, 27 Apr 2018 14:43:48 + Build duration: 5 min 43 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 153 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/153/ Project: Plasma kwin kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 27 Apr 2018 14:43:48 + Build duration: 4 min 19 sec and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 281 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/281/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 27 Apr 2018 14:32:18 + Build duration: 50 sec and counting CONSOLE OUTPUT

D12459: [Icon KCM] Port to new design

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9496728fcb6c: [Icon KCM] Port to new design (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12459?vs=33086=33206#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

[systemsettings] [Bug 367619] icon kcm: remove advanced tab

https://bugs.kde.org/show_bug.cgi?id=367619 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |FIXED

D12459: [Icon KCM] Port to new design

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Go go go REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12459 To: broulik, #plasma, #vdg, hein Cc: lueck, schwarzer, hein, zzag, abetts, ngraham,

D9678: Delay loading most used model

broulik planned changes to this revision. broulik added a comment. Will look whether we can exploit the `canFetchMore` capability for lazyloadng REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D9678 To: broulik, #plasma, mart, davidedmundson Cc:

D10858: [Solid Device Engine] Connect device signals initially

broulik abandoned this revision. broulik added a comment. Bug looks more like in Solid or even UDisks. I get a `setupDone` signalled prematurely at times REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10858 To: broulik, #plasma, mart Cc: bruns,

D12549: [Lock Screen] Match OSD fade out to desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R120:28a4a59b7524: [Lock Screen] Match OSD fade out to desktop (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12549?vs=33174=33199