D21829: Improved Touch support for Kickoff

steffenh added a comment. Oh, sorry, I have the feeling I have misunderstood the post from @hein, I have the impression he wants to make a patch to DragHelper, but if I read this again, so sorry. I have the last days looking at plasma-frameworks, but my knowledge of the working of plasm

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 70 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/70/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 20 Jul 2019 22:35:08 + Build duration: 6 min 25 sec and counting CONSOLE OUTPUT [...tr

D22485: wrap the details example label+spacer in a container widget

This revision was automatically updated to reflect the committed changes. Closed by commit R871:5a59721d7efe: wrap the details example label+spacer in a container widget (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22485?vs=62038&id=621

D22485: wrap the details example label+spacer in a container widget

sitter added a comment. bug had one. but true enough FTR: without this diff F7062349: Screenshot_20190721_002927.png with this diff F7062351: Screenshot_20190721_003021.png REPOSITORY R871 DrKo

D21667: Optionally display threads as if they were processes

topimiettinen updated this revision to Diff 62153. topimiettinen added a comment. untabify REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21667?vs=59398&id=62153 REVISION DETAIL https://phabricator.kde.org/D21667 AFFECTED FILES processcore/p

D22596: [MPRIS Data Engine] Ignore non-standards compliant players

broulik updated this revision to Diff 62151. broulik added a comment. - Ensure we always disconnect the initial fetch finished signal REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22596?vs=62148&id=62151 REVISION DETAIL https://phabricator.kde.

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

cullmann added a comment. Thanks! REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: cullmann, wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, Z

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure added a comment. Backported. https://commits.kde.org/kde-cli-tools/42ef318a9d1c454f96b60181d8231a59233720ea REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel,

D22596: [MPRIS Data Engine] Ignore non-standards compliant players

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Properties like `Identity`, `SupportedUriSchemes`, `SupportedMimeTypes` are mandatory. Ignore the

D22588: [Pager] Don't link kdelibs4support

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e75f1e5039a3: [Pager] Don't link kdelibs4support (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22588?vs=62127&id=62147 REVISION DETA

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. I'm not familiar with KDE release engineering, so I'm asking to do merging someone else. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #f

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. FWIW, Gnome appear to be calling theirs 'Gnome on Xorg' (and likewise, just 'Gnome' for the wayland session). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson Cc: rdieter, fvogt,

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

wbauer added a comment. What about the stable 5.16 branch? It has only be committed to master so far AFAICS, so the fix would only end up in Plasma 5.17 which is still 3 months away... REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #fr

D21112: Support message response and reply callbacks

fvogt added a comment. Code looks good and seems to work fine in vivaldi, but I get an error in firefox: Promise resolved after context unloaded extension.js:78 sendSettings moz-extension://d1f34b4e-4e97-40a5-b4ac-03dc2fea30a9/extension.js:78 appears to be harmless tho

D22589: Embrace X-KDE-Wayland-Interfaces

apol created this revision. apol added reviewers: Plasma, KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Requests several KWin-specific interfaces to be used on KRunner and Plasma Shell. TEST PLAN See D

D21112: Support message response and reply callbacks

broulik updated this revision to Diff 62129. broulik added a comment. - Use promises REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21112?vs=57839&id=62129 REVISION DETAIL https://phabricator.kde.org/D21112 AFFECTED FILES extension/

D22588: [Pager] Don't link kdelibs4support

pino added inline comments. INLINE COMMENTS > shubham wrote in CMakeLists.txt:18 > Could you please remove this or the occurrence below at line 21? In a separate patch, not in this one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22588 To: broulik, #plasma,

D20830: Add hack to unbreak audio playback through pure JS via new Audio()

fvogt added a comment. Still can't reproduce, but doesn't seem to intruduce a regression either REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D20830 To: broulik, #plasma, fvogt Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragre

D22588: [Pager] Don't link kdelibs4support

shubham added inline comments. INLINE COMMENTS > CMakeLists.txt:18 >Qt5::Core >Qt5::DBus >Qt5::Qml Could you please remove this or the occurrence below at line 21? REPOSITORY R119 Plasma Desktop REVISION DETAIL https:/

D22588: [Pager] Don't link kdelibs4support

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It's not used TEST PLAN Compiles REPOSITORY R119 Plasma Desktop REVISION DETAIL http

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

This revision was automatically updated to reflect the committed changes. Closed by commit R126:6d86fd453417: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with… (authored by arrowd). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kd

D22418: WIP [wayland] make automatic backend selection truly automatic

graesslin added a comment. I'm not convinced that removing the ifdef is the solution to the problem. What you basically want is being able to do an out-of-tree build of a backend. Ideally you would want to install all the variants next to each other and be able to pick the correct one.

D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

apol added a comment. +1 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22564 To: ngraham, mart, #kirigami Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, mart, hein

D22579: Load QtQuickSettings from ksplashqml

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Then please improve a better commit message (and possibly close using BUG?). REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D22579 To: davide

D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

ngraham updated this revision to Diff 62116. ngraham marked an inline comment as done. ngraham added a comment. Remove unnecessary `!settings.isMobile` checks REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22564?vs=62068&id=62116 BRANCH respect-scrollba

D22579: Load QtQuickSettings from ksplashqml

davidedmundson added a comment. > What does this fix? Fabian's laptop :D It means the ksplash will apply software rendering/which render loop/GL profile as determined by your settings in "kcmshell5 qtquicksettings". plasma-workspace, systemsettings etc apply it, I missed ksplash.

D21517: Fix "Type error" when creating a TextField with focus: true

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:e419e9b42287: Fix "Type error" when creating a TextField with focus: true (authored by dfaure). Herald added a project:

D22579: Load QtQuickSettings from ksplashqml

apol added a comment. What does this fix? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22579 To: davidedmundson, #plasma Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreut

D22363: Remove cursor theme option

davidedmundson added inline comments. INLINE COMMENTS > filipf wrote in advanceconfig.cpp:205 > I need the identifier to delete the entry in the config file (done in > sddmauthhelper.cpp), the value is not important so I just set whatever. Any > smarter way of doing this? args[QStringLiteral("

D22579: Load QtQuickSettings from ksplashqml

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Code is copy/paste REPOSITORY R120 Plasma Workspace BRANCH master REVISION DE

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, I'm wrong (not the first time this happens) :-) `kwrite /home/dfaure/.zshrc:20` works `kwrite sftp://localhost/home/dfaure/.zshrc:20` doesn't work indeed. The patch looks fine

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#498393 , @dfaure wrote: > I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc. > So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries have

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc. So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries h

D22363: Remove cursor theme option

filipf updated this revision to Diff 62101. filipf added a comment. remove weird stuff from the .ui file REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22363?vs=62075&id=62101 BRANCH remove-cursor-theme-option (branched from master

D22363: Remove cursor theme option

filipf added inline comments. INLINE COMMENTS > davidedmundson wrote in sddmauthhelper.cpp:119 > Task for another day, we don't need to pass this in every time. > > We can set this at compile time, using the same values from config.h as the > KCM would use +1 > davidedmundson wrote in advance

D22564: [RFC] [SwipeListItem] Take into account scrollbar visibility and form factor

apol added inline comments. INLINE COMMENTS > SwipeListItem.qml:241 > verticalCenter: parent.verticalCenter > -rightMargin: Units.gridUnit > +rightMargin: !Settings.isMobile && behindItem.view && > behindItem.view.T2.ScrollBar && behindItem.view.T

D22485: wrap the details example label+spacer in a container widget

apol added a comment. When doing this kind of changes it would be useful to have a screenshot by it. REPOSITORY R871 DrKonqi BRANCH spacer REVISION DETAIL https://phabricator.kde.org/D22485 To: sitter, #plasma, apol Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, P

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 69 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/69/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Sat, 20 Jul 2019 07:50:28 + Build duration: 7 min 54 sec and counting CONSOLE OUTPUT [...tr