graesslin added a comment.
I think all your ifdefs are not needeed. Neither are the x11 runtime checks.
INLINE COMMENTS
imports/activitymanager/sortedactivitiesmodel.cpp:195-217 I don't understand
why you made this conditional. It should also work on Wayland.
imports/activitymanager/sorte
ivan marked an inline comment as done.
INLINE COMMENTS
imports/activitymanager/sortedactivitiesmodel.h:25 I've used the same thing
mgraesling used in kwinsys.
imports/activitymanager/sortedactivitiesmodel.h:106 Went for David's idea -
one bool less to save :)
REPOSITORY
rPLASMADESKTOP Pla
ivan updated the summary for this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1009
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, mart, davidedmundson, graesslin, sebas
Cc: plasma-devel
_
ivan updated the summary for this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1009
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: ivan, mart, davidedmundson, graesslin, sebas
Cc: plasma-devel
_