Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-25 Thread Aleix Pol
On Fri, May 23, 2014 at 12:22 PM, Sebastian Kügler wrote: > On Friday, May 23, 2014 12:18:55 Marco Martin wrote: > > I think it's a counter-effect of when i removed KConfigWidgets from > > libplasma. there is definitely a problem in the cmake there, qt5::gui > > should be in public in libplasma,

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Sebastian Kügler
On Friday, May 23, 2014 12:18:55 Marco Martin wrote: > I think it's a counter-effect of when i removed KConfigWidgets from > libplasma. there is definitely a problem in the cmake there, qt5::gui > should be in public in libplasma, right? That's how I understand Aleix. -- sebas http://www.kde.org

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Marco Martin
I think it's a counter-effect of when i removed KConfigWidgets from libplasma. there is definitely a problem in the cmake there, qt5::gui should be in public in libplasma, right? On Friday 23 May 2014, Sebastian Kügler wrote: > CC:ing plasma-devel. Any input on this? (I just fixed the build in th

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Sebastian Kügler
CC:ing plasma-devel. Any input on this? (I just fixed the build in the most obvious way, perhaps someone knows why Qt5::Gui had been removed from the implicit public targets in the first place? On Friday, May 23, 2014 00:54:17 Aleix Pol wrote: > KF5::Plasma should have Qt5::Gui as public depende