Re: AccountsService qt binding for sddm, plasma-workspace

2015-08-03 Thread Sebastian Kügler
On Saturday, August 01, 2015 00:46:56 Jonathan Riddell wrote: > On Sat, Aug 01, 2015 at 02:04:09AM +0200, David Edmundson wrote: > > We had kcm_useraccounts in plasma-desktop, which is super old and rubbish > > > > We had user-manager, somwhere, which is Alex's one.It uses > > accounts-service, via

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-08-01 Thread Martin Klapetek
On Sat, Aug 1, 2015 at 4:14 AM, Leslie Zhai wrote: > > During this month (July) I also developed kscreen osd > https://twitter.com/xiangzhai/status/624501420679495680 > > Migrated kscreen plasma applet to KF5 > https://twitter.com/xiangzhai/status/626265546221195264 > > https://projects.kde.org/p

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-31 Thread Leslie Zhai
On 2015年08月01日 08:04, David Edmundson wrote: On Fri, Jul 31, 2015 at 11:33 PM, Jonathan Riddell > wrote: Thanks for doing this, the kcm_useraccounts has long needed to be replaced. It was a longstanding todo item to replace it with user-manager which

Re: AccountsService qt binding for sddm, plasma-workspace

2015-07-31 Thread Jonathan Riddell
On Sat, Aug 01, 2015 at 02:04:09AM +0200, David Edmundson wrote: > We had kcm_useraccounts in plasma-desktop, which is super old and rubbish > > We had user-manager, somwhere, which is Alex's one.It uses accounts-service, > via it's own lib > > In plasma-desktop we have a branch caller user-accou

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-31 Thread David Edmundson
On Fri, Jul 31, 2015 at 11:33 PM, Jonathan Riddell wrote: > Thanks for doing this, the kcm_useraccounts has long needed to be replaced. > > It was a longstanding todo item to replace it with user-manager which > I've by coincidence just done tonight by using KEMailSettings as well > as accountsse

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-31 Thread Jonathan Riddell
Thanks for doing this, the kcm_useraccounts has long needed to be replaced. It was a longstanding todo item to replace it with user-manager which I've by coincidence just done tonight by using KEMailSettings as well as accountsservice. user-manager does much of what you have implemented in your r

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-30 Thread Leslie Zhai
well done! I will follow your code ;P On 2015年07月31日 14:04, Pier Luigi Fiorini wrote: 2015-07-29 11:02 GMT+02:00 David Edmundson : Hey, sorry for not replying. 5.4 is being frozen soon, so lets consider this 5.5 material, so we don't have to rush. In general, I like it, I have some comments.

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-30 Thread Pier Luigi Fiorini
2015-07-29 11:02 GMT+02:00 David Edmundson : > Hey, sorry for not replying. > > 5.4 is being frozen soon, so lets consider this 5.5 material, so we don't > have to rush. > > In general, I like it, I have some comments. > > I'm a bit concerned by the blocking calls in AccountsService here: > https:/

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-29 Thread Sebastian Kügler
[Re-added everybody to CC:] On Wednesday, July 29, 2015 17:33:18 Leslie Zhai wrote: > Thanks for your replay > > I will take replace KUser with AccountsService ASAP. You can't do that, KUser is public API. What I was suggesting is to do your changes inside KUser, so the API stays the same, but

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-29 Thread David Edmundson
On Wed, Jul 29, 2015 at 11:25 AM, Leslie Zhai wrote: > > > On 07/29/2015 05:02 PM, David Edmundson wrote: > >> Hey, sorry for not replying. >> > Never mind, thanks for your reply ;P > > >> 5.4 is being frozen soon, so lets consider this 5.5 material, so we don't >> have to rush. >> > OK. > > >> I

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-29 Thread Leslie Zhai
On 07/29/2015 05:02 PM, David Edmundson wrote: Hey, sorry for not replying. Never mind, thanks for your reply ;P 5.4 is being frozen soon, so lets consider this 5.5 material, so we don't have to rush. OK. In general, I like it, I have some comments. I'm a bit concerned by the blocking

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-29 Thread Sebastian Kügler
On Wednesday, July 29, 2015 11:02:03 David Edmundson wrote: > In here: > http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=3fa23fc71131c2 > 39201bec7e7841455d3c5e5a2c&hp=b500ba44c2b483d7372ca46840152c90ef5f798c&hb=1f > 308546910b1e3e63542bb1982778755e8ff99d&f=ksmserver%2Fscreenlocker%2Fg

Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-29 Thread David Edmundson
Hey, sorry for not replying. 5.4 is being frozen soon, so lets consider this 5.5 material, so we don't have to rush. In general, I like it, I have some comments. I'm a bit concerned by the blocking calls in AccountsService here: https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src

AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop kickoff face icon, config by advanced useraccount

2015-07-26 Thread Leslie Zhai
Hi KDE developers, My sincere thanks goes to Pier Luigi Fiorini, core developer of sddm https://github.com/sddm/sddm he developed AccountsService qt binding https://github.com/hawaii-desktop/qtaccountsservice So I want to use AccountsService http://www.freedesktop.org/wiki/Software/AccountsS