Re: QWebFrame and baseUrl

2009-11-10 Thread Aaron J. Seigo
On November 10, 2009, Thiago Macieira wrote: > if package()->filePath() returns a URL, it should have file:// already. > > If it returns a file name, you should be using QUrl::fromLocalFile. It returns a file name. It does not return a URL because the file is guaranteed to be local to thing (e.g

Re: QWebFrame and baseUrl

2009-11-10 Thread Thiago Macieira
Em Terça-feira 10 Novembro 2009, às 15:02:15, ext Petri Damstén escreveu: > On Tuesday 10 November 2009 15:42:18 Kenneth Christiansen wrote: > > Hi again. > > > > I talked to Thiago Macieira and he told me that QUrl in 4.6 is more > > strict than in 4.5, but there isn't any behaviour change. > > >

Re: QWebFrame and baseUrl

2009-11-10 Thread Thiago Macieira
Em Terça-feira 10 Novembro 2009, às 14:42:18, ext Kenneth Christiansen escreveu: > Hi again. > > I talked to Thiago Macieira and he told me that QUrl in 4.6 is more > strict than in 4.5, but there isn't any behaviour change. > > Can you please give me examples that stopped working? > > cc'ing T

Re: QWebFrame and baseUrl

2009-11-10 Thread Petri Damstén
On Tuesday 10 November 2009 15:42:18 Kenneth Christiansen wrote: > Hi again. > > I talked to Thiago Macieira and he told me that QUrl in 4.6 is more > strict than in 4.5, but there isn't any behaviour change. > > Can you please give me examples that stopped working? d->page->mainFrame()->setHtml

Re: QWebFrame and baseUrl

2009-11-10 Thread Kenneth Christiansen
Hi again. I talked to Thiago Macieira and he told me that QUrl in 4.6 is more strict than in 4.5, but there isn't any behaviour change. Can you please give me examples that stopped working? cc'ing Thiago. Cheers, Kenneth On Mon, Nov 9, 2009 at 5:28 PM, Aaron J. Seigo wrote: > On November 9, 2

Re: QWebFrame and baseUrl

2009-11-09 Thread Aaron J. Seigo
On November 9, 2009, Kenneth Christiansen wrote: > So I wonder why this stopped working, if this is due to a QUrl change, > due to our change or due to a change in WebKit itself. yes, with a switch to KUrl it apparently started working (URLs with #s in them were one issue iirc?) -- Aaron J. Sei

Re: QWebFrame and baseUrl

2009-11-09 Thread Kenneth Christiansen
Hi there, Strange... We merely fixed the behavior to be as expected and documented. setHtml was totally broken. It was adding the baseurl to the session history if one was supplied, and not adding anything if nothing was supplied. That has now been fixed. So I wonder why this stopped working, i

Re: QWebFrame and baseUrl

2009-11-04 Thread Aaron J. Seigo
On November 4, 2009, Marco Martin wrote: > anyways, the patch looks good yes, please commit (and grrr! to the trolls for changing behaviour like this) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt

Re: QWebFrame and baseUrl

2009-11-04 Thread Marco Martin
On Wednesday 04 November 2009, Petri Damstén wrote: > Hi, > > Seems that after update to 4.6 webkit scriptengine stopped working. Problem > is that now baseUrl has to have scheme in it to work. Is this intentional > feature in 4.6? Could be for security? not permitting local urls in some situat

QWebFrame and baseUrl

2009-11-04 Thread Petri Damstén
Hi, Seems that after update to 4.6 webkit scriptengine stopped working. Problem is that now baseUrl has to have scheme in it to work. Is this intentional feature in 4.6? Petri Index: webapplet.cpp === --- webapplet.cpp (revi