Re: Request for review

2014-02-17 Thread Martin Klapetek
On Mon, Feb 17, 2014 at 8:01 AM, Conny Marco Menebröcker < ad...@menebroecker-web.de> wrote: > I will read the tutorial and decide afterwards, if I will change something. > I don't know much about QML, I thought it was only a specific programming > language for QT development. > So, currently I do

Re: Request for review

2014-02-16 Thread Conny Marco Menebröcker
Hello Martin, Am 16.02.2014 17:41, schrieb Martin Klapetek: Hey, -- Forwarded message -- From: Conny Marco Menebröcker mailto:ad...@menebroecker-web.de>> Date: Sat, Feb 15, 2014 at 7:44 PM Subject: Request for review To: kde-de...@kde.org

Re: Request for review

2014-02-16 Thread Martin Klapetek
Hey, -- Forwarded message -- > From: Conny Marco Menebröcker > Date: Sat, Feb 15, 2014 at 7:44 PM > Subject: Request for review > To: kde-de...@kde.org > > > Hello all, > > > I have written my first plasmoid. I called it PlasmaTaskViewer, > because it views the todos of a calendar

Re: request for review

2012-03-19 Thread Shaun Reich
On Mon, Mar 19, 2012 at 6:28 AM, Sebastian Kügler wrote: > (Positive, because it works, negative, because I > might have been looking for my furry porn collection, not something I'd want > to tell any web services.) yeah, good point. i don't want google knowing i'm into furry porn either. as for

Re: Re: request for review

2012-03-19 Thread Shaun Reich
On Mon, Mar 19, 2012 at 6:33 AM, Alex Fiestas wrote: > On Monday, March 19, 2012 11:28:22 AM Sebastian Kügler wrote: >> Hey, >> >> One potential issue I see is that you ship the youtube logo inside the >> runner. We might not be allowed to redistribute it as that. >> >> It also scales badly, so lo

Re: Re: request for review

2012-03-19 Thread Dario Freddi
Il 19 marzo 2012 11:33, Alex Fiestas ha scritto: >> Also, enabling these runners by default, which you've essentially done, >> brings a great privacy problem -- everything I type into KRunner is sent to >> Google and Bing -- that's not acceptable as such, at least should be >> discussed before we

Re: request for review

2012-03-19 Thread Aaron J. Seigo
On Monday, March 19, 2012 11:33:13 Alex Fiestas wrote: > In theory they will only be triggered if the prefix match, kinda > > youtube: kde rocks this is easy for the runner itself to do. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. _

Re: Re: request for review

2012-03-19 Thread Alex Fiestas
On Monday, March 19, 2012 11:28:22 AM Sebastian Kügler wrote: > Hey, > > One potential issue I see is that you ship the youtube logo inside the > runner. We might not be allowed to redistribute it as that. > > It also scales badly, so looks visually tarred. > > Can you check the license of the y

Re: request for review

2012-03-19 Thread Sebastian Kügler
Hey, One potential issue I see is that you ship the youtube logo inside the runner. We might not be allowed to redistribute it as that. It also scales badly, so looks visually tarred. Can you check the license of the youtube logo, and if we're allowed to ship it, make it look correct? Also, e

Re: request for review

2012-03-16 Thread Shaun Reich
> .. assuming i'm understanding what you're asking :) yep, answers exactly that. -- Shaun Reich, KDE Software Developer (kde.org) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: request for review

2012-03-16 Thread Aaron J. Seigo
On Friday, March 16, 2012 13:10:54 Shaun Reich wrote: > i do have a question however, as to why matches get triggered (even > for the mediawiki engine which currently resides in there, afict), > even though it isn't in singlerunnermode, and the prefix isn't being > hit. e.g. user is typing in "some