Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

2016-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/ --- (Updated Oct. 17, 2016, 3:46 p.m.) Status -- This change has been ma

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

2016-10-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/#review100087 --- Ship it! Ship It! - Marco Martin On Sept. 29, 2016, 11

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

2016-09-29 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/ --- (Updated Sept. 29, 2016, 11:50 p.m.) Review request for KDE Frameworks an

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

2016-09-29 Thread David Edmundson
> On Sept. 29, 2016, 8:25 a.m., Marco Martin wrote: > > are you sure they are completely interchangeable? (would have to have an > > ifdef otherwise) they're not completely intechangable normally, but for this particular case it seems fine. I've just filled in the Testing Done propery. This

Re: Review Request 129065: Fix frameworks compilation with Qt < 5.6

2016-09-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129065/#review99654 --- are you sure they are completely interchangeable? (would have