Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

> On Aug. 27, 2012, 4:32 p.m., Sebastian Kügler wrote: > > mainwindow.cpp, line 1026 > > > > > > Why not just } else { ? Sorry for my late reply but i am/will be very busy for the following days. Because we alway

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review18117 --- Ship it! Looking good now :) mainwindow.cpp

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- (Updated Aug. 27, 2012, 4:06 p.m.) Review request for kwin, Plasma, Sebast

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review18087 --- konsole/konsolepreviewer.cpp

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- (Updated Aug. 27, 2012, 7:18 a.m.) Review request for kwin, Plasma, Sebast

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

On Friday, August 24, 2012 10:23:07 Antonis Tsiapaliokas wrote: > > On Aug. 23, 2012, 10:19 p.m., Sebastian Kügler wrote: > > > mainwindow.cpp, line 261 > > > > > e261>> > > > > I don't really like this deviation in beha

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

> On Aug. 23, 2012, 10:19 p.m., Sebastian Kügler wrote: > > mainwindow.cpp, line 261 > > > > > > I don't really like this deviation in behavior, mainly because I don't > > see a reason for it. > > > > I th

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review17927 --- konsole/konsolepreviewer.cpp

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review17847 --- mainwindow.cpp

Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and Giorg