Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated Oct. 2, 2015, 2:26 p.m.) Status -- This change has been mar

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 30, 2015, 10:53 a.m.) Review request for Plasma and Eike Hein

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/#review86137 --- Ship it! Ship It! - Eike Hein On Sept. 30, 2015, 12:33 a.m

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 30, 2015, 9:33 a.m.) Review request for Plasma and Eike Hein.

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 30, 2015, 9:31 a.m.) Review request for Plasma and Eike Hein.

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On 9月 30, 2015, 7:32 a.m., Eike Hein wrote: > > There are some problems left I think: > > > > a) I think the delegate should be 'toolTipDelegate' (from main.qml) as used > > by MenuRepresentation's SideBarItem.qml. > > > > b) TextMetrics needs to have a font set - should be toolTipDelegate.f

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On Sept. 29, 2015, 10:32 p.m., Eike Hein wrote: > > There are some problems left I think: > > > > a) I think the delegate should be 'toolTipDelegate' (from main.qml) as used > > by MenuRepresentation's SideBarItem.qml. > > > > b) TextMetrics needs to have a font set - should be toolTipDelega

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On Sept. 29, 2015, 10:32 nachm., Eike Hein wrote: > > There are some problems left I think: > > > > a) I think the delegate should be 'toolTipDelegate' (from main.qml) as used > > by MenuRepresentation's SideBarItem.qml. > > > > b) TextMetrics needs to have a font set - should be toolTipDele

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On Sept. 29, 2015, 10:32 nachm., Eike Hein wrote: > > There are some problems left I think: > > > > a) I think the delegate should be 'toolTipDelegate' (from main.qml) as used > > by MenuRepresentation's SideBarItem.qml. > > > > b) TextMetrics needs to have a font set - should be toolTipDele

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/#review86130 --- There are some problems left I think: a) I think the delegate

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On 9月 29, 2015, 10:12 p.m., Eike Hein wrote: > > applets/kicker/package/contents/ui/ItemGridDelegate.qml, line 139 > > > > > > It's better to use TextMetrics :) Wow nice! Thank you! - Takahiro

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 29, 2015, 10:55 p.m.) Review request for Plasma and Eike Hein

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/#review86108 --- applets/kicker/package/contents/ui/ItemGridDelegate.qml (line

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On 9月 29, 2015, 1:43 a.m., Eike Hein wrote: > > Good idea, but can you make it so that the tooltip is only shown when the > > text is elided? :) > > Takahiro Hashimoto wrote: > Thank you for your review and comment. Yes that's nice enhancement:) I'd > like to update patch. > > A

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

> On 9月 29, 2015, 1:43 a.m., Eike Hein wrote: > > Good idea, but can you make it so that the tooltip is only shown when the > > text is elided? :) Thank you for your review and comment. Yes that's nice enhancement:) I'd like to update patch. As the contentWidth of elided text object is adjust

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- (Updated 9月 29, 2015, 3:01 p.m.) Review request for Plasma and Eike Hein.

Re: Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/#review86055 --- Good idea, but can you make it so that the tooltip is only sho

Review Request 125402: [kickerdash] Show ToolTip when mouse hovered on app item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125402/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Des