D9313: Don't move back items to second screen if they were manually moved

2017-12-13 Thread Andras Mantia
amantia added reviewers: Plasma, hein, mwolff. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D9323: Use ScreenMapper everywhere as a singleton

2017-12-14 Thread Andras Mantia
amantia added reviewers: Plasma, mwolff, hein. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D9323: Use ScreenMapper everywhere as a singleton

2017-12-14 Thread Andras Mantia
amantia added inline comments. INLINE COMMENTS > broulik wrote in foldermodel.cpp:124 > Why have this member then? For convenience > broulik wrote in foldermodel.cpp:194 > I think we shouldn't connect to the signals if we're not a containment? Yes, that makes sense, I will fix it REPOSITORY

D9323: Use ScreenMapper everywhere as a singleton

2017-12-14 Thread Andras Mantia
amantia updated this revision to Diff 23897. amantia added a comment. Connect to screenammper only if used as a containment CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9323?vs=23894&id=23897 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9323 AFFECTED FILES co

D9325: Use QUrl in the ScreenMapper API

2017-12-14 Thread Andras Mantia
amantia added reviewers: Plasma, mwolff, dakon, broulik. amantia set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabric

D9300: Store screenMapping info only once

2017-12-14 Thread Andras Mantia
amantia added a comment. In https://phabricator.kde.org/D9300#179031, @broulik wrote: > Screen mapper is a singleton type, so it won't cause problems when one screen adds a mapping, it will propagate to the other containments automagically? Before we had `plasmoid.configuration` which si

D9313: Don't move back items to second screen if they were manually moved

2017-12-14 Thread Andras Mantia
amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9313 To: amantia, #plasma, hein, mwolff Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9300: Store screenMapping info only once

2017-12-15 Thread Andras Mantia
amantia added a comment. I will merge this latest on Monday if there is no further objection REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik, mlaurent, mart Cc: mart, mlaurent, plasma-devel, Zre

D9325: Use QUrl in the ScreenMapper API

2017-12-15 Thread Andras Mantia
amantia updated this revision to Diff 23954. amantia added a comment. Fixed issues pointed out by Laurent. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9325?vs=23898&id=23954 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9325 AFFECTED FILES containments/deskto

D9300: Store screenMapping info only once

2017-12-18 Thread Andras Mantia
amantia closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9300 To: amantia, #plasma, mwolff, hein, broulik, mlaurent, mart Cc: mart, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9323: Use ScreenMapper everywhere as a singleton

2017-12-22 Thread Andras Mantia
amantia closed this revision. REVISION DETAIL https://phabricator.kde.org/D9323 To: amantia, #plasma, mwolff, hein Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

<    1   2   3