amantia added reviewers: Plasma, hein, mwolff.
amantia set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.o
amantia added reviewers: Plasma, mwolff, hein.
amantia set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.o
amantia added inline comments.
INLINE COMMENTS
> broulik wrote in foldermodel.cpp:124
> Why have this member then?
For convenience
> broulik wrote in foldermodel.cpp:194
> I think we shouldn't connect to the signals if we're not a containment?
Yes, that makes sense, I will fix it
REPOSITORY
amantia updated this revision to Diff 23897.
amantia added a comment.
Connect to screenammper only if used as a containment
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9323?vs=23894&id=23897
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9323
AFFECTED FILES
co
amantia added reviewers: Plasma, mwolff, dakon, broulik.
amantia set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabric
amantia added a comment.
In https://phabricator.kde.org/D9300#179031, @broulik wrote:
> Screen mapper is a singleton type, so it won't cause problems when one
screen adds a mapping, it will propagate to the other containments
automagically? Before we had `plasmoid.configuration` which si
amantia closed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9313
To: amantia, #plasma, hein, mwolff
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
amantia added a comment.
I will merge this latest on Monday if there is no further objection
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9300
To: amantia, #plasma, mwolff, hein, broulik, mlaurent, mart
Cc: mart, mlaurent, plasma-devel, Zre
amantia updated this revision to Diff 23954.
amantia added a comment.
Fixed issues pointed out by Laurent.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9325?vs=23898&id=23954
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9325
AFFECTED FILES
containments/deskto
amantia closed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9300
To: amantia, #plasma, mwolff, hein, broulik, mlaurent, mart
Cc: mart, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
amantia closed this revision.
REVISION DETAIL
https://phabricator.kde.org/D9323
To: amantia, #plasma, mwolff, hein
Cc: mlaurent, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
201 - 211 of 211 matches
Mail list logo