Re: [PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

2015-11-06 Thread David Herrmann
Hi Darren! On Wed, Oct 21, 2015 at 4:44 PM, Darren Hart wrote: > On Wed, Oct 21, 2015 at 12:33:52PM -0200, Henrique de Moraes Holschuh wrote: >> On Wed, Oct 21, 2015, at 08:46, David Herrmann wrote: >> > The thinkpad_acpi driver currently emits error messages on unsupport

[PATCH] thinkpad_acpi: don't yell on unsupported brightness interfaces

2015-10-21 Thread David Herrmann
are supported by the i915 driver just fine. Downgrade the error message to a normal pr_info() and stop telling people to report it to IBM. Signed-off-by: David Herrmann --- drivers/platform/x86/thinkpad_acpi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform

Re: [PATCH] platform/x86/toshiba-apci.c possible bad if test?

2014-08-20 Thread David Herrmann
Hi On Fri, Jun 13, 2014 at 5:04 AM, Nick wrote: > diff --git a/drivers/platform/x86/toshiba_acpi.c > b/drivers/platform/x86/toshiba_acpi.c > index 76441dc..dfd2243 100644 > --- a/drivers/platform/x86/toshiba_acpi.c > +++ b/drivers/platform/x86/toshiba_acpi.c > @@ -1238,7 +1238,7 @@ static ssize_

Re: [PATCH] ACPI / Video: blacklist some samsung laptops

2012-02-20 Thread David Herrmann
Hi Len On Sun, Feb 19, 2012 at 8:56 PM, Corentin Chary wrote: > On Mon, Jan 30, 2012 at 9:26 AM, Corentin Chary > wrote: >> On Tue, Jan 17, 2012 at 8:08 AM, Corentin Chary >> wrote: >>> On these laptops, the ACPI video is not functional, and very unlikely >>> to be fixed by the vendor. Note th

Re: [PATCH] ACPI / Video: blacklist some samsung laptops

2012-01-09 Thread David Herrmann
e a charm on my N210 with linux-3.2. Feel free to add a: Tested-by: David Herrmann I will talk to the intel drm developers about the intel_backlight issues as they don't seem related to this driver. Thanks David -- To unsubscribe from this list: send the line "unsubscribe platf

Re: [PATCH] Platform: samsung-laptop: add DMI information for Samsung N150 Plus

2011-12-29 Thread David Herrmann
On Thu, Dec 29, 2011 at 12:49 PM, Corentin Chary wrote: > On Thu, Dec 29, 2011 at 12:45 PM, Richard Schütz wrote: >> Am 29.12.2011 11:23, schrieb Corentin Chary: >>> >>> On 12/26/2011 11:22 AM, David Herrmann wrote: >>> >>>> On Mon, Dec

Re: [PATCH] Platform: samsung-laptop: add DMI information for Samsung N150 Plus

2011-12-24 Thread David Herrmann
On Sat, Dec 24, 2011 at 3:20 PM, Matthew Garrett wrote: > On Sat, Dec 24, 2011 at 02:12:57PM +, Andrzej Prochyra wrote: >> 'acpi_video0' not functional.  Brightness can be controlled through >> intel_backlight interface.  There are 21 brightness levels and the >> backlight can be turned off. >

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-25 Thread David Herrmann
On Thu, Nov 24, 2011 at 8:07 AM, Corentin Chary wrote: > Hi David,I refreshed the patches on the github repo, could you re-try > them ?Thanks Works great. The error message doesn't appear anymore. The devices still work as expected. Tested-by: David Herrmann Thanks David > -- &g

Re: [PATCH 08/15] samsung-laptop: add battery life extender support

2011-11-23 Thread David Herrmann
On Wed, Nov 23, 2011 at 7:11 PM, Corentin Chary wrote: > On Wed, Nov 23, 2011 at 6:10 PM, David Herrmann > wrote: >> On Wed, Nov 23, 2011 at 5:54 PM, Corentin Chary >> wrote: >>>> My BIOS provides this option, too. However, this driver does not >&g

Re: [PATCH 08/15] samsung-laptop: add battery life extender support

2011-11-23 Thread David Herrmann
On Wed, Nov 23, 2011 at 5:54 PM, Corentin Chary wrote: >> My BIOS provides this option, too. However, this driver does not >> detect it on my machine. During initialization I get: >> samsung_laptop: SABI command 0x0078 failed with completion flag 0xaa >> >> Maybe you can help debugging this. If th

Re: [PATCH 15/15] samsung-laptop: promote myself as maintainer of samsung-laptop

2011-11-23 Thread David Herrmann
hset on my Samsung N210. It works for me. I've commented on a few patches about some small stuff. But it didn't break any existing stuff / introduce regressions. Feel free to carry this on the patches: Tested-by: David Herrmann http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/15] samsung-laptop: add keyboard backlight support

2011-11-23 Thread David Herrmann
On Wed, Nov 23, 2011 at 7:35 AM, Corentin Chary wrote: > On Tue, Nov 22, 2011 at 11:23 PM, Greg KH wrote: >> On Tue, Nov 22, 2011 at 11:02:42PM +0100, Corentin Chary wrote: >>> Signed-off-by: Corentin Chary >> >> What happens on boxes that don't have this type of hardware?  Will the >> LED devic

Re: [PATCH 10/15] samsung-laptop: cleanup KConfig

2011-11-23 Thread David Herrmann
On Tue, Nov 22, 2011 at 11:02 PM, Corentin Chary wrote: > Signed-off-by: Corentin Chary > --- >  drivers/platform/x86/Kconfig |   11 +++ >  1 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 7f43cf8..2f7a9a

Re: [PATCH 08/15] samsung-laptop: add battery life extender support

2011-11-23 Thread David Herrmann
Hi Corentin On Tue, Nov 22, 2011 at 11:02 PM, Corentin Chary wrote: > Signed-off-by: Corentin Chary > --- >  .../ABI/testing/sysfs-driver-samsung-laptop        |   10 +++ >  drivers/platform/x86/samsung-laptop.c              |   82 > >  2 files changed, 92 insertions(+), 0

Re: [PATCH 03/15] samsung-laptop: don't handle backlight if handled by acpi/video

2011-11-23 Thread David Herrmann
            samsung->handle_backlight = false; > +       } > +#endif > >        ret = samsung_platform_init(samsung); >        if (ret) > -- > 1.7.5.4 My Samsung model has an intel card which previously did not support the acpi video backlight so I needed the samsu

Re: [patch 5/8] Platform: Fix error path in samsung-laptop init

2011-09-20 Thread David Herrmann
Hi Greg On Fri, Sep 2, 2011 at 12:50 AM, wrote: > samsung_init() should not return success if not all devices are initialized. > Otherwise, samsung_exit() will dereference sdev NULL pointers and others. > > Signed-off-by: David Herrmann > Cc: stable > Signed-off-by:

Re: [PATCH] Platform: Brightness quirk for samsung laptop driver

2011-08-26 Thread David Herrmann
date_status(struct backlight_device *bd) >  { >        set_brightness(bd->props.brightness); > @@ -796,6 +836,9 @@ static int __init samsung_init(void) >                } >        } > > +       /* Check for stepping quirk */ > +       check_for_stepping_quirk(); >

[PATCH] Platform: Brightness quirk for samsung laptop driver

2011-08-23 Thread David Herrmann
. This patch adds detection and a non-intrusive workaround for the above issues. Signed-off-by: David Herrmann --- Hi This patch is originally from Jason Stubbs. See here: http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f=platform-samsung_laptop-add-support-for-samsung-nc210

[PATCH] Platform: Fix error path in samsung-laptop init

2011-08-23 Thread David Herrmann
samsung_init() should not return success if not all devices are initialized. Otherwise, samsung_exit() will dereference sdev NULL pointers and others. Signed-off-by: David Herrmann --- drivers/platform/x86/samsung-laptop.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git